From bbbbb3f8850907d413db4715c10ef6df055234f6 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Sun, 21 Oct 2018 23:36:23 -0400 Subject: [PATCH] qa: Add test to ensure node can generate all help texts at runtime --- test/functional/rpc_help.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/test/functional/rpc_help.py b/test/functional/rpc_help.py index be096af89..78d6e78ae 100755 --- a/test/functional/rpc_help.py +++ b/test/functional/rpc_help.py @@ -7,12 +7,18 @@ from test_framework.test_framework import BitcoinTestFramework from test_framework.util import assert_equal, assert_raises_rpc_error +import os + class HelpRpcTest(BitcoinTestFramework): def set_test_params(self): self.num_nodes = 1 def run_test(self): + self.test_categories() + self.dump_help() + + def test_categories(self): node = self.nodes[0] # wrong argument count @@ -37,6 +43,15 @@ class HelpRpcTest(BitcoinTestFramework): assert_equal(titles, components) + def dump_help(self): + dump_dir = os.path.join(self.options.tmpdir, 'rpc_help_dump') + os.mkdir(dump_dir) + calls = [line.split(' ', 1)[0] for line in self.nodes[0].help().splitlines() if line and not line.startswith('==')] + for call in calls: + with open(os.path.join(dump_dir, call), 'w', encoding='utf-8') as f: + # Make sure the node can generate the help at runtime without crashing + f.write(self.nodes[0].help(call)) + if __name__ == '__main__': HelpRpcTest().main()