LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Better txn_doublespend.py test

Browse source 
Remove reliance on accounting "move" ledger entries.  Instead,
create funding transactions (and deal with fee complexities).

Do not rely on broken SyncMetaData.  Instead expect double-spend
amount to be debited from the default "" account.
This commit is contained in:
Tom Harding 2015-03-11 14:29:06 -07:00
parent b2b3619262
commit defd2d55b7
1 changed files with 51 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

77
qa/rpc-tests/txn_doublespend.py
View file

@ -4,7 +4,7 @@
# file COPYING or http://www.opensource.org/licenses/mit-license.php. # file COPYING or http://www.opensource.org/licenses/mit-license.php.
# #
# Test proper accounting with malleable transactions # Test proper accounting with a double-spend conflict
# #
from test_framework import BitcoinTestFramework from test_framework import BitcoinTestFramework
@ -32,28 +32,40 @@ class TxnMallTest(BitcoinTestFramework):
self.nodes[i].getnewaddress("") # bug workaround, coins generated assigned to first getnewaddress! self.nodes[i].getnewaddress("") # bug workaround, coins generated assigned to first getnewaddress!
# Assign coins to foo and bar accounts: # Assign coins to foo and bar accounts:
self.nodes[0].move("", "foo", 1220) node0_address_foo = self.nodes[0].getnewaddress("foo")
self.nodes[0].move("", "bar", 30) fund_foo_txid = self.nodes[0].sendfrom("", node0_address_foo, 1219)
assert_equal(self.nodes[0].getbalance(""), 0) fund_foo_tx = self.nodes[0].gettransaction(fund_foo_txid)
node0_address_bar = self.nodes[0].getnewaddress("bar")
fund_bar_txid = self.nodes[0].sendfrom("", node0_address_bar, 29)
fund_bar_tx = self.nodes[0].gettransaction(fund_bar_txid)
assert_equal(self.nodes[0].getbalance(""),
starting_balance - 1219 - 29 + fund_foo_tx["fee"] + fund_bar_tx["fee"])
# Coins are sent to node1_address # Coins are sent to node1_address
node1_address = self.nodes[1].getnewaddress("from0") node1_address = self.nodes[1].getnewaddress("from0")
# First: use raw transaction API to send 1210 BTC to node1_address, # First: use raw transaction API to send 1240 BTC to node1_address,
# but don't broadcast: # but don't broadcast:
(total_in, inputs) = gather_inputs(self.nodes[0], 1210) doublespend_fee = Decimal('-.02')
change_address = self.nodes[0].getnewaddress("foo") rawtx_input_0 = {}
rawtx_input_0["txid"] = fund_foo_txid
rawtx_input_0["vout"] = find_output(self.nodes[0], fund_foo_txid, 1219)
rawtx_input_1 = {}
rawtx_input_1["txid"] = fund_bar_txid
rawtx_input_1["vout"] = find_output(self.nodes[0], fund_bar_txid, 29)
inputs = [rawtx_input_0, rawtx_input_1]
change_address = self.nodes[0].getnewaddress()
outputs = {} outputs = {}
outputs[change_address] = 40 outputs[node1_address] = 1240
outputs[node1_address] = 1210 outputs[change_address] = 1248 - 1240 + doublespend_fee
rawtx = self.nodes[0].createrawtransaction(inputs, outputs) rawtx = self.nodes[0].createrawtransaction(inputs, outputs)
doublespend = self.nodes[0].signrawtransaction(rawtx) doublespend = self.nodes[0].signrawtransaction(rawtx)
assert_equal(doublespend["complete"], True) assert_equal(doublespend["complete"], True)
# Create two transaction from node[0] to node[1]; the # Create two spends using 1 50 BTC coin each
# second must spend change from the first because the first txid1 = self.nodes[0].sendfrom("foo", node1_address, 40, 0)
# spends all mature inputs:
txid1 = self.nodes[0].sendfrom("foo", node1_address, 1210, 0)
txid2 = self.nodes[0].sendfrom("bar", node1_address, 20, 0) txid2 = self.nodes[0].sendfrom("bar", node1_address, 20, 0)
# Have node0 mine a block: # Have node0 mine a block:
@ -65,16 +77,16 @@ class TxnMallTest(BitcoinTestFramework):
tx2 = self.nodes[0].gettransaction(txid2) tx2 = self.nodes[0].gettransaction(txid2)
# Node0's balance should be starting balance, plus 50BTC for another # Node0's balance should be starting balance, plus 50BTC for another
# matured block, minus 1210, minus 20, and minus transaction fees: # matured block, minus 40, minus 20, and minus transaction fees:
expected = starting_balance expected = starting_balance + fund_foo_tx["fee"] + fund_bar_tx["fee"]
if self.options.mine_block: expected += 50 if self.options.mine_block: expected += 50
expected += tx1["amount"] + tx1["fee"] expected += tx1["amount"] + tx1["fee"]
expected += tx2["amount"] + tx2["fee"] expected += tx2["amount"] + tx2["fee"]
assert_equal(self.nodes[0].getbalance(), expected) assert_equal(self.nodes[0].getbalance(), expected)
# foo and bar accounts should be debited: # foo and bar accounts should be debited:
assert_equal(self.nodes[0].getbalance("foo"), 1220+tx1["amount"]+tx1["fee"]) assert_equal(self.nodes[0].getbalance("foo", 0), 1219+tx1["amount"]+tx1["fee"])
assert_equal(self.nodes[0].getbalance("bar"), 30+tx2["amount"]+tx2["fee"]) assert_equal(self.nodes[0].getbalance("bar", 0), 29+tx2["amount"]+tx2["fee"])
if self.options.mine_block: if self.options.mine_block:
assert_equal(tx1["confirmations"], 1) assert_equal(tx1["confirmations"], 1)
@ -85,8 +97,10 @@ class TxnMallTest(BitcoinTestFramework):
assert_equal(tx1["confirmations"], 0) assert_equal(tx1["confirmations"], 0)
assert_equal(tx2["confirmations"], 0) assert_equal(tx2["confirmations"], 0)
# Now give doublespend to miner: # Now give doublespend and its parents to miner:
mutated_txid = self.nodes[2].sendrawtransaction(doublespend["hex"]) self.nodes[2].sendrawtransaction(fund_foo_tx["hex"])
self.nodes[2].sendrawtransaction(fund_bar_tx["hex"])
self.nodes[2].sendrawtransaction(doublespend["hex"])
# ... mine a block... # ... mine a block...
self.nodes[2].generate(1) self.nodes[2].generate(1)
@ -104,17 +118,28 @@ class TxnMallTest(BitcoinTestFramework):
assert_equal(tx2["confirmations"], -1) assert_equal(tx2["confirmations"], -1)
# Node0's total balance should be starting balance, plus 100BTC for # Node0's total balance should be starting balance, plus 100BTC for
# two more matured blocks, minus 1210 for the double-spend: # two more matured blocks, minus 1240 for the double-spend, plus fees (which are
expected = starting_balance + 100 - 1210 # negative):
expected = starting_balance + 100 - 1240 + fund_foo_tx["fee"] + fund_bar_tx["fee"] + doublespend_fee
assert_equal(self.nodes[0].getbalance(), expected) assert_equal(self.nodes[0].getbalance(), expected)
assert_equal(self.nodes[0].getbalance("*"), expected) assert_equal(self.nodes[0].getbalance("*"), expected)
# foo account should be debited, but bar account should not: # Final "" balance is starting_balance - amount moved to accounts - doublespend + subsidies +
assert_equal(self.nodes[0].getbalance("foo"), 1220-1210) # fees (which are negative)
assert_equal(self.nodes[0].getbalance("bar"), 30) assert_equal(self.nodes[0].getbalance("foo"), 1219)
assert_equal(self.nodes[0].getbalance("bar"), 29)
assert_equal(self.nodes[0].getbalance(""), starting_balance
-1219
- 29
-1240
+ 100
+ fund_foo_tx["fee"]
+ fund_bar_tx["fee"]
+ doublespend_fee)
# Node1's "from" account balance should be just the mutated send: # Node1's "from0" account balance should be just the doublespend:
assert_equal(self.nodes[1].getbalance("from0"), 1210) assert_equal(self.nodes[1].getbalance("from0"), 1240)
if __name__ == '__main__': if __name__ == '__main__':
TxnMallTest().main() TxnMallTest().main()