From eca97676737174ac6ff775c60e3798c69fb67f4a Mon Sep 17 00:00:00 2001 From: practicalswift Date: Sat, 1 Jun 2019 14:25:09 +0200 Subject: [PATCH] Make reasoning about dependencies easier by not including unused dependencies --- src/addrman.cpp | 1 - src/arith_uint256.cpp | 1 - src/bench/base58.cpp | 1 - src/bench/bech32.cpp | 1 - src/bench/bench_bitcoin.cpp | 2 -- src/bench/chacha20.cpp | 1 - src/bench/checkqueue.cpp | 1 - src/bench/crypto_hash.cpp | 2 -- src/bench/duplicate_inputs.cpp | 4 ---- src/bench/examples.cpp | 1 - src/bench/rpc_mempool.cpp | 1 - src/bench/verify_script.cpp | 1 - src/bench/wallet_balance.cpp | 1 - src/bitcoin-wallet.cpp | 1 - src/bitcoind.cpp | 4 ---- src/consensus/merkle.cpp | 1 - src/core_read.cpp | 3 --- src/core_write.cpp | 1 - src/crypto/aes.cpp | 1 - src/crypto/sha256_avx2.cpp | 1 - src/crypto/sha256_sse41.cpp | 1 - src/httprpc.cpp | 1 - src/init.cpp | 1 - src/interfaces/node.cpp | 1 - src/interfaces/wallet.cpp | 8 -------- src/key.cpp | 1 - src/merkleblock.cpp | 1 - src/miner.cpp | 3 --- src/net_processing.cpp | 2 -- src/netbase.cpp | 3 --- src/policy/fees.cpp | 1 - src/policy/policy.cpp | 4 ---- src/primitives/block.cpp | 1 - src/psbt.cpp | 3 --- src/qt/addressbookpage.cpp | 1 - src/qt/addresstablemodel.cpp | 1 - src/qt/bantablemodel.cpp | 2 -- src/qt/bitcoin.cpp | 4 ---- src/qt/bitcoinunits.cpp | 2 -- src/qt/clientmodel.cpp | 6 ------ src/qt/coincontroldialog.cpp | 4 ---- src/qt/peertablemodel.cpp | 1 - src/qt/platformstyle.cpp | 2 -- src/qt/receivecoinsdialog.cpp | 2 -- src/qt/receiverequestdialog.cpp | 1 - src/qt/test/addressbooktests.cpp | 2 -- src/qt/test/apptests.cpp | 4 ---- src/qt/test/rpcnestedtests.cpp | 4 ---- src/qt/test/wallettests.cpp | 2 -- src/qt/transactiondesc.cpp | 2 -- src/qt/transactionrecord.cpp | 3 --- src/qt/transactiontablemodel.cpp | 4 ---- src/qt/transactionview.cpp | 1 - src/qt/utilitydialog.cpp | 5 ----- src/qt/walletmodeltransaction.cpp | 1 - src/rpc/blockchain.cpp | 2 -- src/rpc/misc.cpp | 8 -------- src/rpc/net.cpp | 2 -- src/rpc/protocol.cpp | 1 - src/rpc/rawtransaction.cpp | 6 ------ src/rpc/rawtransaction_util.cpp | 1 - src/rpc/server.cpp | 2 -- src/script/script.cpp | 1 - src/script/sigcache.cpp | 1 - src/script/standard.cpp | 2 -- src/test/coins_tests.cpp | 2 -- src/test/denialofservice_tests.cpp | 1 - src/test/miner_tests.cpp | 1 - src/test/multisig_tests.cpp | 1 - src/test/rpc_tests.cpp | 2 -- src/test/script_p2sh_tests.cpp | 1 - src/test/setup_common.cpp | 1 - src/test/torcontrol_tests.cpp | 1 - src/test/txindex_tests.cpp | 1 - src/test/txvalidationcache_tests.cpp | 2 -- src/test/util.cpp | 3 --- src/timedata.cpp | 1 - src/txdb.cpp | 2 -- src/txmempool.cpp | 2 -- src/ui_interface.cpp | 1 - src/util/system.cpp | 2 -- src/validation.cpp | 1 - src/validationinterface.cpp | 2 -- src/wallet/db.cpp | 4 ---- src/wallet/feebumper.cpp | 4 ---- src/wallet/fees.cpp | 2 -- src/wallet/init.cpp | 5 ----- src/wallet/rpcdump.cpp | 1 - src/wallet/rpcwallet.cpp | 6 ------ src/wallet/test/init_tests.cpp | 5 ----- src/wallet/test/psbt_wallet_tests.cpp | 1 - src/wallet/test/wallet_test_fixture.cpp | 2 -- src/wallet/wallet.cpp | 5 ----- src/wallet/wallettool.cpp | 1 - src/warnings.cpp | 1 - src/zmq/zmqabstractnotifier.cpp | 1 - src/zmq/zmqnotificationinterface.cpp | 1 - test/lint/lint-circular-dependencies.sh | 7 ------- 98 files changed, 214 deletions(-) diff --git a/src/addrman.cpp b/src/addrman.cpp index 8a5f78d1c..32676f8fa 100644 --- a/src/addrman.cpp +++ b/src/addrman.cpp @@ -7,7 +7,6 @@ #include #include -#include int CAddrInfo::GetTriedBucket(const uint256& nKey) const { diff --git a/src/arith_uint256.cpp b/src/arith_uint256.cpp index aa66d1310..be145a0e6 100644 --- a/src/arith_uint256.cpp +++ b/src/arith_uint256.cpp @@ -6,7 +6,6 @@ #include #include -#include #include #include diff --git a/src/bench/base58.cpp b/src/bench/base58.cpp index e7702ec46..0f4b52cf7 100644 --- a/src/bench/base58.cpp +++ b/src/bench/base58.cpp @@ -4,7 +4,6 @@ #include -#include #include #include diff --git a/src/bench/bech32.cpp b/src/bench/bech32.cpp index 3c4b453a2..80f13eeb3 100644 --- a/src/bench/bech32.cpp +++ b/src/bench/bech32.cpp @@ -4,7 +4,6 @@ #include -#include #include #include diff --git a/src/bench/bench_bitcoin.cpp b/src/bench/bench_bitcoin.cpp index 3cf0bf953..a788b2382 100644 --- a/src/bench/bench_bitcoin.cpp +++ b/src/bench/bench_bitcoin.cpp @@ -4,8 +4,6 @@ #include -#include -#include #include #include diff --git a/src/bench/chacha20.cpp b/src/bench/chacha20.cpp index 69d8c96ec..030067aca 100644 --- a/src/bench/chacha20.cpp +++ b/src/bench/chacha20.cpp @@ -5,7 +5,6 @@ #include #include -#include #include /* Number of bytes to process per iteration */ diff --git a/src/bench/checkqueue.cpp b/src/bench/checkqueue.cpp index 6ab542067..000a0259b 100644 --- a/src/bench/checkqueue.cpp +++ b/src/bench/checkqueue.cpp @@ -4,7 +4,6 @@ #include #include -#include #include #include #include diff --git a/src/bench/crypto_hash.cpp b/src/bench/crypto_hash.cpp index dc0b05442..fb2bab9de 100644 --- a/src/bench/crypto_hash.cpp +++ b/src/bench/crypto_hash.cpp @@ -5,11 +5,9 @@ #include #include -#include #include #include #include -#include #include #include #include diff --git a/src/bench/duplicate_inputs.cpp b/src/bench/duplicate_inputs.cpp index 80ff13612..244034128 100644 --- a/src/bench/duplicate_inputs.cpp +++ b/src/bench/duplicate_inputs.cpp @@ -7,13 +7,9 @@ #include #include #include -#include -#include #include -#include #include #include -#include #include #include diff --git a/src/bench/examples.cpp b/src/bench/examples.cpp index e7ddd5a93..359524955 100644 --- a/src/bench/examples.cpp +++ b/src/bench/examples.cpp @@ -3,7 +3,6 @@ // file COPYING or http://www.opensource.org/licenses/mit-license.php. #include -#include #include // Sanity test: this should loop ten times, and diff --git a/src/bench/rpc_mempool.cpp b/src/bench/rpc_mempool.cpp index 67d8a2556..b35a74405 100644 --- a/src/bench/rpc_mempool.cpp +++ b/src/bench/rpc_mempool.cpp @@ -3,7 +3,6 @@ // file COPYING or http://www.opensource.org/licenses/mit-license.php. #include -#include #include #include diff --git a/src/bench/verify_script.cpp b/src/bench/verify_script.cpp index 312b66e38..4891c57b3 100644 --- a/src/bench/verify_script.cpp +++ b/src/bench/verify_script.cpp @@ -8,7 +8,6 @@ #include