From f652f85d0c88629b4284f69b179362254307fb55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Barbosa?= Date: Mon, 14 Jan 2019 14:20:10 +0000 Subject: [PATCH] qa: Ignore shellcheck warning SC2236 With shellcheck 0.6.0 the warning `SC2236 - Use -n instead of ! -z` is raised. This change adds that warning to the ignored list. --- test/lint/lint-shell.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/lint/lint-shell.sh b/test/lint/lint-shell.sh index 9af3c10ed..7ed239576 100755 --- a/test/lint/lint-shell.sh +++ b/test/lint/lint-shell.sh @@ -43,5 +43,6 @@ fi # SC2206: Quote to prevent word splitting, or split robustly with mapfile or read -a. # SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). # SC2230: which is non-standard. Use builtin 'command -v' instead. -shellcheck -e SC1087,SC1117,SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181,SC2206,SC2207,SC2230 \ +# SC2236: Don't force -n instead of ! -z. +shellcheck -e SC1087,SC1117,SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181,SC2206,SC2207,SC2230,SC2236 \ $(git ls-files -- "*.sh" | grep -vE 'src/(secp256k1|univalue)/')