Spencer Lievens
012fa9b99d
Add OSX keystroke to clear RPCConsole
...
Currently only Ctrl-L is mentioned in help, but, (⌘)-L functions on OSX and isn't mentioned.
2017-05-08 21:39:34 +02:00
MarcoFalke
f4b15e2de9
Merge #10310 : [doc] Add hint about getmempoolentry to getrawmempool help.
...
3a0a5bc
[doc] Add hint about getmempoolentry to getrawmempool help. (Karl-Johan Alm)
Tree-SHA512: 8327d7d7ad93296525fbf95b7a824e3525bde84653999f125afd845823eb39e3a03cd39725962ed949aa2b9ad207ecad6d287294fa321ff1a4d7fbd5a4b8560b
2017-05-08 19:28:58 +02:00
Pieter Wuille
3f57c55dba
Merge #10351 : removed unused code in INV message
...
c707ca8
removed unused code in INV message (Greg Griffith)
Tree-SHA512: 8152e9bfb7e1e8a321e7c05ea46826b3ecea6fa5e176727a9c944db170cb134ba1adfa0251bece9683a68d52266291bca58240929337aba6328b915931e60eb9
2017-05-07 22:01:51 -07:00
Wladimir J. van der Laan
750c5a5b84
Merge #10189 : devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private.
...
0f3471f
net: make CNode's id private (Cory Fields)
9ff0a51
scripted-diff: net: Use accessor rather than node's id directly (Cory Fields)
e50c33e
devtools: add script to verify scriptable changes (Cory Fields)
Tree-SHA512: a0ff50f4e1d38a2b63109b4996546c91b3e02e00d92c0bf04f48792948f78b1f6d9227a15d25c823fd4723a0277fc6a32c2c1287c7abbb7e50fd82ffb0f8d994
2017-05-07 10:01:51 +02:00
Greg Griffith
c707ca872d
removed unused code in INV message
...
vToFetch is never used after declaration. When checked if not empty,
evaluation is always false. Best case scenario this is optimized by the
compiler, worst case it wastes cpu cycles. It should be removed either
way.
2017-05-07 00:42:04 -04:00
Karl-Johan Alm
3a0a5bc234
[doc] Add hint about getmempoolentry to getrawmempool help.
2017-05-06 12:51:01 +09:00
Cory Fields
0f3471f3ad
net: make CNode's id private
2017-05-04 01:04:47 -04:00
Cory Fields
9ff0a51164
scripted-diff: net: Use accessor rather than node's id directly
...
-BEGIN VERIFY SCRIPT-
sed -i "s/\(node\|to\|from\)->id/\1->GetId()/" src/net.cpp src/net_processing.cpp
-END VERIFY SCRIPT-
2017-05-04 01:04:47 -04:00
Wladimir J. van der Laan
22d870016e
Merge #10311 : Remove unused args from GetFetchFlags()
...
1ff2bb4
Remove unused args from GetFetchhFlags() (BtcDrak)
Tree-SHA512: 75ed1076651f4e255720425386cbce0677c2e38c789a94cda95f51a8e5ed9cb7213f21a974c65539f256da9b91ccbc2fcc16b164815b46cd499b733becbddc57
2017-05-03 11:47:35 +02:00
Wladimir J. van der Laan
0912620888
Merge #10302 : [Makefile] Alphabetically Reorder addrdb.cpp
...
56f09df
[Makefile] Alphabetically Reorder addrdb.cpp (Spencer Lievens)
Tree-SHA512: cedf64f5b4a6b20c07881f7e9c1c36421ee04a1ba17319946bae0197f9475dba6d5bda05f8f5d72539fbffcaa0adf8f474ecb2089106215c996576ab1235e8e1
2017-05-03 11:40:29 +02:00
Wladimir J. van der Laan
2a183de0ec
Merge #9966 : Control mempool persistence using a command line parameter
...
a750d77
Add tests for mempool persistence (John Newbery)
91c91e1
Control mempool persistence using a command line parameter. (John Newbery)
Tree-SHA512: 157d01cefd1903b8bfc5cbab42a3cc5e9c1094179bf4b64b3d34c0d4d9b976d593755bfea5c41c631cb758e1de17c6c2058c130d487d20560b7c0bafcddfa520
2017-05-03 11:03:48 +02:00
Wladimir J. van der Laan
d3dce0eb67
Merge #10115 : Avoid reading the old hd master key during wallet encryption
...
185c7f0
Avoid reading the old hd master key during wallet encryption (Matt Corallo)
Tree-SHA512: b744e8490c0e948355bb77b2695902bb99f89a68af46aa2be9120bd2ccf3c340eb8a56340fec117f9a935192298028945c9b18120ee6b8b23e7da8ffdb635745
2017-05-03 09:11:45 +02:00
Wladimir J. van der Laan
d4732f3232
Merge #9733 : Add getchaintxstats RPC
...
bd1f138
Add getchaintxstats RPC (Pieter Wuille)
Tree-SHA512: 270785b25e7e2faad4528b5ef591d9dc6266f15236563e3f02dac1f2d9ce3732c4d44903fcccf38549f7921f29d1a93cb0a118b7453ccc5afd79739b51e68f46
2017-05-03 08:14:56 +02:00
Pieter Wuille
bd1f138e73
Add getchaintxstats RPC
2017-05-03 08:08:27 +02:00
Pieter Wuille
431a548faa
Merge #10297 : Simplify DisconnectBlock arguments/return value
...
db994b2
Simplify DisconnectBlock arguments/return value (Pieter Wuille)
Tree-SHA512: 62ce1a85bde2a5baffb9173ed28f2d8008200ecf8b09332122f1516fe68b33b9d7223cc1c2fffe804e38f767874c6353b76bd483e8ad7d48c4a5e80d6b683039
2017-05-02 20:42:15 -07:00
Wladimir J. van der Laan
2580ff81f4
Merge #10314 : Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...)
...
3fe8a83
Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...) (practicalswift)
Tree-SHA512: 68d6a906fef86058ae7190228c7e65b5473b36f76b0cc53181b52c0de96f45d4a8dac0d1656f3793aaf4f79f4ca149ecb8293cc25b3f52fb09ceb114a343e933
2017-05-02 19:00:22 +02:00
Wladimir J. van der Laan
faf2dea5ea
Merge #10234 : [net] listbanned RPC and QT should show correct banned subnets
...
d6732d8
[tests] update disconnect_ban.py test case to work with listbanned (John Newbery)
77c54b2
[net] listbanned RPC and QT should show correct banned subnets (John Newbery)
Tree-SHA512: edd0e43377d456260d2697213c2829f8483630f3a668b6707d52605faefa610d951d10e6f22a95eff483cbd14faa8ac9b69fa7d3c0b5735c5f3df23fd71282e0
2017-05-02 18:41:58 +02:00
practicalswift
3fe8a83969
Remove unused forward declaration for non-existent ScriptPubKeyToJSON(...)
2017-05-02 17:18:03 +02:00
Jonas Schnelli
a3e756b7d6
Merge #10093 : [Qt] Don't add arguments of sensitive command to console window
...
7278537
[Qt] Don't add arguments of sensitive command to console window (Jonas Schnelli)
Tree-SHA512: 3e5aa19a3f157caf383a0fd7dbf9b0d298d31ddaf8e24e3d1a8b913e19f54f3b69e115f98a21f3e3a14e5ccb368b59de061490ed39718299456a04989f8e3366
2017-05-02 14:57:11 +02:00
Wladimir J. van der Laan
f4a6180607
Merge #10175 : Remove excess logic.
...
9a763d4
Remove excess logic. (practicalswift)
Tree-SHA512: cfef280cc9cccf5042c9c49a8cd6fb6700764671cdd0d988149121f56c2d43a9ac38c5fc99c92385a9619d2d846480e02a9d655fa2586b1c284961b4634c229b
2017-05-02 14:50:30 +02:00
Wladimir J. van der Laan
e7b90f78f5
Merge #10180 : [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently)
...
66082e0
[trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently) (practicalswift)
Tree-SHA512: f377c379c9b6702894289c96fa50e64da01fa4e9353f8507ec5f1f58b0f3047fffdc473dffca61774f57793b82cf9e1c9b5f3d9a04fb864ccc1f44fc2a711f32
2017-05-02 14:49:04 +02:00
BtcDrak
1ff2bb4e3e
Remove unused args from GetFetchhFlags()
2017-05-02 07:32:21 +00:00
Pieter Wuille
e4bbd3d230
Merge #10292 : Improved efficiency in COutPoint constructors
...
4fbae77
Improved efficiency in COutPoint constructors (Marcos Mayorga)
Tree-SHA512: 1e402d5021a47724b6159af90955f1a5932c383f48e3e704f1c9a52daa18d2dce5d8e1fcd02fae6977eab04ab83fa22872110b821d4c6593d940d9642abc9bcd
2017-05-01 16:40:43 -07:00
Pieter Wuille
c45da32047
Merge #10305 : Fix potential NPD introduced in b297426c
...
70d3945
Fix potential NPD introduced in b297426c
(Matt Corallo)
Tree-SHA512: 920d03d2081ba2f3447cfa655dcbc3e17858454dab051436f717ada977d4f4bfe999c303018bc8aa33f30e37a97c63d70ba08632f5e7b7a8aa555615dde2191a
2017-05-01 15:01:32 -07:00
CryptAxe
3503716f1e
Trivial: remove extra character from comment
2017-05-01 14:18:30 -07:00
Matt Corallo
70d39454ee
Fix potential NPD introduced in b297426c
...
See https://github.com/bitcoin/bitcoin/pull/10290#discussion_r113954232
for more info.
2017-05-01 11:51:06 -04:00
Wladimir J. van der Laan
e2b99b1313
Merge #10294 : [Wallet] unset change position when there is no change
...
7c58863
[Wallet] unset change position when there is no change on exact match (Gregory Sanders)
Tree-SHA512: ce8b9337e4132e32d80f954258d50938052c833a48e39431649d6adb16e3d18626a0ae5d300827e7fa397927fba72a1f066cb31af9b0a3ef7f1feb6024461626
2017-05-01 15:20:51 +02:00
Gregory Sanders
7c588637d4
[Wallet] unset change position when there is no change on exact match
2017-05-01 08:07:09 -04:00
Wladimir J. van der Laan
9c33ffd387
Merge #8824 : Refactor TxToJSON() and ScriptPubKeyToJSON()
...
0ff9320
refactor TxToJSON() and ScriptPubKeyToJSON() (jonnynewbs)
Tree-SHA512: caf7d590829e221522edd5b1ab8ce67b53a2c6986d3bbe8477eab420b1007bf60f885ed0a25ba9587e468c00768360ddc31db37847e862858573eaed5ed8b0d6
2017-05-01 09:24:01 +02:00
Wladimir J. van der Laan
8d6d43e933
Merge #10290 : Add -stopatheight for benchmarking
...
b297426
Add -stopatheight for benchmarking (Pieter Wuille)
Tree-SHA512: e8a4cca7fc1accd0dcd3a0eda97839fc34c61f25d6302082a8d6ecf9a0291b4abacbde16a0ecba7bdd2a56dd0c8d4d54300ad3b3478386da21dd7697acce381c
2017-05-01 09:17:15 +02:00
Spencer Lievens
56f09df9d8
[Makefile] Alphabetically Reorder addrdb.cpp
...
To keep conformity.
2017-04-30 13:25:39 +02:00
Pieter Wuille
db994b2de9
Simplify DisconnectBlock arguments/return value
...
DisconnectBlock currently has a complicated interface:
Situation Return value
pfClean != nullptr pfClean == nullptr
All good: true true
Failure: false false
Unclean rewind: true false
with *pfClean=false
Change this to return a tristate enum instead. As an added bonus,
remove the ValidationState& argument which was unused.
2017-04-28 16:15:01 -07:00
John Newbery
77c54b270d
[net] listbanned RPC and QT should show correct banned subnets
2017-04-28 11:24:33 -04:00
jonnynewbs
0ff9320bf5
refactor TxToJSON() and ScriptPubKeyToJSON()
2017-04-28 10:01:56 -04:00
Marcos Mayorga
4fbae77929
Improved efficiency in COutPoint constructors
2017-04-28 09:33:34 +01:00
Pieter Wuille
b297426c96
Add -stopatheight for benchmarking
2017-04-27 14:39:27 -07:00
Wladimir J. van der Laan
4c924011f5
Merge #10075 : Remove unused C++ code not covered by unit tests
...
b51aaf1
Remove unused C++ code not covered by unit tests (practicalswift)
Tree-SHA512: 267bbd87df01a296bf23e82a8b6ee968e13e23a6aaecc535d803890a3e3e9f6208c7fc4c1f97afd98ed3e498b12fe1ada7e3cb2977ad12359a813f57336c74e5
2017-04-27 20:25:15 +02:00
Pieter Wuille
a550f6e415
Merge #10283 : Cleanup: reduce to one GetMinimumFee call signature
...
3edbd79
cleanup: reduce to one GetMinimumFee call signature (Alex Morcos)
Tree-SHA512: da7ae6f0eb06db630792243a47c95d4ceff3baf0ce1ebefa73f1eb6cab1c6fdf0a000770cf61700dd7a9e260d7a313083b79e1d667bd5cbef0b1fe8fbec411e7
2017-04-27 09:25:24 -07:00
MarcoFalke
47535d7c3e
Merge #10280 : [test] Unit test amount.h/amount.cpp
...
dcb69fd
[test] Unit test amount.h/amount.cpp (Jimmy Song)
Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5
2017-04-26 23:49:39 +02:00
Alex Morcos
3edbd79a65
cleanup: reduce to one GetMinimumFee call signature
2017-04-26 15:54:23 -04:00
practicalswift
b51aaf1c42
Remove unused C++ code not covered by unit tests
2017-04-26 21:20:02 +02:00
Jimmy Song
dcb69fde5a
[test] Unit test amount.h/amount.cpp
...
Add tests for MoneyRange, binary operators, ToString and a constructor
2017-04-26 07:25:57 -07:00
Wladimir J. van der Laan
cf5782508a
Merge #9614 : [wallet] [refactor] Simplify getbalance implementation
...
02d9f50
[wallet] Remove unneeded legacy getbalance code (Russell Yanofsky)
82b7dc3
[wallet] Add GetLegacyBalance method to simplify getbalance RPC (Russell Yanofsky)
Tree-SHA512: c3b890ff1f5a3df7e886309bad94bdf5cc3c12b72983bb79c72f8655ce16edf581bff0faaade2f18c2cb723f50d516e53f87792f81c3f8143b0c4377c0d80e87
2017-04-26 13:11:32 +02:00
Russell Yanofsky
02d9f50d5f
[wallet] Remove unneeded legacy getbalance code
2017-04-26 06:36:38 -04:00
Russell Yanofsky
82b7dc373a
[wallet] Add GetLegacyBalance method to simplify getbalance RPC
...
This adds a simpler new implementation of getbalance logic along with asserts
to confirm it behaves identically to the old logic. The old logic is removed in
the next commit.
2017-04-26 06:36:38 -04:00
Wladimir J. van der Laan
6fdb319165
Merge #9743 : Fix several potential issues found by sanitizers
...
1d31093
fix tsan: utiltime race on nMockTime (Pieter Wuille)
321bbc2
fix ubsan: bitcoin-tx: not initialize context before IsFullyValid (Pieter Wuille)
Tree-SHA512: 39ea83c6122f06339cd425deb236357694e84ce2e4e9c61c10b90a8909b6e42e8c7b76396175cdc4723ababd2fa4f935d48f8a469baf853c5a06d7b962a5c8dc
2017-04-26 12:29:05 +02:00
Wladimir J. van der Laan
8254a8ae21
Merge #10278 : [test] Add Unit Test for GetListenPort
...
1b14449
[test] Add Unit Test for GetListenPort (Jimmy Song)
Tree-SHA512: aea5f60fb3699680cc5acac9d9c8d8712634db9d629bbfa1815a29e5cf46c22f783886c608664baaa91b3282c52ce8069c358850cf4f90acf731a9e6c1701caa
2017-04-26 09:34:41 +02:00
Wladimir J. van der Laan
9c94fb6c32
Merge #9930 : Trivial: Correct indentation and bracing
...
31a14d4
Correct indentation and remove unnecessary braces (Matthias Grundmann)
Tree-SHA512: c0e827ec4474133c7674254dfd13f59608820cd639debc7759bddae71d73451645fcfe14384f343d08f74d69ac3922bafc12a514f3b790ae2bf9271aa67d5f36
2017-04-26 08:50:18 +02:00
Jimmy Song
1b144495d0
[test] Add Unit Test for GetListenPort
...
Add very basic unit test for GetListenPort in net_tests.cpp
2017-04-25 10:17:04 -07:00
Wladimir J. van der Laan
c29a0d4812
Merge #10265 : [wallet] [moveonly] Check non-null pindex before potentially referencing
...
c36ea69
[wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm)
Tree-SHA512: a14c9f3e1228bca91977bea821c56a377d80889b41d250050c9be67aa93e460319a7cf1d4b63ee40f23b5a34159590f0e3fe15dc88698dc694c0c8098bd2db4d
2017-04-25 16:04:23 +02:00