MarcoFalke
ff58b1c3bd
Merge #9610 : [Trivial] Grammar and typo correction (laudaa)
...
5c66d41
2017-01-22 13:28:43 +01:00
Lauda
5c66d41b7f
[Trivial] Grammar and typo correction
...
Minor corrections in src\test\* .
2017-01-22 13:18:51 +01:00
MarcoFalke
0b96abc35f
Merge #9554 : [test] Avoid potential NULL pointer dereference in addrman_tests.cpp
...
afab9f4
2017-01-22 13:17:41 +01:00
practicalswift
8455e367fe
[test] Avoid reading a potentially uninitialized variable in tx_invalid-test
...
Prior to this commit the err variable was not guaranteed to be set before
the check ...
BOOST_CHECK_MESSAGE(err != SCRIPT_ERR_OK, ScriptErrorString(err));
2017-01-21 10:57:00 +01:00
Alex Morcos
6b331e6cf9
Fix to have miner test aware of new separate block min tx fee
2017-01-19 21:35:39 -05:00
Wladimir J. van der Laan
9c9af5ab2d
Merge #9499 : Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction
...
c5945801ccfe9bfac4c78b55b416863edb47f8c8ca93380c51531652edded80c735540
2017-01-19 09:03:46 +01:00
Wladimir J. van der Laan
6012967c47
Merge #9512 : Fix various things -fsanitize complains about
...
82e8baa99f001e5a0b7e46b03bfbf94f3e0843c560
2017-01-18 20:05:30 +01:00
MarcoFalke
b0b57a1730
Merge #9508 : Remove unused Python imports
...
95bab82
2017-01-18 10:48:52 +01:00
Alex Morcos
ad82cb06ce
Remove unnecessary min fee argument in CTxMemPool constructor
2017-01-17 13:21:35 -05:00
Wladimir J. van der Laan
dd98f04538
Merge #9380 : Separate different uses of minimum fees
...
eb30d1a7b1add3daec955
2017-01-16 19:33:08 +01:00
Alex Morcos
eb30d1a5b2
Introduce -dustrelayfee
2017-01-16 08:40:40 -05:00
practicalswift
8fc698935f
Remove redundant semicolons
2017-01-14 21:45:32 +01:00
practicalswift
afab9f47f6
[test] Avoid potential NULL pointer dereference in addrman_tests.cpp
2017-01-14 20:18:20 +01:00
practicalswift
95bab821b3
Remove unused Python imports
2017-01-13 19:03:20 +01:00
Pieter Wuille
5a0b7e4106
Fix memory leak in net_tests
2017-01-12 11:52:53 -08:00
Pieter Wuille
f94f3e0df8
Avoid integer overflows in scriptnum tests
2017-01-12 11:52:53 -08:00
Suhas Daftuar
4b06e41c30
Add unit test for FindEarliestAtLeast
2017-01-12 14:22:15 +00:00
Wladimir J. van der Laan
d5d4ad87af
Merge #8883 : Add all standard TXO types to bitcoin-tx
...
0c50909b7e144b61a15341814b08
2017-01-12 12:24:35 +01:00
Matt Corallo
93380c5247
Use replaced transactions in compact block reconstruction
2017-01-10 14:48:42 -05:00
John Newbery
0c50909347
testcases: explicitly specify transaction version 1
2017-01-09 16:42:45 -05:00
Matt Corallo
edded808fc
Make ATMP optionally return the CTransactionRefs it replaced
2017-01-09 14:15:18 -05:00
Pieter Wuille
8c87f175d3
Merge #9310 : Assert FRESH validity in CCoinsViewCache::BatchWrite
...
dd44ea3
2017-01-09 08:01:08 -08:00
Pieter Wuille
f646275b90
Merge #9138 : Improve fee estimation
...
44b64b978ae62d5fe0f47dc008c4ebafdcad8258386f06b2684f7ab060ac00d4df4479
2017-01-05 14:22:19 -08:00
MarcoFalke
4cfd57d2e3
Merge #9281 : Refactor: Remove using namespace <xxx> from bench/ & test/ sources
...
73f4119
2017-01-05 11:32:05 +01:00
Wladimir J. van der Laan
cfe41d7a60
Merge #9387 : [Refactor] RAII of libevent stuff using unique ptrs with deleters
...
05a55a6280a5597f7f102e5534d2
2017-01-05 11:11:17 +01:00
Russell Yanofsky
dd44ea39bb
Check FRESH validity in CCoinsViewCache::BatchWrite
2017-01-04 14:56:17 -05:00
Pieter Wuille
7dac1e5e9e
Merge #9107 : Safer modify new coins
...
b50cd7a
2017-01-04 11:56:17 -08:00
Alex Morcos
84f7ab08d2
Remove member variable hadNoDependencies from CTxMemPoolEntry
...
Fee estimation can just check its own mapMemPoolTxs to determine the same information. Note that now fee estimation for block processing must happen before those transactions are removed, but this shoudl be a speedup.
2017-01-04 12:09:33 -05:00
Alex Morcos
b50cd7a67e
Fix dangerous condition in ModifyNewCoins.
...
We were marking coins FRESH before being sure they were not overwriting dirty undo data. This condition was never reached in existing code because undo data was always flushed before UpdateCoins was called with new transactions, but could have been exposed in an otherwise safe refactor.
Clarify in the comments the assumptions made in ModifyNewCoins.
Add ability to undo transactions to UpdateCoins unit test.
Thanks to Russ Yanofsky for suggestion on how to make logic clearer and fixing up the ccoins_modify_new test cases.
2017-01-04 11:20:42 -05:00
Wladimir J. van der Laan
869781c51c
Merge #9283 : A few more CTransactionRef optimizations
...
91335ba6713f0f62607d7c44e4c4
2017-01-04 12:23:10 +01:00
Wladimir J. van der Laan
d9ae1cefa0
Merge #9289 : net: drop boost::thread_group
...
67ee4ec8b3159e5cb0fced3d70560985052799df917325b15
2017-01-04 12:21:53 +01:00
Cory Fields
d3d7056d2a
net: make net processing interruptible
2017-01-03 17:56:20 -05:00
Karl-Johan Alm
73f41190b9
Refactoring: Removed using namespace <xxx> from bench/ and test/ source files.
2017-01-02 20:35:23 +09:00
isle2983
27765b6403
Increment MIT Licence copyright header year on files modified in 2016
...
Edited via:
$ contrib/devtools/copyright_header.py update .
2016-12-31 11:01:21 -07:00
jnewbery
b7e144bb73
Add test cases to test new bitcoin-tx functionality
...
This commit add testcases to test the following functions in bitcoin-tx:
- add a pay to non-standard script output
- add a P2SH output
- add a P2WSH output
- add a P2WSH wrapped in a P2SH output
- add a pay to pub key output
- add a P2WPKH output
- add a P2WPKH wrapped in a P2SH output
- add a bare multisig output
- add a multisig in P2SH output
- add a multisig in a P2WSH output
- add a multisig in a P2WSH wrapped in as P2SH output
2016-12-29 15:40:40 +00:00
Pieter Wuille
2db4cbcc43
Merge #9349 : Make CScript (and prevector) c++11 movable.
...
2ddfcfd
2016-12-27 11:04:14 -08:00
Pieter Wuille
7aa700424c
Merge #9243 : Clean up mapArgs and mapMultiArgs Usage
...
c2f61be4e048144cd373a71fde550cf86a62b5f085c8042a4
2016-12-27 10:17:11 -08:00
MarcoFalke
dbc8a8c86a
Merge #9435 : Removed unused variable in test, fixing warning.
...
35356b4
2016-12-27 18:51:36 +01:00
Matt Corallo
c2f61bebb1
Add a ForceSetArg method for testing
2016-12-27 13:52:07 +01:00
Russell Yanofsky
35356b40ef
Remove unused variable in test, fixing warning.
...
Pointed out by Pavel Janík <Pavel@Janik.cz> in
https://github.com/bitcoin/bitcoin/pull/9308 .
2016-12-27 07:35:39 -05:00
Matt Corallo
4cd373aea8
Un-expose mapArgs from utils.h
2016-12-24 11:29:33 -05:00
Matt Corallo
0cf86a6678
Introduce (and use) an IsArgSet accessor method
2016-12-23 21:30:16 -05:00
Matt Corallo
2b5f085ad1
Fix non-const mapMultiArgs[] access after init.
...
Swap mapMultiArgs for a const-reference to a _mapMultiArgs which is
only accessed in util.cpp
2016-12-23 21:30:15 -05:00
Pieter Wuille
2ddfcfd2d6
Make CScript (and prevector) c++11 movable.
...
Such moves are used when reallocating vectors that contain them,
for example.
2016-12-21 18:28:33 -08:00
Pieter Wuille
6713f0f142
Make FillBlock consume txn_available to avoid shared_ptr copies
2016-12-21 18:18:28 -08:00
Pieter Wuille
62607d796c
Convert COrphanTx to keep a CTransactionRef
2016-12-21 18:18:28 -08:00
Pieter Wuille
c44e4c467c
Make AcceptToMemoryPool take CTransactionRef
2016-12-21 18:18:23 -08:00
Douglas Roark
b3717326c1
Re-enable a blank v1 Tx JSON test
2016-12-21 13:41:47 -08:00
Wladimir J. van der Laan
e8cfe1ee2d
Merge #8589 : Inline CTxInWitness inside CTxIn
...
f6fb7ac
2016-12-21 14:04:06 +01:00
Wladimir J. van der Laan
0698639a38
Merge #9308 : [test] Add CCoinsViewCache Access/Modify/Write tests
...
07df40b
2016-12-21 12:23:31 +01:00
Wladimir J. van der Laan
8dfe9fcb90
Merge #9376 : Remove unused test files and references
...
9cb662423208ac
2016-12-21 09:26:11 +01:00
Karl-Johan Alm
280a5599eb
Added some simple tests for the RAII-style events.
2016-12-21 16:49:21 +09:00
Wladimir J. van der Laan
b416095371
Merge #9354 : Make fuzzer actually test CTxOutCompressor
...
5dd626a
2016-12-19 08:50:27 +01:00
BtcDrak
23208ac81b
Remove unused test files and references
2016-12-19 07:43:12 +00:00
Karl-Johan Alm
815f4148b2
Uses built-in byte swap if available (Apple) and if bswap_XX is undefined.
...
Defers to pre-defined version if found (e.g. protobuf). For protobuf case, the definitions are identical and thus include order should not affect results.
2016-12-17 12:27:00 +09:00
Chris Stewart
988ce2ddef
Adding 'amount' label to tx_valid/tx_invalid.json files
2016-12-15 19:04:56 -06:00
Pieter Wuille
5dd626a6d3
Make fuzzer actually test CTxOutCompressor
2016-12-15 09:18:31 -08:00
Wladimir J. van der Laan
1eef038b1b
Merge #7562 : Bump transaction version default to 2
...
c5c92c4dab207ec5d746a1f0ca1a
2016-12-15 17:03:31 +01:00
Wladimir J. van der Laan
5bc209c73f
Merge #9172 : Resurrect pstratem's "Simple fuzzing framework"
...
8b15434a4153e2
2016-12-15 16:57:06 +01:00
Patrick Strateman
a4153e20ec
Simple fuzzing framework
2016-12-15 13:29:03 +01:00
Pieter Wuille
b83264d9c7
Merge #8895 : Better SigCache Implementation
...
67dac4ec9e69fb
2016-12-14 18:14:02 -08:00
Jeremy Rubin
67dac4e193
Add unit tests for the CuckooCache
...
SQUASHME: Update Tests for other SQUASHMEs
2016-12-14 16:02:22 -05:00
Jeremy Rubin
c9e69fbf39
Add CuckooCache implementation and replace the sigcache map_type with it
...
SQUASHME: Change cuckoocache to only work for powers of two, to avoid mod operator
SQUASHME: Update Documentation and simplify logarithm logic
SQUASHME: OSX Build Errors
SQUASHME: minor Feedback from sipa + bluematt
SQUASHME: DOCONLY: Clarify a few comments.
2016-12-14 16:02:05 -05:00
Wladimir J. van der Laan
b68685a16a
Merge #9273 : Remove unused CDiskBlockPos* argument from ProcessNewBlock
...
a13fa4c
2016-12-14 10:56:28 +01:00
Wladimir J. van der Laan
5233aefa3f
Merge #9305 : Refactor: Removed begin/end_ptr functions.
...
8c1dbc5
2016-12-13 12:21:18 +01:00
Richard Kiss
e49a252bae
Fix spelling.
2016-12-12 16:06:59 -05:00
Pieter Wuille
a1dcf2e108
Merge #9240 : Remove txConflicted
...
a874ab5bf663f8
2016-12-09 16:31:03 -08:00
Karl-Johan Alm
8c1dbc5e9d
Refactor: Removed begin/end_ptr functions.
2016-12-09 13:15:19 +09:00
BtcDrak
c5c92c46fb
Update python tests for default tx version=2
2016-12-08 20:12:00 +00:00
BtcDrak
dab207e4e6
Preserve tx version=1 for certain tests
...
Without this change, the tests would be affected by default
tx version increases.
2016-12-08 20:11:51 +00:00
Alex Morcos
c5d746ace7
tiny test fix for mempool_tests
2016-12-08 20:11:39 +00:00
Pieter Wuille
819ca3f18e
Remove mapOrphanTransactionsByPrev from DoS_tests
...
This is another violation of the one definition rule, as the type
for mapOrphanTransactionsByPrev did not match the one in
net_processing.cpp anymore. As it now depends on a custom Iterator,
it seems too much hassle to correctly expose it to the tests.
Instead, this commit just removes the one test it was referenced in.
2016-12-05 23:04:50 -08:00
Russell Yanofsky
07df40babb
[test] Add CCoinsViewCache Access/Modify/Write tests
...
Add more comprehensive unit tests for CCoinsViewCache. Right now it is hard to
refactor caching code or fix bugs in the caching logic because you have to try
to mentally enumerate all the different states the cache might be in to make
sure a change doesn't cause unintended consequences. The new tests explicitly
enumerate relevant cache states, documenting and verifying the behavior in each
state, so it will be safer and easier to make changes to the caching code in
the future.
2016-12-05 18:30:46 -05:00
Alex Morcos
a874ab5ccf
remove internal tracking of mempool conflicts for reporting to wallet
2016-12-05 13:41:25 -05:00
Alex Morcos
bf663f8e93
remove external usage of mempool conflict tracking
2016-12-05 13:41:25 -05:00
Pavel Janík
9de90bb749
Do not shadow variables (gcc set)
2016-12-05 11:41:46 +01:00
Wladimir J. van der Laan
43e8150ef6
Merge #9269 : Align struct COrphan definition
...
2efc438
2016-12-05 11:09:26 +01:00
Pieter Wuille
2efc43874c
Align struct COrphan definition
2016-12-05 00:35:07 -08:00
Pieter Wuille
f6fb7acda4
Move CTxInWitness inside CTxIn
2016-12-04 23:47:12 -08:00
Wladimir J. van der Laan
d04aebaec7
Merge #9014 : Fix block-connection performance regression
...
dd0df812d6e5612736c44ae4db44fd9d8906fdd43b
2016-12-05 08:07:45 +01:00
Matt Corallo
a13fa4c80f
Remove unused CDiskBlockPos* argument from ProcessNewBlock
2016-12-04 00:23:17 -08:00
Matt Corallo
2d6e5619af
Switch pblock in ProcessNewBlock to a shared_ptr
...
This (finally) fixes a performance regression in
b3b3c2a562
2016-12-04 00:17:30 -08:00
Pieter Wuille
81e3228fcb
Make CTransaction actually immutable
2016-12-02 18:37:43 -08:00
Pieter Wuille
2efcfa5acf
Merge #9260 : Mrs Peacock in The Library with The Candlestick (killed main.{h,cpp})
...
76faa3ce73677287c35f5
2016-12-02 18:25:40 -08:00
Matt Corallo
76faa3cdfe
Rename the remaining main.{h,cpp} to validation.{h,cpp}
2016-12-02 09:42:51 -08:00
Matt Corallo
e736772c56
Move network-msg-processing code out of main to its own file
2016-12-02 09:42:51 -08:00
MarcoFalke
5412c08c3c
Merge #9223 : unification of Bloom filter representation
...
b7aa290
2016-12-02 15:58:57 +01:00
Alex Morcos
d824ad030e
Disable fee estimates for a confirm target of 1 block
2016-11-29 12:18:44 -05:00
fsb4000
15fa95d7e5
Fix some typos
2016-11-28 16:16:37 +07:00
S. Matthew English
b7aa2902fd
unification of Bloom filter representation
...
Output instances of "BloomFilter" changed to "Bloom filter", in accordance with Wikipedia standard notation:
https://en.wikipedia.org/wiki/Bloom_filter
also to sync with the majority of cases in the self-same file
2016-11-26 14:57:19 +01:00
Pieter Wuille
76fec09d87
Merge #9128 : net: Decouple CConnman and message serialization
...
c7be56d2ec935db7695c2fedea8ad74e352
2016-11-25 11:18:23 -08:00
Cory Fields
2ec935dcaa
net: add CVectorWriter and CNetMsgMaker
...
CVectorWriter is useful for overwriting or appending an existing byte vector.
CNetMsgMaker is a shortcut for creating messages on-the-fly which are suitable
for pushing to CConnman.
2016-11-25 12:09:58 -05:00
MarcoFalke
97ec6e5c90
Merge #9100 : tx_valid: re-order inputs to how they are encoded
...
5262a15
2016-11-25 10:38:19 +01:00
Pieter Wuille
ad04d1cb35
Always add default_witness_commitment with GBT client support
2016-11-21 15:01:04 -08:00
Wladimir J. van der Laan
210891143b
Merge #8837 : allow bitcoin-tx to parse partial transactions
...
7451cf5
2016-11-21 15:33:19 +01:00
Pieter Wuille
b4e4ba475a
Introduce convenience type CTransactionRef
2016-11-19 17:53:23 -08:00
Pieter Wuille
1662b437b3
Make CBlock::vtx a vector of shared_ptr<CTransaction>
2016-11-19 17:51:09 -08:00
Pieter Wuille
9346f84299
Merge #9075 : Decouple peer-processing-logic from block-connection-logic ( #3 )
...
ae223577c98ce5e2e069d
2016-11-17 13:23:50 -08:00
Jonas Schnelli
ab914a6530
Merge #8996 : Network activity toggle
...
19f46f154cf997b2b33d932efa79e38993b7c9a98a
2016-11-11 11:16:40 +01:00
Matt Corallo
ae22357607
Replace CValidationState param in ProcessNewBlock with BlockChecked
2016-11-09 11:21:55 -08:00
