Russell Yanofsky
05e57ccd74
[qa] Fix sync_blocks timeout argument
...
Motivation for this change is mainly to make sync_blocks behavior easier to
understand. Behavior is unchanged in the normal case when there are only 2
nodes in the rpc_connections set. When there are more than 2 nodes, the
previous "timeout -= wait" statement wouldn't take into account time spent
waiting for all nodes and as a result could lead to blocking for longer than
the requested timeout.
2016-11-14 12:02:31 -05:00
Russell Yanofsky
fd6bb700b7
[qa] Improve sync_blocks error messages.
2016-11-14 12:01:51 -05:00
Jonas Schnelli
924745dd6f
Merge #9145 : [qt] Make network disabled icon 50% opaque
...
fa42e4a
[qt] Make network disabled icon 50% opaque (MarcoFalke)
2016-11-14 08:46:13 +01:00
Brian Deery
07ede5d711
update comments for tx weight
2016-11-14 00:38:07 -06:00
MarcoFalke
fa80ef8173
[qa] proxy_test: Calculate hardcoded port numbers instead
2016-11-13 22:32:23 +01:00
MarcoFalke
fa42e4a082
[qt] Make network disabled icon 50% opaque
2016-11-13 22:06:35 +01:00
Jonas Schnelli
4512550fa0
Remove unnecessary calls to CheckFinalTx
2016-11-12 13:50:39 +01:00
Pavel Janík
1260c1103b
Mention the new network toggle functionality in the tooltip.
2016-11-12 13:28:21 +01:00
Jonas Schnelli
2e44893081
Move -salvagewallet, -zap(wtx) to where they belong
2016-11-12 10:25:34 +01:00
Luke Dashjr
b74ff5cf0c
Bugfix: Correctly replace generated headers and fail cleanly
...
Also removes generation of headers for *.raw files in test_bitcoin (none exist anymore)
2016-11-12 07:16:28 +00:00
Russell Yanofsky
1126c853d9
[qa] Change sync_blocks to pick smarter maxheight
...
Instead of syncing to max height returned by the waitforblockheight RPC, sync
to the max height returned by the getblockcount RPC.
This change was suggested by Suhas Daftuar <sdaftuar@chaincode.com>.
2016-11-11 15:46:14 -05:00
Alex Morcos
79f755db41
Unset fImporting for loading mempool
2016-11-11 09:33:16 -05:00
Jonas Schnelli
f7345050e9
Make strWalletFile const
2016-11-11 14:32:38 +01:00
Jonas Schnelli
079142b757
fNetworkActive is not protected by a lock, use an atomic
2016-11-11 14:09:52 +01:00
Wladimir J. van der Laan
87ab49e4fe
Merge #9124 : Use better name for local variable to prevent -Wshadow compiler warning
...
bf49f10
Use better name for local variable to prevent -Wshadow compiler warning (Pavel Janík)
2016-11-11 11:46:49 +01:00
Wladimir J. van der Laan
bfc7aad008
Merge #9115 : Mention reporting security issues responsibly
...
7d1de30
Mention reporting security issues responsibly (Pavel Janík)
2016-11-11 11:30:23 +01:00
Jonas Schnelli
ab914a6530
Merge #8996 : Network activity toggle
...
19f46f1
Qt: New network_disabled icon (Luke Dashjr)
54cf997
RPC/Net: Use boolean consistently for networkactive, and remove from getinfo (Luke Dashjr)
b2b33d9
Overhaul network activity toggle (Jonas Schnelli)
32efa79
Qt: Add GUI feedback and control of network activity state. (Jon Lund Steffensen)
e38993b
RPC: Add "togglenetwork" method to toggle network activity temporarily (Jon Lund Steffensen)
7c9a98a
Allow network activity to be temporarily suspended. (Jon Lund Steffensen)
2016-11-11 11:16:40 +01:00
Wladimir J. van der Laan
7977a1157a
Merge #9058 : Fixes for p2p-compactblocks.py test timeouts on travis ( #8842 )
...
dac53b5
Modify getblocktxn handler not to drop requests for old blocks (Russell Yanofsky)
55bfddc
[qa] Fix stale data bug in test_compactblocks_not_at_tip (Russell Yanofsky)
47e9659
[qa] Fix bug in compactblocks v2 merge (Russell Yanofsky)
2016-11-11 11:02:44 +01:00
Wladimir J. van der Laan
46027e8668
Merge #9112 : Avoid ugly exception in log on unknown inv type
...
e9f25dd
Avoid ugly exception in log on unknown inv type (Wladimir J. van der Laan)
2016-11-11 10:58:58 +01:00
Wladimir J. van der Laan
21e6c6b569
Merge #9114 : [depends] Set OSX_MIN_VERSION to 10.8
...
617c96d
[depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
2016-11-11 10:07:10 +01:00
Pavel Janík
bf49f107ef
Use better name for local variable to prevent -Wshadow compiler warning
2016-11-10 21:38:07 +01:00
Wladimir J. van der Laan
71bc39eb74
Merge #9049 : Remove duplicatable duplicate-input check from CheckTransaction
...
e2b3fb3
Optimize vInOutPoints insertion a bit (Matt Corallo)
eecffe5
Remove redundant duplicate-input check from CheckTransaction (Matt Corallo)
b2e178a
Add deserialize + CheckBlock benchmarks, and a full block hex (Matt Corallo)
2016-11-10 16:02:55 +01:00
Pavel Janík
7d1de3032d
Mention reporting security issues responsibly
2016-11-10 14:41:40 +01:00
MarcoFalke
e5364991da
Merge #9097 : [qa] Rework sync_* and preciousblock.py
...
fa97ccb
[qa] util: Rework sync_*() (MarcoFalke)
fac1141
[qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
2016-11-10 11:23:40 +01:00
MarcoFalke
4a2b170c07
Merge #9122 : fix getnettotals RPC description about timemillis.
...
a79f864
fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
2016-11-10 11:05:59 +01:00
Wladimir J. van der Laan
aab102cbae
Merge #9121 : Initialize variable to prevent compiler warning
...
bdcba6d
Initialize variable to prevent compiler warning (Pavel Janík)
2016-11-10 10:35:07 +01:00
Wladimir J. van der Laan
537e0cb252
Merge #9120 : bug: Missed one "return false" in recent refactoring in #9067
...
45d372f
Missed one "return false" in recent refactoring in #9067 (UdjinM6)
2016-11-10 10:30:54 +01:00
Masahiko Hyuga
a79f864945
fix getnettotals RPC description about timemillis.
2016-11-10 18:18:52 +09:00
Pavel Janík
bdcba6d933
Initialize variable to prevent compiler warning
2016-11-10 08:11:51 +01:00
UdjinM6
45d372f889
Missed one "return false" in recent refactoring in #9067
2016-11-10 00:53:55 +03:00
Wladimir J. van der Laan
faec09bc7f
Merge #8894 : [Testing] Include fRelay in mininode version messages
...
e5d682f
Fix mininode version message format (jnewbery)
2016-11-09 22:06:57 +01:00
Wladimir J. van der Laan
fb156100f9
Merge #9111 : Remove unused variable UNLIKELY_PCT from fees.h
...
d8edf03
Remove unused var UNLIKELY_PCT from fees.h (fanquake)
2016-11-09 21:54:56 +01:00
Wladimir J. van der Laan
f445d88612
Revert "Check and enable -Wshadow by default."
...
This reverts commit fd5654cab1
.
This is still causing too many warnings for some compiler combinations,
forget it for now.
2016-11-09 21:28:11 +01:00
Matt Corallo
e2b3fb349e
Optimize vInOutPoints insertion a bit
2016-11-09 11:28:41 -08:00
Matt Corallo
eecffe50ef
Remove redundant duplicate-input check from CheckTransaction
2016-11-09 11:28:00 -08:00
Matt Corallo
b2e178a2d2
Add deserialize + CheckBlock benchmarks, and a full block hex
2016-11-09 11:27:59 -08:00
Matt Corallo
ae22357607
Replace CValidationState param in ProcessNewBlock with BlockChecked
2016-11-09 11:21:55 -08:00
Matt Corallo
7c98ce584e
Remove pfrom parameter from ProcessNewBlock
...
This further decouples ProcessNewBlock from networking/peer logic.
2016-11-09 11:21:45 -08:00
Cory Fields
46625538d6
net: don't send feefilter messages before the version handshake is complete
2016-11-09 12:45:13 -05:00
Wladimir J. van der Laan
e0477f6d20
Merge #8794 : Enable -Wshadow by default
...
359bac7
Add notes about variable names and shadowing (Pavel Janík)
fd5654c
Check and enable -Wshadow by default. (Pavel Janík)
2016-11-09 14:12:19 +01:00
Pavel Janík
359bac7cff
Add notes about variable names and shadowing
2016-11-09 14:11:24 +01:00
Wladimir J. van der Laan
e81df49644
Merge #9039 : Various serialization simplifcations and optimizations
...
d59a518
Use fixed preallocation instead of costly GetSerializeSize (Pieter Wuille)
25a211a
Add optimized CSizeComputer serializers (Pieter Wuille)
a2929a2
Make CSerAction's ForRead() constexpr (Pieter Wuille)
a603925
Avoid -Wshadow errors (Pieter Wuille)
5284721
Get rid of nType and nVersion (Pieter Wuille)
657e05a
Make GetSerializeSize a wrapper on top of CSizeComputer (Pieter Wuille)
fad9b66
Make nType and nVersion private and sometimes const (Pieter Wuille)
c2c5d42
Make streams' read and write return void (Pieter Wuille)
50e8a9c
Remove unused ReadVersion and WriteVersion (Pieter Wuille)
2016-11-09 13:52:04 +01:00
fanquake
617c96d5b3
[depends] Set OSX_MIN_VERSION to 10.8
2016-11-09 18:55:04 +08:00
Wladimir J. van der Laan
e9f25ddd00
Avoid ugly exception in log on unknown inv type
...
It is unexpected behavior for `ToString` to raise an exception. It
is expected to do a best-effort attempt at formatting but never fail.
Catch the exception and simply print unknown inv types as hexadecimal.
Fixes #9110 .
2016-11-09 11:16:39 +01:00
Wladimir J. van der Laan
e9847303e7
Merge #8874 : Multiple Selection for peer and ban tables
...
1077577
Fix auto-deselection of peers (Andrew Chow)
addfdeb
Multiple Selection for peer and ban tables (Andrew Chow)
2016-11-09 11:05:15 +01:00
fanquake
d8edf03db7
Remove unused var UNLIKELY_PCT from fees.h
2016-11-09 17:51:27 +08:00
jnewbery
e5d682faa3
Fix mininode version message format
2016-11-09 02:34:30 +00:00
Matt Corallo
e2e069dabc
Revert "RPC: Give more details when "generate" fails"
...
This only returned information in the case of CheckBlock failure,
but breaks future changes.
2016-11-08 17:39:44 -08:00
Andrew Chow
1077577546
Fix auto-deselection of peers
2016-11-08 15:11:25 -05:00
MarcoFalke
924de0bd75
Merge #9087 : RPC: why not give more details when "generate" fails?
...
1adf82a
RPC: Give more details when "generate" fails (Jorge Timón)
2016-11-08 15:55:53 +01:00