Philip Kaufmann
20a11ffabf
minor variable init changes in init.cpp
...
- explicit init of pcoinsdbview and pwalletMain (even if not needed, as
globals are init to NULL, it seems cleaner)
- remove check if (pwalletMain) in Shutdown() as delete is valid even if
pwalletMain is NULL
2014-09-25 13:49:49 +02:00
Wladimir J. van der Laan
d14d7deff0
SanitizeString: allow '(' and ')'
...
'(' and ')' are valid in user agent strings, so should be reported
as such in RPC `getpeerinfo`.
Fixes #4537 .
2014-09-25 12:45:46 +02:00
Wladimir J. van der Laan
b50e5fe099
Merge pull request #4968
...
219372f
2014-09-25 11:48:33 +02:00
ENikS
219372f1dd
script: Fix reference into empty vector run time exception
...
Edit by laanwj: `begin_ptr(sourcedata) + sourcedata.size()` -> `end_ptr(sourcedata)`
2014-09-25 11:46:52 +02:00
Wladimir J. van der Laan
375cb4c253
Merge pull request #4959
...
bb26e2c
2014-09-25 11:31:53 +02:00
Wladimir J. van der Laan
8152f4efd8
Merge pull request #4967
...
459a2d2
2014-09-25 11:31:10 +02:00
Wladimir J. van der Laan
82e370b4b0
Merge pull request #4782
...
2e5361b
2014-09-25 11:21:43 +02:00
Janusz Lenar
346d5443f1
Fixed the broken brew shell command
2014-09-25 11:04:27 +02:00
Wladimir J. van der Laan
35e5b5329a
Merge pull request #4946
...
c65cc8c
2014-09-25 10:54:54 +02:00
Wladimir J. van der Laan
29a9d4483e
Merge pull request #4966
...
c8063b5
2014-09-25 10:21:01 +02:00
Wladimir J. van der Laan
58d4b23284
Merge pull request #4914
...
ff36cbe
2014-09-25 10:17:29 +02:00
Jeff Garzik
ff36cbe8d0
RPC getnetworkinfo: export local node's client sub-version string
2014-09-25 10:09:21 +02:00
Wladimir J. van der Laan
c4998661e4
Merge pull request #4958
...
e6beedc
2014-09-25 09:47:01 +02:00
Philip Kaufmann
e6beedc496
[Qt] add more NULL pointer checks in bitcoingui
...
- add missing checks for clientModel and optionsModel
- small cleanups for an #ifdef on Mac
- remove an unneeded else
2014-09-25 09:16:45 +02:00
Pieter Wuille
cf42c36e99
Apply clang-format on crypto/* and compat/*
2014-09-25 08:23:32 +02:00
Pieter Wuille
ea69592a2f
Merge pull request #4974
...
b498a94
2014-09-24 21:15:58 +02:00
Eric Shaw
b498a9493c
Fixed typo in README.md file. "-regest" "-regtest"
...
There was a typo in the README.md file. It previously read "-regest" instead of the proper "-regtest" and it has been updated to the proper reading.
2014-09-24 15:13:59 -04:00
Pieter Wuille
584a358997
Do merkle root and txid duplicates check simultaneously
...
Move the txid duplicates check into BuildMerkleTree, where it can be done
much more efficiently (without needing to build a full txid set to detect
duplicates).
The previous version (using the std::set<uint256> to detect duplicates) was
also slightly too weak. A block mined with actual duplicate transactions
(which is invalid, due to the inputs of the duplicated transactions being
seen as double spends) would trigger the duplicates logic, resulting in the
block not being stored on disk, and rerequested. This change fixes that by
only triggering in the case of duplicated transactions that can actually
result in an identical merkle root.
2014-09-24 19:17:02 +02:00
Pieter Wuille
7c70438dc6
Get rid of the dummy CCoinsViewCache constructor arg
2014-09-24 03:19:04 +02:00
ENikS
cda45b5131
Reinitializing list's begin iterator after few elements were erased from the head
2014-09-23 18:33:16 -04:00
Pieter Wuille
ed27e53c9b
Add coins_tests with a large randomized CCoinViewCache test.
2014-09-23 22:29:45 +02:00
Pieter Wuille
058b08c147
Do not keep fully spent but unwritten CCoins entries cached.
...
Instead of storing CCoins entries directly in CCoinsMap, store a CCoinsCacheEntry
which additionally keeps track of whether a particular entry is:
* dirty: potentially different from its parent view.
* fresh: the parent view is known to not have a non-pruned version.
This allows us to skip non-dirty cache entries when pushing batches of changes up,
and to remove CCoins entries about transactions that are fully spent before the
parent cache learns about them.
2014-09-23 22:29:43 +02:00
Pieter Wuille
c9d1a81ce7
Get rid of CCoinsView's SetCoins and SetBestBlock.
...
All direct modifications are now done through ModifyCoins, and BatchWrite is
used for pushing batches of queued modifications up, so we don't need the
low-level SetCoins and SetBestBlock anymore in the top-level CCoinsView class.
2014-09-23 22:29:21 +02:00
Pieter Wuille
f28aec014e
Use ModifyCoins instead of mutable GetCoins.
...
Replace the mutable non-copying GetCoins method with a ModifyCoins, which
returns an encapsulated iterator, so we can keep track of concurrent
modifications (as iterators can be invalidated by those) and run cleanup
code after a modification is finished.
This also removes the overloading of the 'GetCoins' name.
2014-09-23 22:29:12 +02:00
Pieter Wuille
7a04f3d708
Merge pull request #4955
...
87314c1
2014-09-23 20:20:58 +02:00
ENikS
459a2d25e0
Avoiding referencing elements of an empty vector
2014-09-23 11:54:12 -04:00
ENikS
c8063b5712
Fixing out of bounds asses error
2014-09-23 11:17:43 -04:00
Wladimir J. van der Laan
35ee2dac67
Merge pull request #4949
...
c8589bf76ec867
2014-09-23 13:14:19 +02:00
Wladimir J. van der Laan
bfe527ea86
Merge pull request #4962
...
6f3ae9b
2014-09-23 10:53:05 +02:00
ENikS
6f3ae9b5df
Fixing out of bounds error in GetKey()
2014-09-23 10:45:04 +02:00
Alexander Jeng
2027450d42
Grammar fixes in README
...
Github-Pull: #4956
2014-09-23 10:40:57 +02:00
Philip Kaufmann
bb26e2c896
[Qt] minor changes in splashscreen.cpp
...
- guard an unused variable with Q_UNUSED() macro
- remove a commented out line of code
2014-09-23 09:56:46 +02:00
Pieter Wuille
c8589bf99e
Add actual signature tests
2014-09-22 19:26:17 +02:00
Pieter Wuille
76ec867796
Use actually valid transactions for script tests
2014-09-22 19:26:17 +02:00
Wladimir J. van der Laan
cb9871194a
Merge pull request #4765
...
e2a98d2e543811
2014-09-22 18:31:00 +02:00
Wladimir J. van der Laan
27fc5277f7
build: change cdrkit location in build-process.md
...
The cdrkit.org domain expired.
Thanks to gdm85 on IRC for reporting this.
2014-09-22 16:40:49 +02:00
Wladimir J. van der Laan
3cdae61aa2
Merge pull request #4787
...
4b0deb3
2014-09-22 14:18:54 +02:00
Wladimir J. van der Laan
565da68ed0
Merge pull request #4852
...
5e83bc4
2014-09-22 12:20:36 +02:00
Wladimir J. van der Laan
321fd7dbee
Merge pull request #4947
...
6134b43
2014-09-22 10:34:12 +02:00
Wladimir J. van der Laan
aa340a8f07
Merge pull request #4951
...
d6712db
2014-09-22 10:32:21 +02:00
Wladimir J. van der Laan
cfc5cfb0f0
qt: Make splash and shutdown window ignore close events
...
It's strange to be able to close these windows while there is work
in progress.
Also set Qt::WA_DeleteOnClose on both windows to make sure that they
are deleted eventually, no matter what happens.
2014-09-22 10:13:52 +02:00
Philip Kaufmann
2e5361b9c2
remove code below asserts in limitedmap.h (fixes a ToDo)
2014-09-22 09:35:40 +02:00
Wladimir J. van der Laan
6b09bc45b1
Merge pull request #4941
...
a49f11d
2014-09-22 09:33:34 +02:00
Wladimir J. van der Laan
5547f08ec7
Merge pull request #4952
...
01c2807
2014-09-22 09:03:59 +02:00
ENikS
87314c1c5e
Fixing improper input syntax and failing bounds check
2014-09-21 21:18:48 -04:00
Wladimir J. van der Laan
ae9966ed85
Merge pull request #4950
...
33a2771c74332c
2014-09-21 21:25:25 +02:00
jtimon
3fdb9e8c15
Remove CBaseChainParams::NetworkID()
2014-09-21 21:25:15 +02:00
jtimon
f297479a19
Reserve only one network specific cached path per session
2014-09-21 21:21:09 +02:00
Pieter Wuille
934b153a2c
Merge pull request #4933
...
20e01b1
2014-09-21 01:10:14 +02:00
Peter Todd
01c28073ba
Add warning about the merkle-tree algorithm duplicate txid flaw
...
Lots of people read the Bitcoin Core codebase to learn more about
crypto; better to warn about flaws explicitly so they don't blindly copy
the code for other uses and create broken systems.
2014-09-20 13:23:44 -04:00
