83112db129
ffea41f530
Enable all tests in feature_config_args.py (Hennadii Stepanov)66f5c17f8a
Use CheckDataDirOption() for code uniformity (Hennadii Stepanov)7e33a18a34
Fix datadir handling in bitcoin-cli (Hennadii Stepanov)b28dada374
Fix datadir handling in bitcoin-qt (Hennadii Stepanov)50824093bb
Fix datadir handling in bitcoind (Hennadii Stepanov)740d41ce9f
Add CheckDataDirOption() function (Hennadii Stepanov)c1f325126c
Return absolute path early in AbsPathForConfigVal (Hennadii Stepanov) Pull request description: Fix #15240, see: https://github.com/bitcoin/bitcoin/issues/15240#issuecomment-487353760 Fix #15745 Fix broken `feature_config_args.py` tests (disabled by MarcoFalke@fabe28a0cdcfa13e0e595a0905e3642a960d3077). All test are enabled now. This PR is alternative to #13621. User's `$HOME` directory is not touched unnecessarily now. ~To make reviewing easier only `bitcoind` code is modified (neither `bitcoin-cli` nor `bitcoin-qt`).~ Refs: - https://github.com/bitcoin/bitcoin/issues/15745#issuecomment-479852569 by **laanwj** - #16220 Top commit has no ACKs. Tree-SHA512: 4a4cda10e0b67c8f374da0c9567003d2b566d948e7f8550fe246868b5794c15010e88ea206009480b9cd2f737f310a15e984f920730448f99a895893bed351df
118 lines
4.5 KiB
C++
118 lines
4.5 KiB
C++
// Copyright (c) 2016-2018 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#if defined(HAVE_CONFIG_H)
|
|
#include <config/bitcoin-config.h>
|
|
#endif
|
|
|
|
#include <chainparams.h>
|
|
#include <chainparamsbase.h>
|
|
#include <logging.h>
|
|
#include <util/strencodings.h>
|
|
#include <util/system.h>
|
|
#include <util/translation.h>
|
|
#include <wallet/wallettool.h>
|
|
|
|
#include <functional>
|
|
#include <stdio.h>
|
|
|
|
const std::function<std::string(const char*)> G_TRANSLATION_FUN = nullptr;
|
|
|
|
static void SetupWalletToolArgs()
|
|
{
|
|
SetupHelpOptions(gArgs);
|
|
SetupChainParamsBaseOptions();
|
|
|
|
gArgs.AddArg("-datadir=<dir>", "Specify data directory", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
|
|
gArgs.AddArg("-wallet=<wallet-name>", "Specify wallet name", ArgsManager::ALLOW_ANY | ArgsManager::NETWORK_ONLY, OptionsCategory::OPTIONS);
|
|
gArgs.AddArg("-debug=<category>", "Output debugging information (default: 0).", ArgsManager::ALLOW_ANY, OptionsCategory::DEBUG_TEST);
|
|
gArgs.AddArg("-printtoconsole", "Send trace/debug info to console (default: 1 when no -debug is true, 0 otherwise.", ArgsManager::ALLOW_ANY, OptionsCategory::DEBUG_TEST);
|
|
|
|
gArgs.AddArg("info", "Get wallet info", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
|
|
gArgs.AddArg("create", "Create new wallet file", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
|
|
}
|
|
|
|
static bool WalletAppInit(int argc, char* argv[])
|
|
{
|
|
SetupWalletToolArgs();
|
|
std::string error_message;
|
|
if (!gArgs.ParseParameters(argc, argv, error_message)) {
|
|
tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error_message.c_str());
|
|
return false;
|
|
}
|
|
if (argc < 2 || HelpRequested(gArgs)) {
|
|
std::string usage = strprintf("%s bitcoin-wallet version", PACKAGE_NAME) + " " + FormatFullVersion() + "\n\n" +
|
|
"wallet-tool is an offline tool for creating and interacting with Bitcoin Core wallet files.\n" +
|
|
"By default wallet-tool will act on wallets in the default mainnet wallet directory in the datadir.\n" +
|
|
"To change the target wallet, use the -datadir, -wallet and -testnet/-regtest arguments.\n\n" +
|
|
"Usage:\n" +
|
|
" bitcoin-wallet [options] <command>\n\n" +
|
|
gArgs.GetHelpMessage();
|
|
|
|
tfm::format(std::cout, "%s", usage.c_str());
|
|
return false;
|
|
}
|
|
|
|
// check for printtoconsole, allow -debug
|
|
LogInstance().m_print_to_console = gArgs.GetBoolArg("-printtoconsole", gArgs.GetBoolArg("-debug", false));
|
|
|
|
if (!CheckDataDirOption()) {
|
|
tfm::format(std::cerr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());
|
|
return false;
|
|
}
|
|
// Check for -testnet or -regtest parameter (Params() calls are only valid after this clause)
|
|
SelectParams(gArgs.GetChainName());
|
|
|
|
return true;
|
|
}
|
|
|
|
int main(int argc, char* argv[])
|
|
{
|
|
#ifdef WIN32
|
|
util::WinCmdLineArgs winArgs;
|
|
std::tie(argc, argv) = winArgs.get();
|
|
#endif
|
|
SetupEnvironment();
|
|
RandomInit();
|
|
try {
|
|
if (!WalletAppInit(argc, argv)) return EXIT_FAILURE;
|
|
} catch (const std::exception& e) {
|
|
PrintExceptionContinue(&e, "WalletAppInit()");
|
|
return EXIT_FAILURE;
|
|
} catch (...) {
|
|
PrintExceptionContinue(nullptr, "WalletAppInit()");
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
std::string method {};
|
|
for(int i = 1; i < argc; ++i) {
|
|
if (!IsSwitchChar(argv[i][0])) {
|
|
if (!method.empty()) {
|
|
tfm::format(std::cerr, "Error: two methods provided (%s and %s). Only one method should be provided.\n", method.c_str(), argv[i]);
|
|
return EXIT_FAILURE;
|
|
}
|
|
method = argv[i];
|
|
}
|
|
}
|
|
|
|
if (method.empty()) {
|
|
tfm::format(std::cerr, "No method provided. Run `bitcoin-wallet -help` for valid methods.\n");
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
// A name must be provided when creating a file
|
|
if (method == "create" && !gArgs.IsArgSet("-wallet")) {
|
|
tfm::format(std::cerr, "Wallet name must be provided when creating a new wallet.\n");
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
std::string name = gArgs.GetArg("-wallet", "");
|
|
|
|
ECCVerifyHandle globalVerifyHandle;
|
|
ECC_Start();
|
|
if (!WalletTool::ExecuteWalletToolFunc(method, name))
|
|
return EXIT_FAILURE;
|
|
ECC_Stop();
|
|
return EXIT_SUCCESS;
|
|
}
|