lbrycrd/src/primitives
MarcoFalke c65c77c721
Merge #14039: Disallow extended encoding for non-witness transactions
bb530efa18 Disallow extended encoding for non-witness transactions (Pieter Wuille)

Pull request description:

  BIP144 specifies that transactions without witness should use the legacy encoding, which is currently not enforced.

  This rule was present in the original SegWit implementation (https://github.com/bitcoin/bitcoin/pull/8149), but was subsequently dropped (https://github.com/bitcoin/bitcoin/pull/8589).

  As all hashes, txids, and weights are always computed over a reserialized version of a transaction, it is mostly harmless to permit extended encoding for non-segwit transactions, but I'd rather strictly follow the BIP.

ACKs for commit bb530e:
  instagibbs:
    utACK bb530efa18
  stevenroose:
    utACK bb530efa18

Tree-SHA512: 1aeccd6a555f43784fefb076ce2e8ad2f5ba7be49840544a50050d0390f82373f87201bf56cf8bb30841b4f9cd893b382261a080da875d4e11ab7051f8640dbe
2019-04-25 14:15:43 -04:00
..
block.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
block.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
transaction.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
transaction.h Merge #14039: Disallow extended encoding for non-witness transactions 2019-04-25 14:15:43 -04:00