From 6d2f69a36f467437e40075b6a27f288358af77eb Mon Sep 17 00:00:00 2001 From: Mark Beamer Jr Date: Sun, 2 Jun 2019 13:32:30 -0400 Subject: [PATCH] remove address validation --- claim/claim.go | 10 ++++++---- claim/decode_test.go | 8 ++++++++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/claim/claim.go b/claim/claim.go index f663cc4..8ef378a 100644 --- a/claim/claim.go +++ b/claim/claim.go @@ -147,10 +147,12 @@ func (c *ClaimHelper) LoadFromBytes(raw_claim []byte, blockchainName string) err Payload: pbPayload, } - err = c.ValidateAddresses(blockchainName) - if err != nil { - return err - } + // Commenting out because of a bug in SDK release allowing empty addresses. + //err = c.ValidateAddresses(blockchainName) + //if err != nil { + // return err + //} + err = c.ValidateCertificate() if err != nil { return err diff --git a/claim/decode_test.go b/claim/decode_test.go index e832b1a..101aa82 100644 --- a/claim/decode_test.go +++ b/claim/decode_test.go @@ -26,6 +26,14 @@ var raw_claims = []string{ "080110011aed03080112a503080410011a3b4b41205345524159552020323136204449204a504c203432362d41205354415349554e2042414e4a4152207c4a75727573616e205053452d505754228002496e696c6168204b4120536572617975203231362079616e67206d656d62617761206d617374657220626c7573756b616e206a616c7572206e6f6e20616b746966204f6d204d6179626920507261626f776f202068747470733a2f2f7777772e796f75747562652e636f6d2f6368616e6e656c2f55435076355953496f59716f38364a525f4871626b437251202e0a5361617420696e6920616b616e206d656e656c7573757269206a616c7572206e6f6e20616b7469662042616e6a61722d50616e67616e646172616e2d43696a756c616e672e0a68747470733a2f2f7777772e796f75747562652e636f6d2f77617463683f763d4a6b4347615473774c35632a1042616d62616e6720536574796177616e321c436f7079726967687465642028636f6e7461637420617574686f722938004a2968747470733a2f2f6265726b2e6e696e6a612f7468756d626e61696c732f4a6b4347615473774c356352005a001a41080110011a302ed97c79df5eccb145f8f8e1e866be1a392004a6794347c08c7e851c5f00b1504092a9f3c0674c78805a73a33c8b1bf32209766964656f2f6d70342a5c080110031a40cbcec20908e60b5f6198aecc192d2a9e4b069aa58d9238cb7154e37c4d04f268feefe92c2705c14009acf32e7e876df180cff3afdea6c989e75b4861150d1644221402b1839207e2a706f0ba73dec0ce6b719043293d", } +func TestDecodeClaim(t *testing.T) { + claimHex := "000aa4010a8a010a30f1303989f58396694b0c5982c97f7e9d9435841d92aa13f4b80f671c27110c469babc4fbf4bd764155eaac089cfc49e8121454554d205045204d45524e45204c41472e6d703418cad0c8012209766964656f2f6d70343230c2c9389731e2a9568f66c78d703736a8c341015ada2e46f5dcc87aa6f08ab17c02df2121d9f6ef74055827a29dfc75801a044e6f6e6532040803180a5a0908b001109001188102421054554d205045204d45524e45204c41474a0944657369206c6f636b62020801" + claim, err := DecodeClaimHex(claimHex, "lbrycrd_main") + if err != nil { + t.Error(err, claim.ClaimID) + } +} + func TestDecodeClaims(t *testing.T) { for _, claim_hex := range raw_claims { claim, err := DecodeClaimHex(claim_hex, "lbrycrd_main")