diff --git a/server/controllers/api/channel/data/index.js b/server/controllers/api/channel/data/index.js index c0401e1f..612eb016 100644 --- a/server/controllers/api/channel/data/index.js +++ b/server/controllers/api/channel/data/index.js @@ -2,7 +2,11 @@ const { handleErrorResponse } = require('../../../utils/errorHandlers.js'); const getChannelData = require('./getChannelData.js'); const isApprovedChannel = require('../../../../../utils/isApprovedChannel'); const { publishing: { serveOnlyApproved, approvedChannels } } = require('@config/siteConfig'); + const NO_CHANNEL = 'NO_CHANNEL'; +const LONG_ID = 'longId'; +const SHORT_ID = 'shortId'; +const LONG_CLAIM_LENGTH = 40; /* @@ -14,10 +18,9 @@ const channelData = ({ ip, originalUrl, body, params }, res) => { const channelName = params.channelName; let channelClaimId = params.channelClaimId; if (channelClaimId === 'none') channelClaimId = null; - const chanObj = {}; if (channelName) chanObj.name = channelName; - if (channelClaimId) chanObj[(channelClaimId.length === 40 ? 'longId' : 'shortId')] = channelClaimId; + if (channelClaimId) chanObj[(channelClaimId.length === LONG_CLAIM_LENGTH ? LONG_ID : SHORT_ID)] = channelClaimId; if (serveOnlyApproved && !isApprovedChannel(chanObj, approvedChannels)) { return res.status(404).json({ success: false,