LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Speech as a package #416

Merged
bones7242 merged 89 commits from speech-as-a-package into master 2018-04-18 21:47:34 +02:00
Conversation 0 Commits 89 Files changed 203 +2 -2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 0eb762671c - Show all commits

4
config/mysqlConfig.js
View file

@ -1,6 +1,6 @@
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
const logger = require('winston'); const logger = require('winston');
function mysql () { function MysqlConfig () {
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
this.database = 'default'; this.database = 'default';
this.username = 'default'; this.username = 'default';
this.password = 'default'; this.password = 'default';
@ -17,4 +17,4 @@ function mysql () {
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
}; };
} }
module.exports = new mysql(); module.exports = new MysqlConfig();
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function

neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
neb-b commented 2018-04-17 22:32:37 +02:00 (Migrated from github.com)
Review
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function