Commit graph

112 commits

Author SHA1 Message Date
Juan Cruz Viotti
3f6c485c4d Don't keep parsing command options in gksudo/kdesudo
When `gksudo` is detected, this module executes the following command:

```
"/usr/bin/gksudo" --preserve-env --sudo-mode --description="MyApp" <COMMAND>
```

Consider the following command:

```
/home/jviotti/Projects/etcher/node_modules/electron-prebuilt/dist/electron /home/jviotti/Projects/etcher/lib/src/run-child-writer.js lib/start.js /home/jviotti/Downloads/CorePlus-current.iso --robot --drive /dev/sdb --unmount --check
```

Given that the command I'm running contains option arguments, it seems
like `gksudo` tries to interpret the options to my command as `gksudo`
options, failing with errors like this one:

```
/usr/bin/gksudo: unrecognized option '--robot'
```

To prevent this from happening, we can tell `gksudo` to stop parsing
options with the `--` identifier.

The same error happens with `kdesudo`.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-20 13:15:38 -04:00
Joran Dirk Greef
41be5f72f0 4.0.0 2016-05-18 12:53:01 +02:00
Joran Dirk Greef
e428e0b50a Merge branch 'master' of https://github.com/jorangreef/sudo-prompt 2016-05-18 12:52:04 +02:00
Joran Dirk Greef
bd6c099453 Fix applet path to handle spaces 2016-05-18 12:51:54 +02:00
Joran Dirk Greef
5803d0155b Merge pull request #21 from jviotti/feat/preserve-environment
Preserve user environment if possible.
2016-05-18 08:53:56 +02:00
Juan Cruz Viotti
4a5baf5716 Preserve user environment
Some child processes executed with this module might benefit from being
able to read their parent process environment variables.

Fixes: https://github.com/jorangreef/sudo-prompt/issues/20
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-17 13:13:37 -04:00
Joran Dirk Greef
d3cb072cff 3.1.0 2016-04-16 12:33:55 +02:00
Joran Dirk Greef
4a118a0c9c Preserve current working directory on OS X
This improves reliability for commands which expect the current working
directory to be preserved. This may not always be the case on Linux as yet.
2016-04-16 12:29:30 +02:00
Joran Dirk Greef
50147f9376 3.0.1 2016-04-15 15:40:00 +02:00
Joran Dirk Greef
7ae6847997 Update README 2016-04-15 15:39:48 +02:00
Joran Dirk Greef
b579064b59 3.0.0 2016-04-15 13:20:50 +02:00
Joran Dirk Greef
0b5c7d7361 Add support for tty_tickets on OS X (and major breaking changes).
Add support for `tty_tickets` on OS X.
Ensure all line lengths are less than 80 characters.
Fix shell commands to use absolute path (e.g. `/bin/rm`, `/usr/bin/defaults`).
Fix `options.icns` to work with asar packages.
Fix internal method names to reduce chance of a clash with local variables.
Remove `options.onChildProcess()` (no longer possible to support).
Remove batching of password prompts on OS X.
Remove deprecated `setName()`.
Remove deprecated `touch()`.

Fixes: https://github.com/jorangreef/sudo-prompt/issues/13
2016-04-15 13:11:23 +02:00
Joran Dirk Greef
5052cb8401 2.3.0 2016-02-16 08:54:05 +02:00
Joran Dirk Greef
52e86354ba Merge pull request #12 from jviotti/doc/timestamp-invalidation
Document how to invalidate the sudo time stamp file
2016-02-09 15:25:22 +02:00
Juan Cruz Viotti
8336d3baa4 Document how to invalidate the sudo time stamp file
Fixes: https://github.com/jorangreef/sudo-prompt/issues/11
2016-02-09 09:16:12 -04:00
Joran Dirk Greef
1ae88ad24c 2.2.0 2016-02-09 09:30:39 +02:00
Joran Dirk Greef
fe26a8a159 Package applet.app as a base64 zip file within index.js to fix issue with asar files 2016-02-09 09:30:04 +02:00
Joran Dirk Greef
b2a74b347b 2.1.1 2016-01-01 15:52:17 +02:00
Joran Dirk Greef
d08ec680f3 Remove dependency on locale language when detecting sudo error 2016-01-01 15:51:58 +02:00
Joran Dirk Greef
210a928248 2.1.0 2015-11-26 12:12:37 +02:00
Joran Dirk Greef
f163c812cd Document stdout and stderr arguments to callback in usage example 2015-11-26 12:12:30 +02:00
Joran Dirk Greef
f91a0a9b16 Add options.onChildProcess 2015-11-26 12:11:57 +02:00
Joran Dirk Greef
51c17b50d7 2.0.2 2015-11-19 10:04:17 +02:00
Joran Dirk Greef
7b58ff8ffb Emphasize usage for non-graphical terminal commands only 2015-11-19 10:03:42 +02:00
Joran Dirk Greef
52f07e3526 Update README.md 2015-11-17 15:57:33 +02:00
Joran Dirk Greef
104a5970e9 2.0.1 2015-11-17 15:55:11 +02:00
Joran Dirk Greef
9bc245180a Fix macPrompt to remove hash directory in tmp 2015-11-17 15:54:56 +02:00
Joran Dirk Greef
7765652fa7 Update README.md 2015-11-17 15:54:13 +02:00
Joran Dirk Greef
e774c2d134 2.0.0 2015-11-17 15:41:19 +02:00
Joran Dirk Greef
57a83efd64 Add exec options (support options.icns on OS X), add beta Linux support, improve concurrency 2015-11-17 15:40:53 +02:00
Joran Dirk Greef
233b58927b 1.1.8 2015-10-30 09:02:10 +02:00
Joran Dirk Greef
991a38760d Merge pull request #7 from jviotti/jviotti/fix/sudo-ambiguation
Make sure to use the system sudo command (/usr/bin/sudo)
2015-10-30 08:58:30 +02:00
Juan Cruz Viotti
344da8f7b2 Make sure to use the system sudo command
Some modules, like `windosu` expose a binary called `sudo`. By just
calling `sudo`, `sudo-prompt` might accidentally call a `sudo` command
which is not the system one, causing tons of confusions.

Fixes: https://github.com/jorangreef/sudo-prompt/issues/6
2015-10-29 14:56:09 -04:00
Joran Dirk Greef
fcd0d2058e 1.1.7 2015-09-07 09:10:52 +02:00
Joran Dirk Greef
f07b3679c2 Ensure all errors are an instance of Error to capture the stack 2015-09-07 09:10:39 +02:00
Joran Dirk Greef
204436800b 1.1.6 2015-09-07 08:53:17 +02:00
Joran Dirk Greef
2a6642b079 Comment sudo.touch implementation 2015-09-07 08:52:26 +02:00
Joran Dirk Greef
36ab9581de Add setName and exec test 2015-09-07 08:51:27 +02:00
Joran Dirk Greef
1698b73841 Fix early error check skipping password prompt 2015-09-07 08:51:03 +02:00
Joran Dirk Greef
b69a62ef3d Rename git repo 2015-08-10 08:32:13 +02:00
Joran Dirk Greef
52c32fd0ef 1.1.5 2015-08-10 08:31:13 +02:00
Joran Dirk Greef
784725093a Rename git repo 2015-08-10 08:30:52 +02:00
Joran Dirk Greef
306c3fdb58 1.1.4 2015-08-05 09:18:45 +02:00
Joran Dirk Greef
b3027711ca Clarify implementation of sudo.touch 2015-08-05 09:18:34 +02:00
Joran Dirk Greef
57ca6eaaca 1.1.3 2015-08-05 09:13:49 +02:00
Joran Dirk Greef
1061447305 Update README.md 2015-08-05 09:12:00 +02:00
Joran Dirk Greef
122e494c4e Update README.md header 2015-08-05 09:11:02 +02:00
Joran Dirk Greef
73b17830d0 Update README.md 2015-08-05 09:10:34 +02:00
Joran Dirk Greef
8636d2e5bb 1.1.2 2015-06-08 16:29:14 +02:00
Joran Dirk Greef
36b303799e Fix setName 2015-06-08 16:29:05 +02:00