package server import ( "bytes" "fmt" "io/ioutil" "net/http" "net/http/httptest" "strings" "testing" "orblivion/lbry-id/auth" "orblivion/lbry-id/store" "orblivion/lbry-id/wallet" ) func TestServerChangePassword(t *testing.T) { tt := []struct { name string expectedStatusCode int expectedErrorString string // Whether we expect the call to ChangePassword*Wallet to happen expectChangePasswordCall bool // `new...` refers to what is being passed into the via POST request (and // what we expect to get passed into SetWallet for the *non-error* cases // below) newEncryptedWallet wallet.EncryptedWallet newSequence wallet.Sequence newHmac wallet.WalletHmac email auth.Email storeErrors TestStoreFunctionsErrors }{ { name: "success with wallet", expectedStatusCode: http.StatusOK, expectChangePasswordCall: true, newEncryptedWallet: "my-enc-wallet", newSequence: 2, newHmac: "my-hmac", email: "abc@example.com", }, { name: "success no wallet", expectedStatusCode: http.StatusOK, expectChangePasswordCall: true, email: "abc@example.com", }, { name: "conflict with wallet", expectedStatusCode: http.StatusConflict, expectedErrorString: http.StatusText(http.StatusConflict) + ": Bad sequence number or wallet does not exist", expectChangePasswordCall: true, newEncryptedWallet: "my-enc-wallet", newSequence: 2, newHmac: "my-hmac", email: "abc@example.com", storeErrors: TestStoreFunctionsErrors{ChangePasswordWithWallet: store.ErrWrongSequence}, }, { name: "conflict no wallet", expectedStatusCode: http.StatusConflict, expectedErrorString: http.StatusText(http.StatusConflict) + ": Wallet exists; need an updated wallet when changing password", expectChangePasswordCall: true, email: "abc@example.com", storeErrors: TestStoreFunctionsErrors{ChangePasswordNoWallet: store.ErrUnexpectedWallet}, }, { name: "incorrect email with wallet", expectedStatusCode: http.StatusUnauthorized, expectedErrorString: http.StatusText(http.StatusUnauthorized) + ": No match for email and password", expectChangePasswordCall: true, newEncryptedWallet: "my-enc-wallet", newSequence: 2, newHmac: "my-hmac", email: "abc@example.com", storeErrors: TestStoreFunctionsErrors{ChangePasswordWithWallet: store.ErrWrongCredentials}, }, { name: "incorrect email no wallet", expectedStatusCode: http.StatusUnauthorized, expectedErrorString: http.StatusText(http.StatusUnauthorized) + ": No match for email and password", expectChangePasswordCall: true, email: "abc@example.com", storeErrors: TestStoreFunctionsErrors{ChangePasswordNoWallet: store.ErrWrongCredentials}, }, { name: "validation error", expectedStatusCode: http.StatusBadRequest, expectedErrorString: http.StatusText(http.StatusBadRequest) + ": Request failed validation: Invalid 'email'", // Just check one validation error (missing email address) to make sure // the validate function is called. We'll check the rest of the // validation errors in the other test below. expectChangePasswordCall: false, }, { name: "db error changing password with wallet", expectedStatusCode: http.StatusInternalServerError, expectedErrorString: http.StatusText(http.StatusInternalServerError), expectChangePasswordCall: true, // Putting in valid data here so it's clear that this isn't what causes // the error newEncryptedWallet: "my-encrypted-wallet", newSequence: 2, newHmac: "my-hmac", email: "abc@example.com", // What causes the error storeErrors: TestStoreFunctionsErrors{ChangePasswordWithWallet: fmt.Errorf("Some random db problem")}, }, { name: "db error changing password no wallet", expectedStatusCode: http.StatusInternalServerError, expectedErrorString: http.StatusText(http.StatusInternalServerError), expectChangePasswordCall: true, email: "abc@example.com", // What causes the error storeErrors: TestStoreFunctionsErrors{ChangePasswordNoWallet: fmt.Errorf("Some random db problem")}, }, } for _, tc := range tt { t.Run(tc.name, func(t *testing.T) { testAuth := TestAuth{} testStore := TestStore{Errors: tc.storeErrors} s := Server{&testAuth, &testStore} // Whether we passed in wallet fields (these test cases should be passing // in all of them or none of them, so we only test EncryptedWallet). This // determines whether we expect a call to ChangePasswordWithWallet (as // opposed to ChangePasswordNoWallet). withWallet := (tc.newEncryptedWallet != "") const oldPassword = "old password" const newPassword = "new password" requestBody := []byte( fmt.Sprintf(`{ "encryptedWallet": "%s", "sequence": %d, "hmac": "%s", "email": "%s", "oldPassword": "%s", "newPassword": "%s" }`, tc.newEncryptedWallet, tc.newSequence, tc.newHmac, tc.email, oldPassword, newPassword), ) req := httptest.NewRequest(http.MethodPost, PathPassword, bytes.NewBuffer(requestBody)) w := httptest.NewRecorder() s.changePassword(w, req) body, _ := ioutil.ReadAll(w.Body) expectStatusCode(t, w, tc.expectedStatusCode) expectErrorString(t, body, tc.expectedErrorString) if tc.expectedErrorString == "" && string(body) != "{}" { t.Errorf("Expected change password response to be \"{}\": result: %+v", string(body)) } if tc.expectChangePasswordCall { if withWallet { // Called ChangePasswordWithWallet with the expected parameters if want, got := (ChangePasswordWithWalletCall{ EncryptedWallet: tc.newEncryptedWallet, Sequence: tc.newSequence, Hmac: tc.newHmac, Email: tc.email, OldPassword: oldPassword, NewPassword: newPassword, }), testStore.Called.ChangePasswordWithWallet; want != got { t.Errorf("Store.ChangePasswordWithWallet called with: expected %+v, got %+v", want, got) } // Did *not* call ChangePasswordNoWallet if want, got := (ChangePasswordNoWalletCall{}), testStore.Called.ChangePasswordNoWallet; want != got { t.Errorf("Store.ChangePasswordNoWallet unexpectly called with: %+v", got) } } else { // Called ChangePasswordNoWallet with the expected parameters if want, got := (ChangePasswordNoWalletCall{ Email: tc.email, OldPassword: oldPassword, NewPassword: newPassword, }), testStore.Called.ChangePasswordNoWallet; want != got { t.Errorf("Store.ChangePasswordNoWallet called with: expected %+v, got %+v", want, got) } // Did *not* call ChangePasswordWithWallet if want, got := (ChangePasswordWithWalletCall{}), testStore.Called.ChangePasswordWithWallet; want != got { t.Errorf("Store.ChangePasswordWithWallet unexpectly called with: %+v", got) } } } else { if want, got := (ChangePasswordWithWalletCall{}), testStore.Called.ChangePasswordWithWallet; want != got { t.Errorf("Store.ChangePasswordWithWallet unexpectly called with: %+v", got) } if want, got := (ChangePasswordNoWalletCall{}), testStore.Called.ChangePasswordNoWallet; want != got { t.Errorf("Store.ChangePasswordNoWallet unexpectly called with: %+v", got) } } }) } } func TestServerValidateChangePasswordRequest(t *testing.T) { changePasswordRequest := ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 2, Email: "abc@example.com", OldPassword: "123", NewPassword: "456", } if changePasswordRequest.validate() != nil { t.Errorf("Expected valid ChangePasswordRequest with wallet fields to successfully validate") } changePasswordRequest = ChangePasswordRequest{ Email: "abc@example.com", OldPassword: "123", NewPassword: "456", } if changePasswordRequest.validate() != nil { t.Errorf("Expected valid ChangePasswordRequest without wallet fields to successfully validate") } tt := []struct { changePasswordRequest ChangePasswordRequest expectedErrorSubstr string failureDescription string }{ { ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 2, Email: "abc-example.com", OldPassword: "123", NewPassword: "456", }, "email", "Expected WalletRequest with invalid email to not successfully validate", }, { // Note that Golang's email address parser, which I use, will accept // "Abc " so we need to make sure to avoid accepting it. See // the implementation. ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 2, Email: "Abc ", OldPassword: "123", NewPassword: "456", }, "email", "Expected WalletRequest with email with unexpected formatting to not successfully validate", }, { ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 2, OldPassword: "123", NewPassword: "456", }, "email", "Expected WalletRequest with missing email to not successfully validate", }, { ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 2, Email: "abc@example.com", NewPassword: "456", }, "oldPassword", "Expected WalletRequest with missing old password to not successfully validate", }, { ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 2, Email: "abc@example.com", OldPassword: "123", }, "newPassword", "Expected WalletRequest with missing new password to not successfully validate", }, { ChangePasswordRequest{ Hmac: "my-hmac", Sequence: 2, Email: "abc@example.com", OldPassword: "123", NewPassword: "456", }, "'encryptedWallet', 'sequence', and 'hmac'", // More likely to fail when we change the error message but whatever "Expected WalletRequest with missing encrypted wallet (but with other wallet fields present) to not successfully validate", }, { ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Sequence: 2, Email: "abc@example.com", OldPassword: "123", NewPassword: "456", }, "'encryptedWallet', 'sequence', and 'hmac'", // More likely to fail when we change the error message but whatever "Expected WalletRequest with missing hmac (but with other wallet fields present) to not successfully validate", }, { ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 0, Email: "abc@example.com", OldPassword: "123", NewPassword: "456", }, "'encryptedWallet', 'sequence', and 'hmac'", // More likely to fail when we change the error message but whatever "Expected WalletRequest with sequence < 1 (but with other wallet fields present) to not successfully validate", }, { ChangePasswordRequest{ EncryptedWallet: "my-encrypted-wallet", Hmac: "my-hmac", Sequence: 2, Email: "abc@example.com", OldPassword: "123", NewPassword: "123", }, "should not be the same", "Expected WalletRequest with password that does not change to not successfully validate", }, } for _, tc := range tt { err := tc.changePasswordRequest.validate() if !strings.Contains(err.Error(), tc.expectedErrorSubstr) { t.Errorf(tc.failureDescription) } } }