From 382226ff9ad4c9443051b160c32b7b4bcd2bb18e Mon Sep 17 00:00:00 2001 From: Victor Shyba Date: Tue, 7 Aug 2018 13:52:01 -0300 Subject: [PATCH 1/2] tells that an address is wrong earlier on publishing --- lbrynet/daemon/Daemon.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lbrynet/daemon/Daemon.py b/lbrynet/daemon/Daemon.py index 8eda0af4b..b2f4a0cfe 100644 --- a/lbrynet/daemon/Daemon.py +++ b/lbrynet/daemon/Daemon.py @@ -1734,6 +1734,11 @@ class Daemon(AuthJSONRPCServer): if bid <= 0.0: raise ValueError("Bid value must be greater than 0.0") + for address in [claim_address, change_address]: + if address is not None: + # raises an error if the address is invalid + decode_address(address) + yield self.wallet.update_balance() if bid >= self.wallet.get_balance(): balance = yield self.wallet.get_max_usable_balance_for_claim(name) From 81e9c9bf74c4cd3c95e12ff7c22d44131a0a9d94 Mon Sep 17 00:00:00 2001 From: Victor Shyba Date: Tue, 7 Aug 2018 13:53:15 -0300 Subject: [PATCH 2/2] adds a CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index acd74ca62..cdaf084c0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ at anytime. * ### Fixed + * check `claim_address` and `change_address` earlier on publishing, to avoid hard to understand errors later in the process * loggly error reporting not following `share_usage_data` * improper error handling when data is not valid JSON * edge cases of http mirrored download of blobs