From 97fef21f75362366acf5c63eeb1de534a8bd4588 Mon Sep 17 00:00:00 2001 From: Victor Shyba Date: Wed, 12 Oct 2022 00:40:45 -0300 Subject: [PATCH] fallback for suggested file name and tests --- lbry/extras/daemon/json_response_encoder.py | 2 +- lbry/stream/managed_stream.py | 18 +++++++++++++----- tests/unit/stream/test_managed_stream.py | 20 +++++++++++++++++++- 3 files changed, 33 insertions(+), 7 deletions(-) diff --git a/lbry/extras/daemon/json_response_encoder.py b/lbry/extras/daemon/json_response_encoder.py index c75e7d512..7b68f49e1 100644 --- a/lbry/extras/daemon/json_response_encoder.py +++ b/lbry/extras/daemon/json_response_encoder.py @@ -329,7 +329,7 @@ class JSONResponseEncoder(JSONEncoder): 'streaming_url': managed_stream.stream_url, 'stream_hash': managed_stream.stream_hash, 'stream_name': managed_stream.descriptor.stream_name, - 'suggested_file_name': managed_stream.descriptor.suggested_file_name, + 'suggested_file_name': managed_stream.suggested_file_name, 'sd_hash': managed_stream.descriptor.sd_hash, 'mime_type': managed_stream.mime_type, 'key': managed_stream.descriptor.key, diff --git a/lbry/stream/managed_stream.py b/lbry/stream/managed_stream.py index 5ceaff2ad..5bcf52998 100644 --- a/lbry/stream/managed_stream.py +++ b/lbry/stream/managed_stream.py @@ -82,7 +82,15 @@ class ManagedStream(ManagedDownloadSource): @property def file_name(self) -> Optional[str]: - return self._file_name or (self.descriptor.suggested_file_name if self.descriptor else None) + return self._file_name or self.suggested_file_name + + @property + def suggested_file_name(self) -> Optional[str]: + if self.descriptor and self.descriptor.suggested_file_name and self.descriptor.suggested_file_name.strip(): + return self.descriptor.suggested_file_name + elif self.stream_claim_info and self.stream_claim_info.claim: + return sanitize_file_name(self.stream_claim_info.claim.stream.source.name) + return "lbry_download" # default replacement for invalid name. Ideally we should never get here @property def written_bytes(self) -> int: @@ -116,7 +124,7 @@ class ManagedStream(ManagedDownloadSource): @property def mime_type(self): - return guess_media_type(os.path.basename(self.descriptor.suggested_file_name))[0] + return guess_media_type(os.path.basename(self.suggested_file_name))[0] @property def download_path(self): @@ -162,7 +170,7 @@ class ManagedStream(ManagedDownloadSource): if not self._file_name: self._file_name = await get_next_available_file_name( self.loop, self.download_directory, - self._file_name or sanitize_file_name(self.descriptor.suggested_file_name) + self._file_name or sanitize_file_name(self.suggested_file_name) ) file_name, download_dir = self._file_name, self.download_directory else: @@ -294,14 +302,14 @@ class ManagedStream(ManagedDownloadSource): self.download_directory = download_directory or self.download_directory or self.config.download_dir if not self.download_directory: raise ValueError("no directory to download to") - if not (file_name or self._file_name or self.descriptor.suggested_file_name): + if not (file_name or self._file_name or self.suggested_file_name): raise ValueError("no file name to download to") if not os.path.isdir(self.download_directory): log.warning("download directory '%s' does not exist, attempting to make it", self.download_directory) os.mkdir(self.download_directory) self._file_name = await get_next_available_file_name( self.loop, self.download_directory, - file_name or self._file_name or sanitize_file_name(self.descriptor.suggested_file_name) + file_name or self._file_name or sanitize_file_name(self.suggested_file_name) ) await self.blob_manager.storage.change_file_download_dir_and_file_name( self.stream_hash, self.download_directory, self.file_name diff --git a/tests/unit/stream/test_managed_stream.py b/tests/unit/stream/test_managed_stream.py index 953eb4c83..598a3d8d4 100644 --- a/tests/unit/stream/test_managed_stream.py +++ b/tests/unit/stream/test_managed_stream.py @@ -8,6 +8,8 @@ from lbry.blob_exchange.serialization import BlobResponse from lbry.blob_exchange.server import BlobServerProtocol from lbry.dht.node import Node from lbry.dht.peer import make_kademlia_peer +from lbry.extras.daemon.storage import StoredContentClaim +from lbry.schema import Claim from lbry.stream.managed_stream import ManagedStream from lbry.stream.descriptor import StreamDescriptor from tests.unit.blob_exchange.test_transfer_blob import BlobExchangeTestBase @@ -23,7 +25,10 @@ class TestManagedStream(BlobExchangeTestBase): with open(file_path, 'wb') as f: f.write(self.stream_bytes) descriptor = await StreamDescriptor.create_stream(self.loop, self.server_blob_manager.blob_dir, file_path) - self.sd_hash = descriptor.calculate_sd_hash() + descriptor.suggested_file_name = file_name + descriptor.stream_hash = descriptor.get_stream_hash() + self.sd_hash = descriptor.sd_hash = descriptor.calculate_sd_hash() + await descriptor.make_sd_blob() return descriptor async def setup_stream(self, blob_count: int = 10): @@ -47,6 +52,19 @@ class TestManagedStream(BlobExchangeTestBase): self.assertEqual(self.stream.full_path, os.path.join(self.client_dir, 'tt_f')) self.assertTrue(os.path.isfile(os.path.join(self.client_dir, 'tt_f'))) + async def test_empty_name_fallback(self): + descriptor = await self.create_stream(file_name=" ") + descriptor.suggested_file_name = " " + claim = Claim() + claim.stream.source.name = "cool.mp4" + self.stream = ManagedStream( + self.loop, self.client_config, self.client_blob_manager, self.sd_hash, self.client_dir, + claim=StoredContentClaim(serialized=claim.to_bytes().hex()) + ) + await self._test_transfer_stream(10, skip_setup=True) + self.assertTrue(self.stream.completed) + self.assertEqual(self.stream.suggested_file_name, "cool.mp4") + async def test_status_file_completed(self): await self._test_transfer_stream(10) self.assertTrue(self.stream.output_file_exists)