Madiator2011/lbry-sdk
1
0
Fork 0
forked from LBRYCommunity/lbry-sdk
Code Pull requests Activity

Improved the readability of the tests.

Browse source
This commit is contained in:
FemtosecondLaser 2021-10-23 13:12:49 +01:00
parent 2b5838aa01
commit d87f9672fa
1 changed files with 23 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
tests/unit/test_cli.py
View file

@ -207,32 +207,33 @@ class DaemonDocsTests(TestCase):
class EnsureDirectoryExistsTests(TestCase): class EnsureDirectoryExistsTests(TestCase):
def setUp(self):
self.temp_dir = tempfile.mkdtemp()
def tearDown(self):
shutil.rmtree(self.temp_dir)
def test_when_parent_dir_does_not_exist_then_dir_is_created_with_parent(self): def test_when_parent_dir_does_not_exist_then_dir_is_created_with_parent(self):
with tempfile.TemporaryDirectory() as temp_dir: dir_path = os.path.join(self.temp_dir, "parent_dir", "dir")
dir_path = os.path.join(temp_dir, "parent_dir", "dir") ensure_directory_exists(dir_path)
ensure_directory_exists(dir_path) self.assertTrue(os.path.exists(dir_path))
self.assertTrue(os.path.exists(dir_path))
def test_when_non_writable_dir_exists_then_raise(self): def test_when_non_writable_dir_exists_then_raise(self):
with tempfile.TemporaryDirectory() as temp_dir: dir_path = os.path.join(self.temp_dir, "dir")
dir_path = os.path.join(temp_dir, "dir") pathlib.Path(dir_path).mkdir(mode=0o555) # creates a non-writable, readable and executable dir
pathlib.Path(dir_path).mkdir(mode=0o555) # creates a non-writable, readable and executable dir with self.assertRaises(PermissionError):
with self.assertRaises(PermissionError): ensure_directory_exists(dir_path)
ensure_directory_exists(dir_path)
def test_when_dir_exists_and_writable_then_no_raise(self): def test_when_dir_exists_and_writable_then_no_raise(self):
with tempfile.TemporaryDirectory() as temp_dir: dir_path = os.path.join(self.temp_dir, "dir")
dir_path = os.path.join(temp_dir, "dir") pathlib.Path(dir_path).mkdir(mode=0o777) # creates a writable, readable and executable dir
pathlib.Path(dir_path).mkdir(mode=0o777) # creates a writable, readable and executable dir try:
try: ensure_directory_exists(dir_path)
ensure_directory_exists(dir_path) except (FileExistsError, PermissionError) as err:
except (FileExistsError, PermissionError) as err: self.fail(f"{type(err).__name__} was raised")
self.fail(f"{type(err).__name__} was raised")
def test_when_non_dir_file_exists_at_path_then_raise(self): def test_when_non_dir_file_exists_at_path_then_raise(self):
with tempfile.TemporaryDirectory() as temp_dir: file_path = os.path.join(self.temp_dir, "file.extension")
file_path = os.path.join(temp_dir, "file.extension") pathlib.Path(file_path).touch()
with open(file_path, 'x'): with self.assertRaises(FileExistsError):
pass ensure_directory_exists(file_path)
with self.assertRaises(FileExistsError):
ensure_directory_exists(file_path)