forked from LBRYCommunity/lbry-sdk
refactor from review
This commit is contained in:
parent
5f829b048f
commit
f0d334d3e2
1 changed files with 31 additions and 29 deletions
|
@ -234,54 +234,56 @@ class SearchIndex:
|
||||||
async def search_ahead(self, **kwargs):
|
async def search_ahead(self, **kwargs):
|
||||||
# 'limit_claims_per_channel' case. Fetch 1000 results, reorder, slice, inflate and return
|
# 'limit_claims_per_channel' case. Fetch 1000 results, reorder, slice, inflate and return
|
||||||
per_channel_per_page = kwargs.pop('limit_claims_per_channel')
|
per_channel_per_page = kwargs.pop('limit_claims_per_channel')
|
||||||
limit = kwargs.pop('limit', 10)
|
page_size = kwargs.pop('limit', 10)
|
||||||
offset = kwargs.pop('offset', 0)
|
offset = kwargs.pop('offset', 0)
|
||||||
kwargs['limit'] = 1000
|
kwargs['limit'] = 1000
|
||||||
cache_item = ResultCacheItem.from_cache(f"ahead{per_channel_per_page}{kwargs}", self.search_cache)
|
cache_item = ResultCacheItem.from_cache(f"ahead{per_channel_per_page}{kwargs}", self.search_cache)
|
||||||
if cache_item.result is not None:
|
if cache_item.result is not None:
|
||||||
to_inflate = cache_item.result
|
reordered_hits = cache_item.result
|
||||||
else:
|
else:
|
||||||
async with cache_item.lock:
|
async with cache_item.lock:
|
||||||
if cache_item.result:
|
if cache_item.result:
|
||||||
to_inflate = cache_item.result
|
reordered_hits = cache_item.result
|
||||||
else:
|
else:
|
||||||
query = expand_query(**kwargs)
|
query = expand_query(**kwargs)
|
||||||
to_inflate = await self.__search_ahead(query, limit, per_channel_per_page)
|
reordered_hits = await self.__search_ahead(query, page_size, per_channel_per_page)
|
||||||
cache_item.result = to_inflate
|
cache_item.result = reordered_hits
|
||||||
return list(await self.get_many(*(claim_id for claim_id, _ in to_inflate[offset:(offset + limit)])))
|
return list(await self.get_many(*(claim_id for claim_id, _ in reordered_hits[offset:(offset + page_size)])))
|
||||||
|
|
||||||
async def __search_ahead(self, query, limit, per_channel_per_page):
|
async def __search_ahead(self, query: dict, page_size: int, per_channel_per_page: int):
|
||||||
result = deque((await self.search_client.search(
|
search_hits = deque((await self.search_client.search(
|
||||||
query, index=self.index, track_total_hits=False, _source_includes=['_id', 'channel_id']
|
query, index=self.index, track_total_hits=False, _source_includes=['_id', 'channel_id']
|
||||||
))['hits']['hits'])
|
))['hits']['hits'])
|
||||||
to_inflate = []
|
reordered_hits = []
|
||||||
channel_counter = Counter()
|
channel_counters = Counter()
|
||||||
delayed = deque()
|
next_page_hits_maybe_check_later = deque()
|
||||||
while result or delayed:
|
while search_hits or next_page_hits_maybe_check_later:
|
||||||
if len(to_inflate) % limit == 0:
|
if reordered_hits and len(reordered_hits) % page_size == 0:
|
||||||
channel_counter.clear()
|
channel_counters.clear()
|
||||||
|
elif not reordered_hits:
|
||||||
|
pass
|
||||||
else:
|
else:
|
||||||
break # means last page was incomplete and we are left with bad replacements
|
break # means last page was incomplete and we are left with bad replacements
|
||||||
for _ in range(len(delayed)):
|
for _ in range(len(next_page_hits_maybe_check_later)):
|
||||||
claim_id, channel_id = delayed.popleft()
|
claim_id, channel_id = next_page_hits_maybe_check_later.popleft()
|
||||||
if channel_counter[channel_id] < per_channel_per_page:
|
if channel_counters[channel_id] < per_channel_per_page:
|
||||||
to_inflate.append((claim_id, channel_id))
|
reordered_hits.append((claim_id, channel_id))
|
||||||
channel_counter[channel_id] += 1
|
channel_counters[channel_id] += 1
|
||||||
else:
|
else:
|
||||||
delayed.append((claim_id, channel_id))
|
next_page_hits_maybe_check_later.append((claim_id, channel_id))
|
||||||
while result:
|
while search_hits:
|
||||||
hit = result.popleft()
|
hit = search_hits.popleft()
|
||||||
hit_id, hit_channel_id = hit['_id'], hit['_source']['channel_id']
|
hit_id, hit_channel_id = hit['_id'], hit['_source']['channel_id']
|
||||||
if hit_channel_id is None:
|
if hit_channel_id is None:
|
||||||
to_inflate.append((hit_id, hit_channel_id))
|
reordered_hits.append((hit_id, hit_channel_id))
|
||||||
elif channel_counter[hit_channel_id] < per_channel_per_page:
|
elif channel_counters[hit_channel_id] < per_channel_per_page:
|
||||||
to_inflate.append((hit_id, hit_channel_id))
|
reordered_hits.append((hit_id, hit_channel_id))
|
||||||
channel_counter[hit_channel_id] += 1
|
channel_counters[hit_channel_id] += 1
|
||||||
if len(to_inflate) % limit == 0:
|
if len(reordered_hits) % page_size == 0:
|
||||||
break
|
break
|
||||||
else:
|
else:
|
||||||
delayed.append((hit_id, hit_channel_id))
|
next_page_hits_maybe_check_later.append((hit_id, hit_channel_id))
|
||||||
return to_inflate
|
return reordered_hits
|
||||||
|
|
||||||
async def resolve_url(self, raw_url):
|
async def resolve_url(self, raw_url):
|
||||||
if raw_url not in self.resolution_cache:
|
if raw_url not in self.resolution_cache:
|
||||||
|
|
Loading…
Reference in a new issue