mypy refactor, improve coverage #12

Merged

jackrobison merged 9 commits from mypy-refactor into master

2019-05-22 09:05:10 +02:00

jackrobison commented

2019-05-22 09:02:53 +02:00

(Migrated from github.com)

unused commands are commented out
use defusedxml for xml parsing

- unused commands are commented out - use `defusedxml` for xml parsing

codecov[bot] commented

2019-05-22 09:05:27 +02:00

(Migrated from github.com)

Codecov Report

Merging #12 into master will increase coverage by 6.12%.
The diff coverage is 90.94%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   82.55%   88.67%   +6.12%     
==========================================
  Files          26       18       -8     
  Lines        1811     1316     -495     
==========================================
- Hits         1495     1167     -328     
+ Misses        316      149     -167

Impacted Files	Coverage Δ
aioupnp/fault.py	`100% <ø> (ø)`	⬆️
aioupnp/serialization/scpd.py	`100% <100%> (+4.34%)`	⬆️
aioupnp/__init__.py	`100% <100%> (ø)`	⬆️
aioupnp/serialization/xml.py	`100% <100%> (ø)`
aioupnp/serialization/soap.py	`100% <100%> (+10%)`	⬆️
aioupnp/protocols/m_search_patterns.py	`100% <100%> (ø)`	⬆️
aioupnp/__main__.py	`71.64% <71.87%> (+0.21%)`	⬆️
aioupnp/interfaces.py	`83.78% <83.78%> (ø)`
aioupnp/gateway.py	`76.35% <84.21%> (+1.21%)`	⬆️
aioupnp/protocols/ssdp.py	`85.5% <86.2%> (-2.4%)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a404269...d87a170. Read the comment docs.

# [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/12?src=pr&el=h1) Report > Merging [#12](https://codecov.io/gh/lbryio/aioupnp/pull/12?src=pr&el=desc) into [master](https://codecov.io/gh/lbryio/aioupnp/commit/a404269d91cff5358bcffb8067b0fd1d9c6842d3?src=pr&el=desc) will **increase** coverage by `6.12%`. > The diff coverage is `90.94%`. [![Impacted file tree graph](https://codecov.io/gh/lbryio/aioupnp/pull/12/graphs/tree.svg?width=650&token=WAT2zW6Wy6&height=150&src=pr)](https://codecov.io/gh/lbryio/aioupnp/pull/12?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #12 +/- ## ========================================== + Coverage 82.55% 88.67% +6.12% ========================================== Files 26 18 -8 Lines 1811 1316 -495 ========================================== - Hits 1495 1167 -328 + Misses 316 149 -167 ``` | [Impacted Files](https://codecov.io/gh/lbryio/aioupnp/pull/12?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [aioupnp/fault.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9mYXVsdC5weQ==) | `100% <ø> (ø)` | :arrow_up: | | [aioupnp/serialization/scpd.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9zZXJpYWxpemF0aW9uL3NjcGQucHk=) | `100% <100%> (+4.34%)` | :arrow_up: | | [aioupnp/\_\_init\_\_.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | | [aioupnp/serialization/xml.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9zZXJpYWxpemF0aW9uL3htbC5weQ==) | `100% <100%> (ø)` | | | [aioupnp/serialization/soap.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9zZXJpYWxpemF0aW9uL3NvYXAucHk=) | `100% <100%> (+10%)` | :arrow_up: | | [aioupnp/protocols/m\_search\_patterns.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvbV9zZWFyY2hfcGF0dGVybnMucHk=) | `100% <100%> (ø)` | :arrow_up: | | [aioupnp/\_\_main\_\_.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9fX21haW5fXy5weQ==) | `71.64% <71.87%> (+0.21%)` | :arrow_up: | | [aioupnp/interfaces.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9pbnRlcmZhY2VzLnB5) | `83.78% <83.78%> (ø)` | | | [aioupnp/gateway.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9nYXRld2F5LnB5) | `76.35% <84.21%> (+1.21%)` | :arrow_up: | | [aioupnp/protocols/ssdp.py](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvc3NkcC5weQ==) | `85.5% <86.2%> (-2.4%)` | :arrow_down: | | ... and [13 more](https://codecov.io/gh/lbryio/aioupnp/pull/12/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/12?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/12?src=pr&el=footer). Last update [a404269...d87a170](https://codecov.io/gh/lbryio/aioupnp/pull/12?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/aioupnp#12

No description provided.