more mypy refactoring, improve coverage #13

Merged

jackrobison merged 1 commit from improve-coverage into master

2019-05-24 03:35:37 +02:00

jackrobison commented

2019-05-24 03:31:08 +02:00

(Migrated from github.com)

No description provided.

codecov[bot] commented

2019-05-24 03:34:07 +02:00

(Migrated from github.com)

Codecov Report

Merging #13 into master will increase coverage by 4.08%.
The diff coverage is 98.02%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   88.67%   92.76%   +4.08%     
==========================================
  Files          18       18              
  Lines        1316     1341      +25     
==========================================
+ Hits         1167     1244      +77     
+ Misses        149       97      -52

Impacted Files	Coverage Δ
aioupnp/__main__.py	`93.67% <100%> (+22.02%)`	⬆️
aioupnp/gateway.py	`85.56% <100%> (+9.21%)`	⬆️
aioupnp/protocols/ssdp.py	`95.34% <100%> (+9.84%)`	⬆️
aioupnp/protocols/multicast.py	`100% <100%> (+5.66%)`	⬆️
aioupnp/commands.py	`92.02% <95.55%> (-0.48%)`	⬇️
aioupnp/upnp.py	`84.28% <96.42%> (+2.02%)`	⬆️
aioupnp/protocols/scpd.py	`98.23% <0%> (+2.65%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ad340...5356b78. Read the comment docs.

# [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/13?src=pr&el=h1) Report > Merging [#13](https://codecov.io/gh/lbryio/aioupnp/pull/13?src=pr&el=desc) into [master](https://codecov.io/gh/lbryio/aioupnp/commit/e2ad340868a5ad58baaa6701abedadbde81a7efb?src=pr&el=desc) will **increase** coverage by `4.08%`. > The diff coverage is `98.02%`. [![Impacted file tree graph](https://codecov.io/gh/lbryio/aioupnp/pull/13/graphs/tree.svg?width=650&token=WAT2zW6Wy6&height=150&src=pr)](https://codecov.io/gh/lbryio/aioupnp/pull/13?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #13 +/- ## ========================================== + Coverage 88.67% 92.76% +4.08% ========================================== Files 18 18 Lines 1316 1341 +25 ========================================== + Hits 1167 1244 +77 + Misses 149 97 -52 ``` | [Impacted Files](https://codecov.io/gh/lbryio/aioupnp/pull/13?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [aioupnp/\_\_main\_\_.py](https://codecov.io/gh/lbryio/aioupnp/pull/13/diff?src=pr&el=tree#diff-YWlvdXBucC9fX21haW5fXy5weQ==) | `93.67% <100%> (+22.02%)` | :arrow_up: | | [aioupnp/gateway.py](https://codecov.io/gh/lbryio/aioupnp/pull/13/diff?src=pr&el=tree#diff-YWlvdXBucC9nYXRld2F5LnB5) | `85.56% <100%> (+9.21%)` | :arrow_up: | | [aioupnp/protocols/ssdp.py](https://codecov.io/gh/lbryio/aioupnp/pull/13/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvc3NkcC5weQ==) | `95.34% <100%> (+9.84%)` | :arrow_up: | | [aioupnp/protocols/multicast.py](https://codecov.io/gh/lbryio/aioupnp/pull/13/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvbXVsdGljYXN0LnB5) | `100% <100%> (+5.66%)` | :arrow_up: | | [aioupnp/commands.py](https://codecov.io/gh/lbryio/aioupnp/pull/13/diff?src=pr&el=tree#diff-YWlvdXBucC9jb21tYW5kcy5weQ==) | `92.02% <95.55%> (-0.48%)` | :arrow_down: | | [aioupnp/upnp.py](https://codecov.io/gh/lbryio/aioupnp/pull/13/diff?src=pr&el=tree#diff-YWlvdXBucC91cG5wLnB5) | `84.28% <96.42%> (+2.02%)` | :arrow_up: | | [aioupnp/protocols/scpd.py](https://codecov.io/gh/lbryio/aioupnp/pull/13/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvc2NwZC5weQ==) | `98.23% <0%> (+2.65%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/13?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/13?src=pr&el=footer). Last update [e2ad340...5356b78](https://codecov.io/gh/lbryio/aioupnp/pull/13?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/aioupnp#13

No description provided.