use appropriate asserts in tests #17

Merged

StrikerRUS merged 1 commit from tests into master

2019-10-09 15:01:27 +02:00

StrikerRUS commented

2019-10-09 00:05:24 +02:00

(Migrated from github.com)

Especially, foo == None is dangerous one, and is None should be used: https://www.python.org/dev/peps/pep-0008/#programming-recommendations.

Especially, `foo == None` is dangerous one, and `is None` should be used: https://www.python.org/dev/peps/pep-0008/#programming-recommendations.

codecov[bot] commented

2019-10-09 00:08:52 +02:00

(Migrated from github.com)

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          18       18           
  Lines        1371     1371           
=======================================
  Hits         1272     1272           
  Misses         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7ef00...bad5a0c. Read the comment docs.

# [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/17?src=pr&el=h1) Report > Merging [#17](https://codecov.io/gh/lbryio/aioupnp/pull/17?src=pr&el=desc) into [master](https://codecov.io/gh/lbryio/aioupnp/commit/ab7ef0048bbce6404e463d20e8a15046ea6941f0?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/lbryio/aioupnp/pull/17/graphs/tree.svg?width=650&token=WAT2zW6Wy6&height=150&src=pr)](https://codecov.io/gh/lbryio/aioupnp/pull/17?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #17 +/- ## ======================================= Coverage 92.77% 92.77% ======================================= Files 18 18 Lines 1371 1371 ======================================= Hits 1272 1272 Misses 99 99 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/17?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/17?src=pr&el=footer). Last update [ab7ef00...bad5a0c](https://codecov.io/gh/lbryio/aioupnp/pull/17?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

tzarebczan commented

2019-10-15 17:56:29 +02:00

(Migrated from github.com)

@StrikerRUS , thanks for the PR!

Can we show you some appreciation for the contribution?

Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

@StrikerRUS , thanks for the PR! Can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution? Also, we're giving away some [Hacktoberfest](https://lbry.com/news/hacktoberfest-2019) bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/aioupnp#17

No description provided.