Faster gateway discovery #18

Merged

jackrobison merged 7 commits from fast-discover into master

2019-10-25 22:12:41 +02:00

jackrobison commented

2019-10-22 01:06:36 +02:00

(Migrated from github.com)

Previously the required pattern for the M-SEARCH packet was probed out by sending two variants at a time, and then each on their own once a pair had a hit. This changes device discovery to try all of the variants at once. This means discovery will be much faster, but it is not possible to know which packet variant was needed versus the others.

codecov[bot] commented

2019-10-22 01:12:46 +02:00

(Migrated from github.com)

Codecov Report

Merging #18 into master will increase coverage by 0.16%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   92.77%   92.94%   +0.16%     
==========================================
  Files          18       18              
  Lines        1371     1360      -11     
==========================================
- Hits         1272     1264       -8     
+ Misses         99       96       -3

Impacted Files	Coverage Δ
aioupnp/__main__.py	`91.02% <ø> (-2.65%)`	⬇️
aioupnp/serialization/ssdp.py	`94.8% <100%> (+0.1%)`	⬆️
aioupnp/upnp.py	`85.18% <100%> (+0.89%)`	⬆️
aioupnp/protocols/scpd.py	`98.24% <100%> (ø)`	⬆️
aioupnp/protocols/ssdp.py	`100% <100%> (+4.65%)`	⬆️
aioupnp/gateway.py	`84.65% <68.62%> (-1.07%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c39ce...8e07d7f. Read the comment docs.

# [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/18?src=pr&el=h1) Report > Merging [#18](https://codecov.io/gh/lbryio/aioupnp/pull/18?src=pr&el=desc) into [master](https://codecov.io/gh/lbryio/aioupnp/commit/b1c39cef7b5c201aa8a0af76c406fab17b18076d?src=pr&el=desc) will **increase** coverage by `0.16%`. > The diff coverage is `85.18%`. [![Impacted file tree graph](https://codecov.io/gh/lbryio/aioupnp/pull/18/graphs/tree.svg?width=650&token=WAT2zW6Wy6&height=150&src=pr)](https://codecov.io/gh/lbryio/aioupnp/pull/18?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #18 +/- ## ========================================== + Coverage 92.77% 92.94% +0.16% ========================================== Files 18 18 Lines 1371 1360 -11 ========================================== - Hits 1272 1264 -8 + Misses 99 96 -3 ``` | [Impacted Files](https://codecov.io/gh/lbryio/aioupnp/pull/18?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [aioupnp/\_\_main\_\_.py](https://codecov.io/gh/lbryio/aioupnp/pull/18/diff?src=pr&el=tree#diff-YWlvdXBucC9fX21haW5fXy5weQ==) | `91.02% <ø> (-2.65%)` | :arrow_down: | | [aioupnp/serialization/ssdp.py](https://codecov.io/gh/lbryio/aioupnp/pull/18/diff?src=pr&el=tree#diff-YWlvdXBucC9zZXJpYWxpemF0aW9uL3NzZHAucHk=) | `94.8% <100%> (+0.1%)` | :arrow_up: | | [aioupnp/upnp.py](https://codecov.io/gh/lbryio/aioupnp/pull/18/diff?src=pr&el=tree#diff-YWlvdXBucC91cG5wLnB5) | `85.18% <100%> (+0.89%)` | :arrow_up: | | [aioupnp/protocols/scpd.py](https://codecov.io/gh/lbryio/aioupnp/pull/18/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvc2NwZC5weQ==) | `98.24% <100%> (ø)` | :arrow_up: | | [aioupnp/protocols/ssdp.py](https://codecov.io/gh/lbryio/aioupnp/pull/18/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvc3NkcC5weQ==) | `100% <100%> (+4.65%)` | :arrow_up: | | [aioupnp/gateway.py](https://codecov.io/gh/lbryio/aioupnp/pull/18/diff?src=pr&el=tree#diff-YWlvdXBucC9nYXRld2F5LnB5) | `84.65% <68.62%> (-1.07%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/18?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/18?src=pr&el=footer). Last update [b1c39ce...8e07d7f](https://codecov.io/gh/lbryio/aioupnp/pull/18?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/aioupnp#18

No description provided.