Fix uncaught ConnectionError in scpd_post and scpd_get #22

Merged

jackrobison merged 3 commits from catch-connection-error into master

2020-01-15 22:37:03 +01:00

jackrobison commented

2020-01-15 22:10:53 +01:00

(Migrated from github.com)

fixes https://github.com/lbryio/aioupnp/issues/21

codecov[bot] commented

2020-01-15 22:14:51 +01:00

(Migrated from github.com)

Codecov Report

Merging #22 into master will decrease coverage by 0.11%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   92.94%   92.82%   -0.12%     
==========================================
  Files          18       18              
  Lines        1360     1366       +6     
==========================================
+ Hits         1264     1268       +4     
- Misses         96       98       +2

Impacted Files	Coverage Δ
aioupnp/serialization/scpd.py	`100% <100%> (ø)`	⬆️
aioupnp/protocols/scpd.py	`96.66% <75%> (-1.58%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f61f0...6d52d76. Read the comment docs.

# [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/22?src=pr&el=h1) Report > Merging [#22](https://codecov.io/gh/lbryio/aioupnp/pull/22?src=pr&el=desc) into [master](https://codecov.io/gh/lbryio/aioupnp/commit/d0f61f05972ef12e8b3dd93aacbbbffb050d0ae3?src=pr&el=desc) will **decrease** coverage by `0.11%`. > The diff coverage is `80%`. [![Impacted file tree graph](https://codecov.io/gh/lbryio/aioupnp/pull/22/graphs/tree.svg?width=650&token=WAT2zW6Wy6&height=150&src=pr)](https://codecov.io/gh/lbryio/aioupnp/pull/22?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #22 +/- ## ========================================== - Coverage 92.94% 92.82% -0.12% ========================================== Files 18 18 Lines 1360 1366 +6 ========================================== + Hits 1264 1268 +4 - Misses 96 98 +2 ``` | [Impacted Files](https://codecov.io/gh/lbryio/aioupnp/pull/22?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [aioupnp/serialization/scpd.py](https://codecov.io/gh/lbryio/aioupnp/pull/22/diff?src=pr&el=tree#diff-YWlvdXBucC9zZXJpYWxpemF0aW9uL3NjcGQucHk=) | `100% <100%> (ø)` | :arrow_up: | | [aioupnp/protocols/scpd.py](https://codecov.io/gh/lbryio/aioupnp/pull/22/diff?src=pr&el=tree#diff-YWlvdXBucC9wcm90b2NvbHMvc2NwZC5weQ==) | `96.66% <75%> (-1.58%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/22?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/22?src=pr&el=footer). Last update [d0f61f0...6d52d76](https://codecov.io/gh/lbryio/aioupnp/pull/22?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/aioupnp#22

No description provided.