Add lease_time as parameter #25

Merged
PhilippHomann merged 2 commits from master into master 2020-12-21 20:54:52 +01:00
PhilippHomann commented 2020-12-20 14:49:58 +01:00 (Migrated from github.com)

Nothing more to say..

Nothing more to say..
codecov[bot] commented 2020-12-20 15:30:29 +01:00 (Migrated from github.com)

Codecov Report

Merging #25 (2b4295b) into master (5a3333c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          18       18           
  Lines        1355     1355           
=======================================
  Hits         1300     1300           
  Misses         55       55           
Impacted Files Coverage Δ
aioupnp/upnp.py 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3333c...2b4295b. Read the comment docs.

# [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/25?src=pr&el=h1) Report > Merging [#25](https://codecov.io/gh/lbryio/aioupnp/pull/25?src=pr&el=desc) (2b4295b) into [master](https://codecov.io/gh/lbryio/aioupnp/commit/5a3333c8951e9e92b57fac1dd3268c0ccaa6d066?el=desc) (5a3333c) will **not change** coverage. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/lbryio/aioupnp/pull/25/graphs/tree.svg?width=650&height=150&src=pr&token=WAT2zW6Wy6)](https://codecov.io/gh/lbryio/aioupnp/pull/25?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #25 +/- ## ======================================= Coverage 95.94% 95.94% ======================================= Files 18 18 Lines 1355 1355 ======================================= Hits 1300 1300 Misses 55 55 ``` | [Impacted Files](https://codecov.io/gh/lbryio/aioupnp/pull/25?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [aioupnp/upnp.py](https://codecov.io/gh/lbryio/aioupnp/pull/25/diff?src=pr&el=tree#diff-YWlvdXBucC91cG5wLnB5) | `92.85% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/25?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/lbryio/aioupnp/pull/25?src=pr&el=footer). Last update [5a3333c...2b4295b](https://codecov.io/gh/lbryio/aioupnp/pull/25?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
jackrobison (Migrated from github.com) approved these changes 2020-12-21 20:53:10 +01:00
jackrobison (Migrated from github.com) left a comment

Looks good to me

Looks good to me
jackrobison commented 2020-12-21 20:54:47 +01:00 (Migrated from github.com)

Thanks for the pr!

Thanks for the pr!
PhilippHomann commented 2023-03-27 08:03:38 +02:00 (Migrated from github.com)

@jackrobison Are there any plans on tagging and releasing this on pypi?

@jackrobison Are there any plans on tagging and releasing this on pypi?
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/aioupnp#25
No description provided.