rename EMPTY to EMPTY_SCRIPT, extract VALUE_UINT64_MAX constant

This commit is contained in:
Daniel Cousens 2015-08-18 09:04:07 +10:00
parent 1c92cfb373
commit 20fd3cee8c

View file

@ -97,7 +97,7 @@ Transaction.isCoinbaseHash = function (buffer) {
}) })
} }
var EMPTY = new Buffer(0) var EMPTY_SCRIPT = new Buffer(0)
Transaction.prototype.addInput = function (hash, index, sequence, script) { Transaction.prototype.addInput = function (hash, index, sequence, script) {
typeforce(types.tuple( typeforce(types.tuple(
@ -111,7 +111,7 @@ Transaction.prototype.addInput = function (hash, index, sequence, script) {
sequence = Transaction.DEFAULT_SEQUENCE sequence = Transaction.DEFAULT_SEQUENCE
} }
script = script || EMPTY script = script || EMPTY_SCRIPT
// Add the input and return the input's index // Add the input and return the input's index
return (this.ins.push({ return (this.ins.push({
@ -173,6 +173,7 @@ Transaction.prototype.clone = function () {
} }
var ONE = new Buffer('0000000000000000000000000000000000000000000000000000000000000001', 'hex') var ONE = new Buffer('0000000000000000000000000000000000000000000000000000000000000001', 'hex')
var VALUE_UINT64_MAX = new Buffer('ffffffffffffffff', 'hex')
/** /**
* Hash transaction for signing a specific input. * Hash transaction for signing a specific input.
@ -198,7 +199,7 @@ Transaction.prototype.hashForSignature = function (inIndex, prevOutScript, hashT
var i var i
// blank out other inputs' signatures // blank out other inputs' signatures
txTmp.ins.forEach(function (input) { input.script = EMPTY }) txTmp.ins.forEach(function (input) { input.script = EMPTY_SCRIPT })
txTmp.ins[inIndex].script = hashScript txTmp.ins[inIndex].script = hashScript
// blank out some of the inputs // blank out some of the inputs
@ -224,8 +225,8 @@ Transaction.prototype.hashForSignature = function (inIndex, prevOutScript, hashT
// blank all other outputs (clear scriptPubKey, value === -1) // blank all other outputs (clear scriptPubKey, value === -1)
var stubOut = { var stubOut = {
script: EMPTY, script: EMPTY_SCRIPT,
valueBuffer: new Buffer('ffffffffffffffff', 'hex') valueBuffer: VALUE_UINT64_MAX
} }
for (i = 0; i < nOut; i++) { for (i = 0; i < nOut; i++) {