base58check: buffers only, remove explicit 0
Undefined is treated as zero if it ever gets to this point anyway, so no value is added by having this default param here. A test fixture to verify this behaviour is added.
This commit is contained in:
parent
77ed66b24d
commit
2b2081bed9
3 changed files with 9 additions and 8 deletions
|
@ -4,13 +4,8 @@ var base58 = require('./base58')
|
|||
var crypto = require('./crypto')
|
||||
|
||||
// Encode a buffer as a base58-check-encoded string
|
||||
function encode(buffer, version) {
|
||||
version = version || 0
|
||||
|
||||
// FIXME: `new Buffer(buffer)` is unnecessary if input is a Buffer
|
||||
function encode(payload, version) {
|
||||
var version = new Buffer([version])
|
||||
var payload = new Buffer(buffer)
|
||||
|
||||
var message = Buffer.concat([version, payload])
|
||||
var checksum = crypto.hash256(message).slice(0, 4)
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue