LBRYCommunity/bitcoinjs-lib
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Transaction: remove untestable assert

Browse source 
Also changes the fromBuffer sanity test to use a clearer message that is
taken from the fixtures.
This commit is contained in:
Daniel Cousens 2014-06-17 00:16:48 +10:00
parent 1b1b550bd6
commit 4850570955
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/transaction.js
View file

@ -144,7 +144,6 @@ Transaction.prototype.toBuffer = function () {
}) })
writeUInt32(this.locktime) writeUInt32(this.locktime)
assert.equal(offset, buffer.length, 'Invalid transaction object')
return buffer return buffer
} }
@ -286,7 +285,7 @@ Transaction.fromBuffer = function(buffer) {
} }
tx.locktime = readUInt32() tx.locktime = readUInt32()
assert.equal(offset, buffer.length, 'Invalid transaction') assert.equal(offset, buffer.length, 'Transaction has unexpected data')
return tx return tx
} }

2
test/transaction.js
View file

@ -36,7 +36,7 @@ describe('Transaction', function() {
it('throws on ' + f.exception, function() { it('throws on ' + f.exception, function() {
assert.throws(function() { assert.throws(function() {
Transaction.fromHex(f.hex) Transaction.fromHex(f.hex)
}, /Invalid transaction/) }, new RegExp(f.exception))
}) })
}) })
}) })