make wallet async functions truly async

src/wallet.js

@@ -84,13 +84,14 @@ var Wallet = function (seed, options) {
     }
 
     this.setUnspentOutputsAsync = function(utxo, callback) {
+      var error = null
       try {
         this.setUnspentOutputs(utxo)
       } catch(err) {
-        return callback(err)
+        error = err
+      } finally {
+        process.nextTick(function(){ callback(error) })
       }
-
-      return callback()
     }
 
     function outputToUnspentOutput(output){
@@ -206,14 +207,15 @@ var Wallet = function (seed, options) {
         fixedFee = undefined
       }
       var tx = null
+      var error = null
 
       try {
         tx = this.createTx(to, value, fixedFee)
       } catch(err) {
-        return callback(err)
+        error = err
+      } finally {
+        process.nextTick(function(){ callback(error, tx) })
       }
-
-      callback(null, tx)
     }
 
     this.dustThreshold = 5430

test/wallet.js

@@ -284,24 +284,25 @@ describe('Wallet', function() {
         wallet.setUnspentOutputs.restore()
       })
 
-      it('calls setUnspentOutputs', function(){
+      it('calls setUnspentOutputs', function(done){
         sinon.stub(wallet, "setUnspentOutputs")
 
-        var callback = sinon.spy()
+        var callback = function(){
-        var tx = wallet.setUnspentOutputsAsync(utxo, callback)
+          assert(wallet.setUnspentOutputs.calledWith(utxo))
+          done()
+        }
 
-        assert(wallet.setUnspentOutputs.calledWith(utxo))
+        wallet.setUnspentOutputsAsync(utxo, callback)
-        assert(callback.called)
       })
 
-      it('when setUnspentOutputs throws an error, it invokes callback with error', function(){
+      it('when setUnspentOutputs throws an error, it invokes callback with error', function(done){
         sinon.stub(wallet, "setUnspentOutputs").throws()
 
-        var callback = sinon.spy()
+        var callback = function(err){
-        var tx = wallet.setUnspentOutputsAsync(utxo, callback)
+          assert(err instanceof Error)
-
+          done()
-        assert(callback.called)
+        }
-        assert(callback.args[0][0] instanceof Error)
+        wallet.setUnspentOutputsAsync(utxo, callback)
       })
     })
   })
@@ -549,34 +550,41 @@ describe('Wallet', function() {
       wallet.createTx.restore()
     })
 
-    it('calls createTx', function(){
+    it('calls createTx', function(done){
       sinon.stub(wallet, "createTx").returns("fakeTx")
 
-      var callback = sinon.spy()
+      var callback = function(err, tx){
-      var tx = wallet.createTxAsync(to, value, callback)
+        assert(wallet.createTx.calledWith(to, value))
+        assert.equal(err, null)
+        assert.equal(tx, "fakeTx")
+        done()
+      }
 
-      assert(wallet.createTx.calledWith(to, value))
+      wallet.createTxAsync(to, value, callback)
-      assert(callback.calledWith(null, "fakeTx"))
     })
 
-    it('calls createTx correctly when fee is specified', function(){
+    it('calls createTx correctly when fee is specified', function(done){
       sinon.stub(wallet, "createTx").returns("fakeTx")
 
-      var callback = sinon.spy()
+      var callback = function(err, tx){
-      var tx = wallet.createTxAsync(to, value, fee, callback)
+        assert(wallet.createTx.calledWith(to, value, fee))
+        assert.equal(err, null)
+        assert.equal(tx, "fakeTx")
+        done()
+      }
 
-      assert(wallet.createTx.calledWith(to, value, fee))
+      wallet.createTxAsync(to, value, fee, callback)
-      assert(callback.calledWith(null, "fakeTx"))
     })
 
-    it('when createTx throws an error, it invokes callback with error', function(){
+    it('when createTx throws an error, it invokes callback with error', function(done){
       sinon.stub(wallet, "createTx").throws()
 
-      var callback = sinon.spy()
+      var callback = function(err, tx){
-      var tx = wallet.createTxAsync(to, value, callback)
+        assert(err instanceof Error)
+        done()
+      }
 
-      assert(callback.called)
+      wallet.createTxAsync(to, value, callback)
-      assert(callback.args[0][0] instanceof Error)
     })
   })