LBRYCommunity/bitcoinjs-lib
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Transaction: improve hash length checking + tests

Browse source
This commit is contained in:
Daniel Cousens 2014-06-17 20:18:39 +10:00
parent d07cfccbc1
commit 8eaf44881a
3 changed files with 25 additions and 2 deletions

4
src/transaction.js
View file

@ -39,7 +39,6 @@ Transaction.prototype.addInput = function(tx, index, sequence) {
if (typeof tx === 'string') {
hash = new Buffer(tx, 'hex')
assert.equal(hash.length, 32, 'Expected Transaction, txId or txHash, got ' + tx)
// TxId hex is big-endian, we need little-endian
Array.prototype.reverse.call(hash)
@ -48,10 +47,11 @@ Transaction.prototype.addInput = function(tx, index, sequence) {
hash = tx.getHash()
} else {
assert(Buffer.isBuffer(tx), 'Expected Transaction, txId or txHash, got ' + tx)
hash = tx
}
assert(Buffer.isBuffer(hash), 'Expected Transaction, txId or txHash, got ' + tx)
assert.equal(hash.length, 32, 'Expected hash length of 32, got ' + hash.length)
assert.equal(typeof index, 'number', 'Expected number index, got ' + index)
return (this.ins.push({