LBRYCommunity/bitcoinjs-lib
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Corrects endianness comments

Browse source
This commit is contained in:
Daniel Cousens 2014-05-03 07:55:47 +10:00
parent 87048d3b4e
commit b860daf70b
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/transaction.js
View file

@ -164,7 +164,7 @@ Transaction.prototype.serialize = function () {
this.ins.forEach(function(txin, i) { this.ins.forEach(function(txin, i) {
var hash = new Buffer(txin.outpoint.hash, 'hex') // FIXME: Performance: convert on tx.addInput instead var hash = new Buffer(txin.outpoint.hash, 'hex') // FIXME: Performance: convert on tx.addInput instead
// Hash is big-endian, we want little-endian for the hex // TxHash hex is big-endian, we need little-endian
Array.prototype.reverse.call(hash) Array.prototype.reverse.call(hash)
writeSlice(hash) writeSlice(hash)
@ -252,11 +252,10 @@ Transaction.prototype.hashTransactionForSignature =
return crypto.hash256(buffer) return crypto.hash256(buffer)
} }
Transaction.prototype.getHash = function () Transaction.prototype.getHash = function () {
{
var buffer = crypto.hash256(this.serialize()) var buffer = crypto.hash256(this.serialize())
// Little-endian is used for Transaction hash hex // Big-endian is used for TxHash
Array.prototype.reverse.call(buffer) Array.prototype.reverse.call(buffer)
return buffer.toString('hex') return buffer.toString('hex')
@ -313,7 +312,7 @@ Transaction.deserialize = function(buffer) {
for (var i = 0; i < vinLen; ++i) { for (var i = 0; i < vinLen; ++i) {
var hash = readSlice(32) var hash = readSlice(32)
// Hash is big-endian, we want little-endian for the hex // TxHash is little-endian, we want big-endian hex
Array.prototype.reverse.call(hash) Array.prototype.reverse.call(hash)
var vout = readUInt32() var vout = readUInt32()