Revert "bufferutils: remove equal, use Buffer.compare"

This reverts commit 75540b6116.
See discussion in https://github.com/bitcoinjs/bitcoinjs-lib/pull/410
This commit is contained in:
Wei Lu 2015-05-30 11:50:38 +08:00
parent f64df79555
commit d7019e7492
2 changed files with 13 additions and 2 deletions

View file

@ -168,6 +168,16 @@ function varIntBuffer (i) {
return buffer return buffer
} }
function equal (a, b) {
if (a.length !== b.length) return false
for (var i = 0; i < a.length; ++i) {
if (a[i] !== b[i]) return false
}
return true
}
function reverse (buffer) { function reverse (buffer) {
var buffer2 = new Buffer(buffer) var buffer2 = new Buffer(buffer)
Array.prototype.reverse.call(buffer2) Array.prototype.reverse.call(buffer2)
@ -175,6 +185,7 @@ function reverse (buffer) {
} }
module.exports = { module.exports = {
equal: equal,
pushDataSize: pushDataSize, pushDataSize: pushDataSize,
readPushDataInt: readPushDataInt, readPushDataInt: readPushDataInt,
readUInt64LE: readUInt64LE, readUInt64LE: readUInt64LE,

View file

@ -399,7 +399,7 @@ TransactionBuilder.prototype.sign = function (index, keyPair, redeemScript, hash
// enforce in order signing of public keys // enforce in order signing of public keys
assert(input.pubKeys.some(function (pubKey, i) { assert(input.pubKeys.some(function (pubKey, i) {
if (kpPubKey.compare(pubKey) !== 0) return false if (!bufferutils.equal(kpPubKey, pubKey)) return false
assert(!input.signatures[i], 'Signature already exists') assert(!input.signatures[i], 'Signature already exists')
@ -407,7 +407,7 @@ TransactionBuilder.prototype.sign = function (index, keyPair, redeemScript, hash
input.signatures[i] = signature input.signatures[i] = signature
return true return true
}), 'key pair cannot sign for this input') }, this), 'key pair cannot sign for this input')
} }
module.exports = TransactionBuilder module.exports = TransactionBuilder