tests: refactor multisig test construction

test/fixtures/transaction_builder.json

@@ -442,10 +442,10 @@
             "signs": [
               {
                 "pubKeyIndex": 2,
-                "privKey": "91avARGdfge8E4tZfYLoxeJ5sGBdNJQH4kvjJoQFacbgx3cTMqe",
+                "privKey": "91avARGdfge8E4tZfYLoxeJ5sGBdNJQH4kvjJoQFacbgx3cTMqe"
-                "removeOp0s": true
               },
               {
+                "filterOP_0": true,
                 "pubKeyIndex": 0,
                 "privKey": "91avARGdfge8E4tZfYLoxeJ5sGBdNJQH4kvjJoQFacbgwmaKkrx"
               }

test/transaction_builder.js

@@ -1,9 +1,11 @@
 /* global describe, it, beforeEach */
 
 var assert = require('assert')
+var ops = require('../src/opcodes')
+var scripts = require('../src/scripts')
+
 var Address = require('../src/address')
 var BigInteger = require('bigi')
-var bitcoin = require('../src')
 var ECKey = require('../src/eckey')
 var Script = require('../src/script')
 var Transaction = require('../src/transaction')
@@ -225,51 +227,44 @@ describe('TransactionBuilder', function () {
   describe('multisig', function () {
     fixtures.valid.multisig.forEach(function (f) {
       it(f.description, function () {
-        var signs = 0
+        construct(txb, f, false)
-        f.inputs.forEach(function (input) {
-          txb.addInput(input.txId, input.vout)
-          signs = Math.max(signs, input.signs.length)
-        })
-
-        f.outputs.forEach(function (output) {
-          txb.addOutput(Script.fromASM(output.script), output.value)
-        })
 
         var tx
 
-        for (var i = 0; i < signs; i++) {
+        f.inputs.forEach(function (input, i) {
+          var redeemScript = Script.fromASM(input.redeemScript)
+
+          input.signs.forEach(function (sign) {
+            // rebuild the transaction each-time after the first
             if (tx) {
+              // do we filter OP_0's beforehand?
+              if (sign.filterOP_0) {
+                var scriptSig = tx.ins[i].script
+
+                // ignore OP_0 on the front, ignore redeemScript
+                var signatures = scriptSig.chunks.slice(1, -1).filter(function(x) { return x !== ops.OP_0 })
+
+                // rebuild/replace the scriptSig without them
+                var replacement = scripts.scriptHashInput(scripts.multisigInput(signatures), redeemScript)
+                tx.ins[i].script = replacement
+              }
+
+              // now import it
               txb = TransactionBuilder.fromTransaction(tx)
             }
 
-          f.inputs.forEach(function (input, index) {
+            var privKey = ECKey.fromWIF(sign.privKey)
-            var privKey = bitcoin.ECKey.fromWIF(input.signs[i].privKey)
+            txb.sign(i, privKey, redeemScript, sign.hashType)
-            var redeemScript = bitcoin.Script.fromASM(input.redeemScript)
-            txb.sign(index, privKey, redeemScript)
-          })
 
+            // update the tx
             tx = txb.buildIncomplete()
 
-          f.inputs.forEach(function (input, index) {
+            // now verify the serialized transaction is as expected
-            assert(bitcoin.scripts.isCanonicalSignature(tx.ins[index].script.chunks[input.signs[i].pubKeyIndex + 1]))
+            if (sign.txHexIncomplete) {
-            assert(tx.ins[index].script.chunks.slice(1, -1).every(function (chunk) {
+              assert.equal(txb.buildIncomplete(), sign.txHexIncomplete)
-              return chunk === bitcoin.opcodes.OP_0 || bitcoin.scripts.isCanonicalSignature(chunk)
-            }))
-          })
-
-          // manually mess up the signatures
-          f.inputs.forEach(function (input, index) {
-            // remove all OP_0s
-            if (input.signs[i].removeOp0s) {
-              tx.ins[index].script.chunks = tx.ins[index].script.chunks.filter(function (chunk) {
-                return chunk !== bitcoin.opcodes.OP_0
-              })
-
-              // we removed one OP_0 too many, gotta add it back
-              tx.ins[index].script.chunks.unshift(bitcoin.opcodes.OP_0)
             }
           })
-        }
+        })
 
         assert.equal(tx.toHex(), f.txHexIncomplete, 'txHexIncomplete')