Commit graph

760 commits

Author SHA1 Message Date
Daniel Cousens 57b8afbdab Network: rename Network to Networks
This change removes the most common ambiguities.
As the network module is not representative of a class, the lower case
has been used.
2014-05-08 10:59:58 +10:00
Daniel Cousens 929b8d2b62 Script: more consistent input handling 2014-05-08 10:59:58 +10:00
Daniel Cousens 7ad695e427 Script: fix assertion message grammar 2014-05-08 10:59:58 +10:00
Daniel Cousens 74e53b49a5 Script/Transaction: remove untested functions
These functions are not under test, and are unnecessary bloat due to a
confusing API.

Script.from*(asmStr) were two functions that attempted to parse ASM
codes and produce a script from this.
While useful, an parser can be introduced later under a single function
and under test... removed.

Although Script.extractPublicKeys implementation is likely to be correct,
it is not absolute in that what it returns is even strictly a set of
public keys.
It is a useful function, but can be done in a better way later,
probably checking against the Script templates instead.

Transaction.signWithKeys has some inherent undocumented behaviour, and it is not
clear when you would use it over just Transaction.addOutput and
Transaction.sign individually.  Nor does it mimic anything in the
bitcoind API... removed.
2014-05-08 10:59:58 +10:00
Daniel Cousens 76323a07d0 Transaction: restrict TxIn/TxOut constructor params
To keep this change minimal, both TxIn/TxOut still use the parameter
object for initialization.  TxOut accepts only the types it uses
internally, and not hex or byte arrays for scripts.

The clone is unnecessary as a TransactionOut is never mutated after its
creation.

This resulted in TransactionOut.scriptPubKey no longer being needed,
and was removed.  To access the scriptPubKey as a byte buffer, a user
can simply use:

	TransactionOut.script.toBuffer()

Unfortunately, this leaves TransactionOut in a sorry state of test.
Something that needs to be fixed.
2014-05-08 10:59:58 +10:00
Daniel Cousens 9a7e291d70 Transaction: fix incorrect outIndex type 2014-05-08 08:52:07 +10:00
Wei Lu bd2a6db260 Merge pull request #172 from dcousens/ext159
Extends #159 to further verify behaviour
2014-05-08 01:01:44 +08:00
Daniel Cousens 63231fb67d Extends test for custom Wallet change addresses 2014-05-06 15:40:40 +10:00
Daniel Cousens a77846701f Fixes network support for TxOut 2014-05-06 15:40:40 +10:00
Daniel Cousens 4012b82bec Fixes Transaction.addOutput(Address, Number) 2014-05-06 15:40:40 +10:00
Daniel Cousens 695eb64a3a Clarifies Transaction.addOutput param documentation 2014-05-06 15:40:40 +10:00
Daniel Cousens eba08fa761 Fixes indentation for assertions 2014-05-06 15:40:40 +10:00
Daniel Cousens d65a3c36e2 Merge pull request #159 from williamcotton/master
fixed issues with testnet and createTx
2014-05-06 08:04:02 +10:00
Wei Lu e59f824c3a move fixture sync script into fixtures folder
Also fixes require paths & dev dependency
2014-05-05 13:46:00 +08:00
Wei Lu 5deab5188f Merge pull request #170 from dcousens/bufferx
BufferExt and Transaction serialization to use Buffers
2014-05-05 12:40:51 +08:00
Daniel Cousens baa568697b Transaction.deserialize no longer mutates input 2014-05-05 09:11:37 +10:00
Daniel Cousens 02013beda9 Renames variables to be more verbose 2014-05-05 09:11:37 +10:00
Daniel Cousens b860daf70b Corrects endianness comments 2014-05-04 17:31:47 +10:00
Daniel Cousens 87048d3b4e Adds performance notes 2014-05-04 17:31:47 +10:00
Daniel Cousens 4716eb29bf Removes redundant convert functions 2014-05-04 17:31:47 +10:00
Daniel Cousens a8cf2fdd9e Changes internal serialization to use Buffers instead 2014-05-04 17:31:22 +10:00
Daniel Cousens c8bda6dde6 Adds Buffer extensions 2014-05-04 17:30:59 +10:00
Wei Lu 69f88a7404 add integration test script 2014-05-04 14:25:34 +08:00
Wei Lu 33b73517fe fixes integration test dependency paths 2014-05-04 14:23:40 +08:00
Daniel Cousens 10ee5532c3 Serialize now returns a buffer 2014-05-04 15:37:25 +10:00
Daniel Cousens d17f85f5a6 Changes fakeTxHash to actual hex 2014-05-04 15:37:25 +10:00
Daniel Cousens 09c6a787d9 Changes sequence number to an actual Number 2014-05-04 15:37:25 +10:00
Wei Lu 752aeae0d3 update integration test descriptions 2014-05-04 13:35:11 +08:00
Wei Lu 2affeda3f4 Restructure integration and coretests
Also update test script to pick up only tests directly under /test
2014-05-04 13:30:11 +08:00
Daniel Cousens 633b8f28d2 Fixes incorrect PubKey hex constant 2014-05-04 15:15:22 +10:00
Wei Lu ba273db70f Merge pull request #162 from sidazhang/master
Adding integration tests
2014-05-04 13:05:04 +08:00
Daniel Cousens 02691098de Stretches test for derive m/0 from xpub 2014-05-04 12:14:33 +10:00
Wei Lu a830e2cded Merge pull request #168 from dcousens/167fix
Fixes #167
2014-05-04 10:11:19 +08:00
Daniel Cousens ff08c2eec3 Fixes #167 and adds temporary test 2014-05-04 12:07:05 +10:00
Daniel Cousens e6a9186af3 Removes unnecessary new Buffer 2014-05-04 11:58:06 +10:00
Daniel Cousens e2e190c766 Variables names made consistent with constructor 2014-05-04 11:57:49 +10:00
Daniel Cousens bb80eda218 Merge pull request #165 from bitcoinjs/bigi-monkey-patching-no-more
Upgrade bigi & remove monkey patching
2014-05-04 07:39:19 +10:00
Daniel Cousens 763e7376e9 Merge pull request #166 from bitcoinjs/remove-isfinite-check
Remove Number.isFinite check on tx input index
2014-05-04 07:28:56 +10:00
Wei Lu 1e6b283f9a Remove Number.isFinite check on tx input index 2014-05-03 10:19:38 +08:00
Wei Lu af1f121fd4 upgrade bigi & remove monkey patching 2014-05-03 10:04:54 +08:00
Wei Lu 39516d5532 Merge pull request #163 from dcousens/wordass
Enforces convert.wordsToBytes to only allow for byte input
2014-04-30 08:49:05 +08:00
Daniel Cousens 8b47d944b9 Merge pull request #164 from coinpunk/altcoinnetwork
Fix address prefixes, add dogecoin/litecoin BIP32 versions
2014-04-30 08:13:25 +10:00
Kyle Drake 5fd9fe62dc Fix address prefixes, add dogecoin/litecoin BIP32 versions 2014-04-29 15:07:15 -07:00
Daniel Cousens 77747241d4 Fixes exception typo 2014-04-30 05:10:02 +10:00
Daniel Cousens b09dd73cbe Enforces bytesToWordArray only operates on byte arrays 2014-04-30 05:07:41 +10:00
sidazhang fe4332bfbd integration tests for scripthash transcations 2014-04-27 10:50:39 -07:00
Daniel Cousens 953223c818 Merge pull request #160 from bitcoinjs/signScriptSig-test
Fixes signScriptSig test
2014-04-26 21:44:11 +10:00
Wei Lu 70219c877b Fixes signScriptSig test 2014-04-26 13:39:26 +08:00
Wei Lu 45c1c8350e Merge pull request #154 from dcousens/convrem
Remove dead code from Convert module
2014-04-26 12:27:08 +08:00
Wei Lu 6833acaf3a Merge pull request #152 from dcousens/p2shsign
Preliminary test for P2shsign
2014-04-26 12:26:50 +08:00