Commit graph

825 commits

Author SHA1 Message Date
Daniel Cousens
a17a5b23d9 ec: fix point decoding for other curves 2014-05-22 12:33:47 +10:00
Daniel Cousens
5ec9504ed6 ecdsa: opt for shiftRight, pow and square
In the given situations, these offer better readability, or in the case
of shiftRight, a substantial performance increase.
2014-05-22 12:33:47 +10:00
Daniel Cousens
7d89ff427c ecdsa: comment cleanup 2014-05-22 12:33:47 +10:00
Daniel Cousens
0865f09d20 ec/dsa: extract P_OVER_FOUR as a curve specific constant
This actually resolves a possible bug if multiple ecparams were used
(aka different values for P_OVER_FOUR, but only the cached was used).
2014-05-22 12:33:47 +10:00
Daniel Cousens
1e54c521d5 ec: extract BigInteger constants 2014-05-22 12:33:47 +10:00
Daniel Cousens
d9ce4bee6b ec: use signum() not equals(BigInteger.ZERO) 2014-05-22 12:33:47 +10:00
Daniel Cousens
d14b08efd1 ec/dsa: recovery param now used consistently
Also added an assertion rather than massaging the input.
2014-05-22 12:32:28 +10:00
Wei Lu
aafbe46b35 Merge pull request #181 from dcousens/mesnet
Message signing and altcoins
2014-05-19 00:12:42 +10:00
Wei Lu
fe5ac4dde2 Merge pull request #180 from dcousens/eckey1
ECKey WIF only
2014-05-19 00:10:58 +10:00
Daniel Cousens
24371425f9 ec: decodeFrom now uses Buffers and handles errors 2014-05-18 17:52:49 +10:00
Daniel Cousens
a3f691bf7c ecdsa: parseSigCompact use Buffer API
parseSigCompact also now returns the correct recovert parameter without
the need to subtract the compression bit.
This makes it easier to use.
2014-05-18 17:52:49 +10:00
Daniel Cousens
f7c7265d64 ecdsa: parseSig now uses buffer API 2014-05-18 17:52:49 +10:00
Daniel Cousens
ccca6989b5 ec: getEncoded now uses Buffer API 2014-05-18 17:52:49 +10:00
Daniel Cousens
db3ffe58d1 message: use serializeSigCompact 2014-05-18 17:52:49 +10:00
Daniel Cousens
1c76bdf9c3 ec: add better test vectors for ECPointFp encode/decode
These test vectors were generated internally.
2014-05-18 17:52:49 +10:00
Daniel Cousens
4c7108d561 ecdsa: add serializeSigCompact and tests
This also adds tests for all other ECDSA serialize/parsing functions.
The k, r, s and D values were sourced from test vectors on
https://bitcointalk.org/index.php?topic=285142.40 .

The compact signatures (aka, i values) were generated from bitcoinjslib, but they
are straight forward anyway.
2014-05-18 17:52:49 +10:00
Daniel Cousens
b208a6ab78 crypto/ecdsa: moves HmacSHA256 to crypto 2014-05-18 17:52:49 +10:00
Daniel Cousens
99a1b7274c Transaction: use the type embedded in the signature 2014-05-18 17:52:48 +10:00
Daniel Cousens
6eb167b2c8 message: remove unnecessary tests 2014-05-18 17:51:36 +10:00
Daniel Cousens
87567e008a message: use base64 for signature data 2014-05-18 17:51:36 +10:00
Daniel Cousens
6b5990c6e2 message: support alternate networks 2014-05-18 17:51:36 +10:00
Daniel Cousens
dc69162757 message: remove signing verification
The signature verifications here are unnecessary, as this
is not what is under test.
2014-05-18 17:51:36 +10:00
Daniel Cousens
10fe4474d1 ECKey: remove *Buffer/*Hex functions
An ECKey is a composition of a private key (D), a public key (Q) and its
compression flag.

These functions gave the impression of serialization of this
composition, when really they only serialized `D`.
They have therefore been removed in favour of always using a sane
serialization format (WIF) that matches the needed behaviour.

If a user needs the previous functionality, simply use `privKey.D.*`
instead of `privKey.*`, as BigInteger supports `*Buffer/*Hex` functions
as expected.
2014-05-18 17:50:10 +10:00
Daniel Cousens
bf109f32a9 ECPubKey: improve tests and extract test data to fixtures
The use of fixtures allows for more behavioural driven tests and simpler
addition of more test cases in future.

However, as ECPubKey is just a wrapper around other strenuously tested
modules, the test data is currently limited to testing a subset of the
total wrapper.

This should probably be done better by using mocked out modules instead.
2014-05-18 17:50:10 +10:00
Wei Lu
cf39de4035 Merge pull request #179 from dcousens/txscript
Transaction function naming and ordering
2014-05-18 07:58:20 +08:00
Daniel Cousens
0468c4710c Transaction: rename (de)serialize to [to/from]Buffer 2014-05-17 00:09:13 +10:00
Daniel Cousens
e033a872c9 Transaction: rename hashTransactionForSignature to hashForSignature 2014-05-17 00:09:13 +10:00
Daniel Cousens
55681e7e5d Script: use PubKey objects not prebuilt Buffers 2014-05-17 00:09:13 +10:00
Daniel Cousens
54cc123d31 Address/Script: consistent function ordering 2014-05-17 00:09:13 +10:00
Daniel Cousens
842b075e75 Address: consistent json formatting 2014-05-17 00:09:13 +10:00
Daniel Cousens
39d042d058 syncscript: general cleanup 2014-05-17 00:09:12 +10:00
Daniel Cousens
1e0521f7e5 Merge pull request #178 from bitcoinjs/integration-tests
Integration tests
2014-05-14 08:56:08 +10:00
Wei Lu
8063979d99 fix integration test 2014-05-13 22:03:11 +08:00
Wei Lu
a71685658b add integration build to travis 2014-05-13 22:03:11 +08:00
Daniel Cousens
b99ed46796 opcodes: rename to opcodes 2014-05-13 23:14:07 +10:00
Daniel Cousens
f9782b7c17 opcodes: remove unused reverseMap 2014-05-13 23:12:30 +10:00
Wei Lu
e835a6264d Merge pull request #177 from dcousens/opclean
OPcodes cleanup
2014-05-13 19:53:53 +08:00
Daniel Cousens
554ba250b9 opcode: less redundant indentation 2014-05-13 18:53:30 +10:00
Daniel Cousens
1fe8282eda Script: remove redundant opcode.map access 2014-05-13 18:53:30 +10:00
Wei Lu
9cd34f50d5 Merge pull request #176 from dcousens/rename
Project structure cleanup
2014-05-13 16:14:50 +08:00
Daniel Cousens
6c0eebe94b tests: use filepaths directly
After a long IRC discussion, it was decided that the use of direct
filepaths instead of the module is a more pure form of testing ,
although it may provide less overall coverage than the mixed integration
style imports used previously.

This will need to be remedied by further integration testing in
/test/integration.
2014-05-13 18:05:56 +10:00
Daniel Cousens
e27c97a791 ECPubKey/ECKey: separate to two files 2014-05-13 16:51:06 +10:00
Daniel Cousens
05e0d08098 BufferExt: rename to bufferutils 2014-05-13 16:46:12 +10:00
Daniel Cousens
7a740c2e7b tests: forces consistent import syntax 2014-05-13 16:46:08 +10:00
Wei Lu
7cac39633c Merge pull request #175 from dcousens/cryptoHmac
Consolidation of crypto functions
2014-05-13 09:46:27 +08:00
Wei Lu
1840f99c34 Merge pull request #174 from dcousens/hdbipad
HDWallet BIP32 adherence
2014-05-13 08:46:50 +08:00
Daniel Cousens
276a339d60 crypto: HMACSHA512 into crypto and add tests 2014-05-12 10:18:39 +10:00
Daniel Cousens
f70ccc9215 convert: remove hex functions 2014-05-12 10:17:38 +10:00
Daniel Cousens
614a213d44 Transaction: remove untested hash array support 2014-05-12 10:17:38 +10:00
Daniel Cousens
063643b4a1 HDWallet: show clearer BIP32 adherence for Master key 2014-05-12 09:56:00 +10:00