Commit graph

9 commits

Author SHA1 Message Date
Daniel Cousens
2b2081bed9 base58check: buffers only, remove explicit 0
Undefined is treated as zero if it ever gets to this point anyway, so no
value is added by having this default param here.

A test fixture to verify this behaviour is added.
2014-05-31 15:05:33 +10:00
Daniel Cousens
2fc69b0834 address/base58check: fix missing exceptions/tests
All the `invalid2` tests have been removed as they were not invalid
base58check.  They were actually valid in some cases.
They will be re-integrated in more specific bitcoin core tests in
relation to Address/ECKey respectively.
2014-05-29 14:43:44 +10:00
Daniel Cousens
b2351f9026 tests: use JSON fixtures exclusively 2014-05-24 00:52:24 +10:00
Daniel Cousens
6c0eebe94b tests: use filepaths directly
After a long IRC discussion, it was decided that the use of direct
filepaths instead of the module is a more pure form of testing ,
although it may provide less overall coverage than the mixed integration
style imports used previously.

This will need to be remedied by further integration testing in
/test/integration.
2014-05-13 18:05:56 +10:00
Daniel Cousens
7a740c2e7b tests: forces consistent import syntax 2014-05-13 16:46:08 +10:00
Daniel Cousens
c178804356 Updates test fixtures to use bitcoin core test data 2014-04-22 00:24:20 +10:00
Daniel Cousens
1bcc7cfd95 Adds shared base58 test vectors 2014-04-22 00:24:02 +10:00
Daniel Cousens
c93bad3be1 Fixes actual/expected parameter ordering 2014-04-07 05:04:49 +10:00
Daniel Cousens
f53b821cc9 Isolates Base58Check encoding from Base58 code/tests 2014-04-03 19:45:05 +11:00