LBRYCommunity/block-explorer
1
0
Fork 0
Code Issues 31 Pull requests 4 Projects Releases Packages Wiki Activity

Use Chainquery #28

New issue
Closed
opened 2018-07-20 15:07:35 +02:00 by kauffj · 6 comments
kauffj commented 2018-07-20 15:07:35 +02:00 (Migrated from github.com)
Copy link

chainquery ought to make the explorer easier to work with/use and simpler to maintain (if doesn't do that, that is also useful feedback for chainquery).

[chainquery](https://github.com/lbryio/chainquery) ought to make the explorer easier to work with/use and simpler to maintain (if _doesn't_ do that, that is also useful feedback for chainquery).
marcdeb1 commented 2018-12-15 18:14:27 +01:00 (Migrated from github.com)
Copy link

I am ready to take up the task, it could make the explorer much simpler and solve issues such as #8 or #31 that seem to be due to the block syncing process. As @tiger5226 suggested, there could be a direct DB connection to Chainquery.

I am ready to take up the task, it could make the explorer much simpler and solve issues such as #8 or #31 that seem to be due to the block syncing process. As @tiger5226 suggested, there could be a direct DB connection to Chainquery.
tiger5226 commented 2018-12-16 05:45:56 +01:00 (Migrated from github.com)
Copy link

I can setup the credentials for you. Ultimately, the block explorer is a great candidate to integrate with Chainquery. It was actually what I started from for Chainquery. So it should be a very close match on the schema. I would not expect many differences.

I can setup the credentials for you. Ultimately, the block explorer is a great candidate to integrate with Chainquery. It was actually what I started from for Chainquery. So it should be a very close match on the schema. I would not expect many differences.
tiger5226 commented 2018-12-16 05:52:40 +01:00 (Migrated from github.com)
Copy link

@marcdeb1 Testing credentials for Chainquery have been sent over. When we are ready to deploy we can setup a production account for the explorer.

@marcdeb1 Testing credentials for Chainquery have been sent over. When we are ready to deploy we can setup a production account for the explorer.
marcdeb1 commented 2018-12-18 14:24:18 +01:00 (Migrated from github.com)
Copy link

The block explorer API is using different fields from Chainquery:
image
I would suggest to standardize the attributes and put the same as Chainquery (InputCount -> input_count), but since some people might use the API it could be a problem. What do you think ? Stay like before or change ?

The block explorer API is using different fields from Chainquery: ![image](https://user-images.githubusercontent.com/29503179/50156941-60ae4e80-02d0-11e9-9202-58531151a431.png) I would suggest to standardize the attributes and put the same as Chainquery (InputCount -> input_count), but since some people might use the API it could be a problem. What do you think ? Stay like before or change ?
tiger5226 commented 2018-12-18 15:57:50 +01:00 (Migrated from github.com)
Copy link

It would be nice if we aligned across the organization. Chainquery schema in the standard now, so we should probably align on that. I think currently let's not break an api's but we should create an issue to address this with a long term solution that could include api versioning. Ultimately, block information should just come from chainquery api's. So we will probably want to deprecate the apis from the block explorer altogether. Block explorer should just be a pretty ui for chainquery data.

It would be nice if we aligned across the organization. Chainquery schema in the standard now, so we should probably align on that. I think currently let's not break an api's but we should create an issue to address this with a long term solution that could include api versioning. Ultimately, block information should just come from chainquery api's. So we will probably want to deprecate the apis from the block explorer altogether. Block explorer should just be a pretty ui for chainquery data.
tiger5226 commented 2019-03-19 03:21:40 +01:00 (Migrated from github.com)
Copy link

Solved with Chainquery integration

Solved with Chainquery integration
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/composer/composer/composer-2.2.22
dependabot/composer/twig/twig-1.44.7
marcdeb1/new-explorer
more-content-fix
fix_ci
fix-utxosupply
blocked-claims
crash-fix
fix-dupes
claim-id-null-fix
cache2
cache
hot-wallet
tx-claim-link
documentation
diff
imgsrc-fix
add-addresses
Mooore
No results found.
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
php

Pull requests that update Php code

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
php
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/block-explorer#28
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?