LBRYCommunity/block-explorer
1
0
Fork 0
Code Issues 31 Pull requests 4 Projects Releases Packages Wiki Activity

# of confirmations not calculated correctly #57

New issue
Open
opened 2019-02-25 02:04:58 +01:00 by tzarebczan · 5 comments
tzarebczan commented 2019-02-25 02:04:58 +01:00 (Migrated from github.com)
Copy link

It shows 1 confirmation on block and transaction pages.

It shows 1 confirmation on block and transaction pages.
tzarebczan commented 2019-03-25 14:27:03 +01:00 (Migrated from github.com)
Copy link

@akinwale / @nikooo777 you think you'd be able to take a look at this one soon? Community members are noticing it as well.

@akinwale / @nikooo777 you think you'd be able to take a look at this one soon? Community members are noticing it as well.
tiger5226 commented 2019-03-25 22:28:22 +01:00 (Migrated from github.com)
Copy link

So we no longer keep old transactions that are not included in the leading chain. They are cleared. So technically we only have to take current height or max block height and subtract the height of the block in question. I have this in my @tzarebczan if they cannot get to it. I should have the ppv completed tonight. So I can probably make this one the next highest priority.

So we no longer keep old transactions that are not included in the leading chain. They are cleared. So technically we only have to take current height or max block height and subtract the height of the block in question. I have this in my @tzarebczan if they cannot get to it. I should have the ppv completed tonight. So I can probably make this one the next highest priority.
tzarebczan commented 2019-06-03 22:28:51 +02:00 (Migrated from github.com)
Copy link

Looks like we had a fix, which worked for some, but if you look at https://explorer.lbry.com/address/bSSfLmehtc3PsDoj1ZDNmYkTbrNiTPj2CW the confirmations are not shown correctly on the top blocks.

Looks like we had a fix, which worked for some, but if you look at https://explorer.lbry.com/address/bSSfLmehtc3PsDoj1ZDNmYkTbrNiTPj2CW the confirmations are not shown correctly on the top blocks.
tiger5226 commented 2019-06-04 04:22:37 +02:00 (Migrated from github.com)
Copy link

Also the block page does show the right confirmation. Its just this list apparently.

Also the block page does show the right confirmation. Its just this list apparently.
akinwale commented 2019-06-05 17:36:57 +02:00 (Migrated from github.com)
Copy link

The old fix from 667097f35d (diff-84d5d8e3196d5767f5a47b5871946dddR598) can be adapted for this.

Essentially, we just need to obtain the max block height and then subtract the height of the corresponding transaction from the max height.

The old fix from https://github.com/lbryio/block-explorer/commit/667097f35d81e034b3130a5032d8f05461677b10#diff-84d5d8e3196d5767f5a47b5871946dddR598 can be adapted for this. Essentially, we just need to obtain the max block height and then subtract the height of the corresponding transaction from the max height.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/composer/composer/composer-2.2.22
dependabot/composer/twig/twig-1.44.7
marcdeb1/new-explorer
more-content-fix
fix_ci
fix-utxosupply
blocked-claims
crash-fix
fix-dupes
claim-id-null-fix
cache2
cache
hot-wallet
tx-claim-link
documentation
diff
imgsrc-fix
add-addresses
Mooore
No results found.
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
php

Pull requests that update Php code

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
php
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/block-explorer#57
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?