LBRYCommunity/coinbin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Error in serialization for nLockTime values

Browse source 
if nLockTime is 1234(decimal) -> thats 4D2(hex) -> The current code splits it beginning from the end into bytes -> [4d, 02], but it should be [4, d2].

Error only occurs if one of the bytes is <16
This commit is contained in:
Daniel Weigl 2016-07-03 19:22:23 +02:00
parent cad1f6e98b
commit 3ba79f0e3d
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
js/coin.js
View file

@ -148,7 +148,7 @@
} }
var s = coinjs.script(); var s = coinjs.script();
s.writeBytes(Crypto.util.hexToBytes(checklocktimeverify.toString(16)).reverse()); s.writeBytes(coinjs.numToByteArray(checklocktimeverify).reverse());
s.writeOp(177);//OP_CHECKLOCKTIMEVERIFY s.writeOp(177);//OP_CHECKLOCKTIMEVERIFY
s.writeOp(117);//OP_DROP s.writeOp(117);//OP_DROP
s.writeBytes(Crypto.util.hexToBytes(pubkey)); s.writeBytes(Crypto.util.hexToBytes(pubkey));
@ -687,7 +687,7 @@
// ^ <unlocktime> OP_CHECKLOCKTIMEVERIFY OP_DROP <pubkey> OP_CHECKSIG ^ // ^ <unlocktime> OP_CHECKLOCKTIMEVERIFY OP_DROP <pubkey> OP_CHECKSIG ^
r = {} r = {}
r.pubkey = Crypto.util.bytesToHex(s.chunks[3]); r.pubkey = Crypto.util.bytesToHex(s.chunks[3]);
r.checklocktimeverify = parseInt(Crypto.util.bytesToHex(s.chunks[0].slice().reverse()), 16); r.checklocktimeverify = coinjs.bytesToNum(s.chunks[0].slice().reverse());
r.address = coinjs.simpleHodlAddress(r.pubkey, r.checklocktimeverify).address; r.address = coinjs.simpleHodlAddress(r.pubkey, r.checklocktimeverify).address;
r.type = "hodl__"; r.type = "hodl__";
} }
@ -1454,6 +1454,14 @@
} }
} }
coinjs.numToByteArray = function(num) {
if (num <= 256) {
return [num];
} else {
return [num % 256].concat(coinjs.numToByteArray(Math.floor(num / 256)));
}
}
coinjs.numToVarInt = function(num) { coinjs.numToVarInt = function(num) {
if (num < 253) { if (num < 253) {
return [num]; return [num];