remove z-index on checkbox toggle #8

Merged

neb-b merged 1 commit from z-index into master

2019-04-29 18:05:42 +02:00

neb-b commented

2019-04-28 19:56:36 +02:00

(Migrated from github.com)

Change

Removed z-index: 5 from the tick-toggle mixin

Why

It doesn't make sense for an input element to have an arbitrary z-index value. The desktop app has a pretty simple z-index range: 1 (main content), 2 (header), 9999 (modals), but the checkbox is still visible inside the header after scrolling

If something requires a z-index inside of .com or .tech it should use a custom class, to make the input components as reusable as possible.

### Change - Removed `z-index: 5` from the `tick-toggle` mixin #### Why It doesn't make sense for an input element to have an arbitrary z-index value. The desktop app has a pretty simple z-index range: `1 (main content), 2 (header), 9999 (modals)`, but the checkbox is still visible inside the header after scrolling <img width="538" alt="Screen Shot 2019-04-28 at 1 50 02 PM" src="https://user-images.githubusercontent.com/16882830/56868165-b6041600-69bc-11e9-8c4d-1cf94e25c1c6.png"> If something requires a z-index inside of .com or .tech it should use a custom class, to make the input components as reusable as possible.

NetOpWibby (Migrated from github.com) reviewed 2019-04-28 19:56:36 +02:00

No reviewers

NetOpWibby

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/components#8

No description provided.