BIP-34 handling doesn't work correctly #1

New issue

Open

opened 2020-04-01 19:38:16 +02:00 by BrannonKing · 0 comments

BrannonKing commented

2020-04-01 19:38:16 +02:00

(Migrated from github.com)

If you set the "coinbase-addr" parameter, cpuminer should not pass coinbasetxn to getblocktemplate. That's bug 1.

Bug 2 is that if there is no coinbasetxn return on getblocktemplate (like in lbrycrd v19, which doesn't support it) then the block submission fails with "bad-cb-height". This is easier to test on testnet or regtest where you can toy with the BIP34 settings in chainparams.cpp.

If you set the "coinbase-addr" parameter, cpuminer should not pass coinbasetxn to getblocktemplate. That's bug 1. Bug 2 is that if there is no coinbasetxn return on getblocktemplate (like in lbrycrd v19, which doesn't support it) then the block submission fails with "bad-cb-height". This is easier to test on testnet or regtest where you can toy with the BIP34 settings in chainparams.cpp.