Catchup to python-herald schema. Plus lots of refactoring. #49

Merged
moodyjon merged 18 commits from schema_catchup into master 2022-08-16 07:45:42 +02:00
moodyjon commented 2022-08-10 16:59:58 +02:00 (Migrated from github.com)

Fixes #46

Still debugging a test. Need to add test data for new tables.

Fixes #46 Still debugging a test. Need to add test data for new tables.
jeffreypicard (Migrated from github.com) reviewed 2022-08-10 16:59:58 +02:00
moodyjon commented 2022-08-10 19:32:14 +02:00 (Migrated from github.com)

I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS.

I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS.
jeffreypicard commented 2022-08-10 20:23:10 +02:00 (Migrated from github.com)

I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS.

Do you have access to a linux vps or something that you can commit those on?

> I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS. Do you have access to a linux vps or something that you can commit those on?
jeffreypicard commented 2022-08-10 20:24:06 +02:00 (Migrated from github.com)

Also, I don't think we want to commit that .DS_Store file.

Also, I don't think we want to commit that .DS_Store file.
moodyjon commented 2022-08-11 20:07:39 +02:00 (Migrated from github.com)

I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS.

Do you have access to a linux vps or something that you can commit those on?

I had moved the working dir to a special case-sensitive volume a while back once I discovered the issue.
What remained to be done was changing the .git/config to contain core.ignorecase = false
Test data is there now.

> > I have testdata f.csv and g.csv, but currently can't "git add" them as there is an issue with case-insensitivity on MacOS. > > Do you have access to a linux vps or something that you can commit those on? I had moved the working dir to a special case-sensitive volume a while back once I discovered the issue. What remained to be done was changing the .git/config to contain `core.ignorecase = false` Test data is there now.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/herald.go#49
No description provided.