HashXHistoryValue problem with HashXes field type (and name) #53

Closed
opened 2022-08-25 22:49:53 +02:00 by moodyjon · 0 comments
moodyjon commented 2022-08-25 22:49:53 +02:00 (Migrated from github.com)

Found a problem with HashXHistoryValue field HashXes type (and name). It is []uint16 right now, and should be []uint32.

Python:
fc38bda03c/hub/db/prefixes.py (L60)

Talked with @jackrobison and the field name is misleading. It is a "tx num" type uint32 elsewhere called TxNum.

Found a problem with `HashXHistoryValue` field `HashXes` type (and name). It is `[]uint16` right now, and should be `[]uint32`. Python: https://github.com/lbryio/hub/blob/fc38bda03ca3f7707a394cb60014925619d5524a/hub/db/prefixes.py#L60 Talked with @jackrobison and the field name is misleading. It is a "tx num" type uint32 elsewhere called `TxNum`.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/herald.go#53
No description provided.