JSON RPC compatibility workarounds to support lbry-sdk #75
No reviewers
Labels
No labels
consider soon
documentation
good first issue
hacktoberfest
help wanted
priority: blocker
priority: high
priority: low
priority: medium
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/herald.go#75
Loading…
Reference in a new issue
No description provided.
Delete branch "jsonrpc_compat1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Note
--json-rpc-port=50002
. Lots of tests use that port number when launching herald apparently:go build -o herald . && ./herald serve --disable-es --json-rpc-port=50002 --json-rpc-http-port=0 --db-path /Users/swdev1/hub/scribe_db.1030239/lbry-rocksdb --session-timeout=15 --max-sessions=5
With herald running, launch a test. The python herald will be blocked from reusing 50002 because go herald is already running:
python -m unittest -vv -k test_repost tests/integration/claims/test_claim_commands.py
Note test still fails because the 3rd RPC it tries to do is
server.peers.subscribe
.Other than the signal.go comment, this looks good.
@ -53,4 +52,1 @@
case <-shutdownRequestChannel:
log.Info("Shutdown requested. Already " +
"shutting down...")
}
I think this should actually stay. I identified the issue with the spamming when it's killed, which was using the stop.Ch() as the shutdownRequestChannel, keeping it as a second channel that could be used later on to possibly kill this from the outside still makes sense.