LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

rocksdb #29

Merged
jeffreypicard merged 93 commits from feature/27/jeffreypicard/rocksdb into master 2022-04-29 17:04:01 +02:00
Conversation 3 Commits 93 Files changed 96 +14 -12
2 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 2ee8c62d13 - Show all commits

2
Dockerfile.github
View file

@ -2,7 +2,7 @@ FROM golang:1.16.11-bullseye
RUN apt-get update && \
apt-get upgrade && \
apt-get install git libsnappy-dev liblz4-dev libzstd-dev zlib1g-dev
apt-get install -y dnsutils git libsnappy-dev liblz4-dev libzstd-dev zlib1g-dev
RUN git clone https://github.com/facebook/rocksdb.git && \
cd rocksdb && \
git checkout v6.26.1 && \

2
scripts/build_and_test.sh
View file

@ -1,3 +1,5 @@
#!/bin/bash
export CGO_LDFLAGS="-L/usr/local/lib -lrocksdb -lstdc++ -lm -lz -lsnappy -llz4 -lzstd"
lyoshenka commented 2022-04-15 16:12:22 +02:00 (Migrated from github.com)
Review
Copy link

do you see these changing often? id be careful cause diff versions of protoc could introduce cosmetic changes with big diffs that dont do much. i suggest that building protobufs should be a separate optional build step just for when they change

but if they change often, then its fine to leave it here

do you see these changing often? id be careful cause diff versions of `protoc` could introduce cosmetic changes with big diffs that dont do much. i suggest that building protobufs should be a separate optional build step just for when they change but if they change often, then its fine to leave it here
export CGO_CFLAGS="-I/usr/local/include/rocksdb"
go build .
go test -v -race ./...