LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

rocksdb #29

Merged
jeffreypicard merged 93 commits from feature/27/jeffreypicard/rocksdb into master 2022-04-29 17:04:01 +02:00
Conversation 3 Commits 93 Files changed 96 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 946826c25c - Show all commits

2
scripts/build_and_test.sh
View file

@ -1,4 +1,4 @@
#!/bin/bash #!/bin/bash
./protobuf/build.sh ./protobuf/build.sh
lyoshenka commented 2022-04-15 16:12:22 +02:00 (Migrated from github.com)
Review
Copy link

do you see these changing often? id be careful cause diff versions of protoc could introduce cosmetic changes with big diffs that dont do much. i suggest that building protobufs should be a separate optional build step just for when they change

but if they change often, then its fine to leave it here

do you see these changing often? id be careful cause diff versions of `protoc` could introduce cosmetic changes with big diffs that dont do much. i suggest that building protobufs should be a separate optional build step just for when they change but if they change often, then its fine to leave it here
go build . go build .
go test -v -race ./... go test -v -race -cover ./...