rocksdb #29

Merged
jeffreypicard merged 93 commits from feature/27/jeffreypicard/rocksdb into master 2022-04-29 17:04:01 +02:00
16 changed files with 951 additions and 10 deletions
Showing only changes of commit a2c35c8ace - Show all commits

1
.gitattributes vendored Normal file
View file

@ -0,0 +1 @@
lyoshenka commented 2022-01-17 15:31:24 +01:00 (Migrated from github.com)
Review

what are you using git-lfs for?

what are you using git-lfs for?
jeffreypicard commented 2022-01-17 16:18:50 +01:00 (Migrated from github.com)
Review

Oops, I need to remove this. Originally I was planning on use git-lfs when I was going to put binary files in there for testing. After switching to human readable csvs we don't need it.

Oops, I need to remove this. Originally I was planning on use git-lfs when I was going to put binary files in there for testing. After switching to human readable csvs we don't need it.
lyoshenka commented 2022-01-17 15:31:24 +01:00 (Migrated from github.com)
Review

what are you using git-lfs for?

what are you using git-lfs for?
jeffreypicard commented 2022-01-17 16:18:50 +01:00 (Migrated from github.com)
Review

Oops, I need to remove this. Originally I was planning on use git-lfs when I was going to put binary files in there for testing. After switching to human readable csvs we don't need it.

Oops, I need to remove this. Originally I was planning on use git-lfs when I was going to put binary files in there for testing. After switching to human readable csvs we don't need it.
resources/ filter=lfs diff=lfs merge=lfs -text
lyoshenka commented 2022-01-17 15:31:24 +01:00 (Migrated from github.com)
Review

what are you using git-lfs for?

what are you using git-lfs for?
jeffreypicard commented 2022-01-17 16:18:50 +01:00 (Migrated from github.com)
Review

Oops, I need to remove this. Originally I was planning on use git-lfs when I was going to put binary files in there for testing. After switching to human readable csvs we don't need it.

Oops, I need to remove this. Originally I was planning on use git-lfs when I was going to put binary files in there for testing. After switching to human readable csvs we don't need it.

1
.gitignore vendored Normal file
View file

@ -0,0 +1 @@
.idea/

View file

@ -1,5 +1,11 @@
FROM jeffreypicard/hub-github-env
COPY scripts/build_and_test.sh /build_and_test.sh
# COPY scripts/build_and_test.sh /build_and_test.sh
COPY . /hub
WORKDIR /hub
ENTRYPOINT ["/build_and_test.sh"]
ENV CGO_LDFLAGS "-L/usr/local/lib -lrocksdb -lstdc++ -lm -lz -lsnappy -llz4 -lzstd"
ENV CGO_CFLAGS "-I/usr/local/include/rocksdb"
ENV LD_LIBRARY_PATH /usr/local/lib
ENTRYPOINT ["scripts/build_and_test.sh"]

View file

@ -6,15 +6,57 @@ import (
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
"log"
)
func OpenDB(name string) {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
func OpenDB(name string) int {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
// Read db
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
opts := grocksdb.NewDefaultOptions()
db, err := grocksdb.OpenDb(opts, name)
ro := grocksdb.NewDefaultReadOptions()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
ro.SetFillCache(false)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
if err != nil {
log.Println(err)
}
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
log.Println(db.Name())
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
it := db.NewIterator(ro)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
defer it.Close()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
var i = 0
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
it.Seek([]byte("foo"))
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
for it = it; it.Valid() && i < 10; it.Next() {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
key := it.Key()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
value := it.Value()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
fmt.Printf("Key: %v Value: %v\n", key.Data(), value.Data())
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
key.Free()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
value.Free()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
i++
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
}
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
if err := it.Err(); err != nil {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
log.Println(err)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
}
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
return i
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
}
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
func OpenAndWriteDB(in string, out string) {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
// Read db
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
opts := grocksdb.NewDefaultOptions()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
db, err := grocksdb.OpenDb(opts, in)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
ro := grocksdb.NewDefaultReadOptions()
ro.SetFillCache(false)
if err != nil {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
log.Println(err)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
}
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
// Write db
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
opts.SetCreateIfMissing(true)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
db2, err := grocksdb.OpenDb(opts, out)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
wo := grocksdb.NewDefaultWriteOptions()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
defer db2.Close()
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
log.Println(db.Name())
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
log.Println(db2.Name())
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
it := db.NewIterator(ro)
lyoshenka commented 2022-03-24 22:40:15 +01:00 (Migrated from github.com)
Review

fyi this kind of stuff is usually done with sync.WaitGroup, but your way seems fine too

fyi this kind of stuff is usually done with sync.WaitGroup, but your way seems fine too
defer it.Close()
@ -25,6 +67,11 @@ func OpenDB(name string) {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
key := it.Key()
value := it.Value()
fmt.Printf("Key: %v Value: %v\n", key.Data(), value.Data())
lyoshenka commented 2022-03-24 22:29:05 +01:00 (Migrated from github.com)
Review

all these hashes should be chainhash.Hash type

all these hashes should be chainhash.Hash type
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
if err := db2.Put(wo, key.Data(), value.Data()); err != nil {
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
log.Println(err)
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
}
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
key.Free()
value.Free()
i++

lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.
lyoshenka commented 2022-03-24 22:26:17 +01:00 (Migrated from github.com)
Review

no need to start these with N

no need to start these with N
lyoshenka commented 2022-03-24 22:26:38 +01:00 (Migrated from github.com)
Review

and many of these are unused

and many of these are unused
lyoshenka commented 2022-03-24 22:34:50 +01:00 (Migrated from github.com)
Review

is this really no big deal? seems like an error to me but idk rocksdb

is this really no big deal? seems like an error to me but idk rocksdb
lyoshenka commented 2022-03-24 22:38:01 +01:00 (Migrated from github.com)
Review

typo: Famlies -> Families

typo: Famlies -> Families
lyoshenka commented 2022-03-24 22:41:04 +01:00 (Migrated from github.com)
Review

this can be unexported

this can be unexported
lyoshenka commented 2022-03-24 22:41:39 +01:00 (Migrated from github.com)
Review

still need this?

still need this?
lyoshenka commented 2022-03-24 22:43:06 +01:00 (Migrated from github.com)
Review

typo

typo
lyoshenka commented 2022-03-24 22:43:32 +01:00 (Migrated from github.com)
Review

👀

:eyes:
jeffreypicard commented 2022-03-24 23:32:48 +01:00 (Migrated from github.com)
Review

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.

I agree the "N" can go. I copied these all over from the Python. where I believe they are similarly unused, because I thought it might be the defacto documentation.
jeffreypicard commented 2022-03-24 23:39:47 +01:00 (Migrated from github.com)
Review
// Valid returns false only when an Iterator has iterated past either the
// first or the last key in the database.
func (iter *Iterator) Valid() bool {
	return C.rocksdb_iter_valid(iter.c) != 0
}

If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

``` // Valid returns false only when an Iterator has iterated past either the // first or the last key in the database. func (iter *Iterator) Valid() bool { return C.rocksdb_iter_valid(iter.c) != 0 } ``` If our iterator was to try to go off the end of the db, or the front if we're going backwards, we need to check this.

View file

@ -9,21 +9,21 @@ func TestOpenDB(t *testing.T) {
tests := []struct {
name string
want string
want int
}{
{
name: "Open a rocksdb database",
want: "",
want: 10,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
OpenDB("/mnt/d/data/wallet/lbry-rocksdb/")
got := ""
vals := OpenDB("../resources/tmp.db")
got := vals
if got != tt.want {
t.Errorf("got: %s, want: %s\n", got, tt.want)
t.Errorf("got: %d, want: %d\n", got, tt.want)
}
})
}

BIN
resources/tmp.db/000009.sst Normal file

Binary file not shown.

View file

1
resources/tmp.db/CURRENT Normal file
View file

@ -0,0 +1 @@
MANIFEST-000010

View file

@ -0,0 +1 @@
b6f61266-9f2d-4712-a981-584bd5d6e0b3

0
resources/tmp.db/LOCK Normal file
View file

278
resources/tmp.db/LOG Normal file
View file

@ -0,0 +1,278 @@
2021/12/07-06:33:06.538893 7fa74d2f6b00 RocksDB version: 6.26.1
2021/12/07-06:33:06.539006 7fa74d2f6b00 Git sha 4d57a393a8f1563c0dff1ff468756c23d89e3601
2021/12/07-06:33:06.539009 7fa74d2f6b00 Compile date 2021-11-18 14:47:16
2021/12/07-06:33:06.539025 7fa74d2f6b00 DB SUMMARY
2021/12/07-06:33:06.539027 7fa74d2f6b00 DB Session ID: N6J7EYOHEJZJCZ6TLCTO
2021/12/07-06:33:06.539047 7fa74d2f6b00 CURRENT file: CURRENT
2021/12/07-06:33:06.539048 7fa74d2f6b00 IDENTITY file: IDENTITY
2021/12/07-06:33:06.539050 7fa74d2f6b00 MANIFEST file: MANIFEST-000004 size: 57 Bytes
2021/12/07-06:33:06.539051 7fa74d2f6b00 SST files in ../resources/tmp.db dir, Total Num: 0, files:
2021/12/07-06:33:06.539052 7fa74d2f6b00 Write Ahead Log file in ../resources/tmp.db: 000005.log size: 440 ;
2021/12/07-06:33:06.539053 7fa74d2f6b00 Options.error_if_exists: 0
2021/12/07-06:33:06.539054 7fa74d2f6b00 Options.create_if_missing: 0
2021/12/07-06:33:06.539055 7fa74d2f6b00 Options.paranoid_checks: 1
2021/12/07-06:33:06.539055 7fa74d2f6b00 Options.flush_verify_memtable_count: 1
2021/12/07-06:33:06.539056 7fa74d2f6b00 Options.track_and_verify_wals_in_manifest: 0
2021/12/07-06:33:06.539056 7fa74d2f6b00 Options.env: 0x7fa74e2220c0
2021/12/07-06:33:06.539057 7fa74d2f6b00 Options.fs: Posix File System
2021/12/07-06:33:06.539058 7fa74d2f6b00 Options.info_log: 0x16847f0
2021/12/07-06:33:06.539058 7fa74d2f6b00 Options.max_file_opening_threads: 16
2021/12/07-06:33:06.539059 7fa74d2f6b00 Options.statistics: (nil)
2021/12/07-06:33:06.539060 7fa74d2f6b00 Options.use_fsync: 0
2021/12/07-06:33:06.539060 7fa74d2f6b00 Options.max_log_file_size: 0
2021/12/07-06:33:06.539061 7fa74d2f6b00 Options.max_manifest_file_size: 1073741824
2021/12/07-06:33:06.539061 7fa74d2f6b00 Options.log_file_time_to_roll: 0
2021/12/07-06:33:06.539062 7fa74d2f6b00 Options.keep_log_file_num: 1000
2021/12/07-06:33:06.539062 7fa74d2f6b00 Options.recycle_log_file_num: 0
2021/12/07-06:33:06.539063 7fa74d2f6b00 Options.allow_fallocate: 1
2021/12/07-06:33:06.539063 7fa74d2f6b00 Options.allow_mmap_reads: 0
2021/12/07-06:33:06.539064 7fa74d2f6b00 Options.allow_mmap_writes: 0
2021/12/07-06:33:06.539065 7fa74d2f6b00 Options.use_direct_reads: 0
2021/12/07-06:33:06.539065 7fa74d2f6b00 Options.use_direct_io_for_flush_and_compaction: 0
2021/12/07-06:33:06.539066 7fa74d2f6b00 Options.create_missing_column_families: 0
2021/12/07-06:33:06.539066 7fa74d2f6b00 Options.db_log_dir:
2021/12/07-06:33:06.539067 7fa74d2f6b00 Options.wal_dir:
2021/12/07-06:33:06.539067 7fa74d2f6b00 Options.table_cache_numshardbits: 6
2021/12/07-06:33:06.539068 7fa74d2f6b00 Options.WAL_ttl_seconds: 0
2021/12/07-06:33:06.539068 7fa74d2f6b00 Options.WAL_size_limit_MB: 0
2021/12/07-06:33:06.539069 7fa74d2f6b00 Options.max_write_batch_group_size_bytes: 1048576
2021/12/07-06:33:06.539069 7fa74d2f6b00 Options.manifest_preallocation_size: 4194304
2021/12/07-06:33:06.539070 7fa74d2f6b00 Options.is_fd_close_on_exec: 1
2021/12/07-06:33:06.539070 7fa74d2f6b00 Options.advise_random_on_open: 1
2021/12/07-06:33:06.539071 7fa74d2f6b00 Options.experimental_mempurge_threshold: 0.000000
2021/12/07-06:33:06.539073 7fa74d2f6b00 Options.db_write_buffer_size: 0
2021/12/07-06:33:06.539074 7fa74d2f6b00 Options.write_buffer_manager: 0x1683100
2021/12/07-06:33:06.539074 7fa74d2f6b00 Options.access_hint_on_compaction_start: 1
2021/12/07-06:33:06.539075 7fa74d2f6b00 Options.new_table_reader_for_compaction_inputs: 0
2021/12/07-06:33:06.539082 7fa74d2f6b00 Options.random_access_max_buffer_size: 1048576
2021/12/07-06:33:06.539082 7fa74d2f6b00 Options.use_adaptive_mutex: 0
2021/12/07-06:33:06.539083 7fa74d2f6b00 Options.rate_limiter: (nil)
2021/12/07-06:33:06.539084 7fa74d2f6b00 Options.sst_file_manager.rate_bytes_per_sec: 0
2021/12/07-06:33:06.539085 7fa74d2f6b00 Options.wal_recovery_mode: 2
2021/12/07-06:33:06.539085 7fa74d2f6b00 Options.enable_thread_tracking: 0
2021/12/07-06:33:06.539086 7fa74d2f6b00 Options.enable_pipelined_write: 0
2021/12/07-06:33:06.539086 7fa74d2f6b00 Options.unordered_write: 0
2021/12/07-06:33:06.539087 7fa74d2f6b00 Options.allow_concurrent_memtable_write: 1
2021/12/07-06:33:06.539088 7fa74d2f6b00 Options.enable_write_thread_adaptive_yield: 1
2021/12/07-06:33:06.539088 7fa74d2f6b00 Options.write_thread_max_yield_usec: 100
2021/12/07-06:33:06.539089 7fa74d2f6b00 Options.write_thread_slow_yield_usec: 3
2021/12/07-06:33:06.539089 7fa74d2f6b00 Options.row_cache: None
2021/12/07-06:33:06.539090 7fa74d2f6b00 Options.wal_filter: None
2021/12/07-06:33:06.539090 7fa74d2f6b00 Options.avoid_flush_during_recovery: 0
2021/12/07-06:33:06.539091 7fa74d2f6b00 Options.allow_ingest_behind: 0
2021/12/07-06:33:06.539092 7fa74d2f6b00 Options.preserve_deletes: 0
2021/12/07-06:33:06.539092 7fa74d2f6b00 Options.two_write_queues: 0
2021/12/07-06:33:06.539093 7fa74d2f6b00 Options.manual_wal_flush: 0
2021/12/07-06:33:06.539093 7fa74d2f6b00 Options.atomic_flush: 0
2021/12/07-06:33:06.539094 7fa74d2f6b00 Options.avoid_unnecessary_blocking_io: 0
2021/12/07-06:33:06.539094 7fa74d2f6b00 Options.persist_stats_to_disk: 0
2021/12/07-06:33:06.539095 7fa74d2f6b00 Options.write_dbid_to_manifest: 0
2021/12/07-06:33:06.539095 7fa74d2f6b00 Options.log_readahead_size: 0
2021/12/07-06:33:06.539096 7fa74d2f6b00 Options.file_checksum_gen_factory: Unknown
2021/12/07-06:33:06.539096 7fa74d2f6b00 Options.best_efforts_recovery: 0
2021/12/07-06:33:06.539097 7fa74d2f6b00 Options.max_bgerror_resume_count: 2147483647
2021/12/07-06:33:06.539097 7fa74d2f6b00 Options.bgerror_resume_retry_interval: 1000000
2021/12/07-06:33:06.539098 7fa74d2f6b00 Options.allow_data_in_errors: 0
2021/12/07-06:33:06.539099 7fa74d2f6b00 Options.db_host_id: __hostname__
2021/12/07-06:33:06.539100 7fa74d2f6b00 Options.max_background_jobs: 2
2021/12/07-06:33:06.539100 7fa74d2f6b00 Options.max_background_compactions: -1
2021/12/07-06:33:06.539101 7fa74d2f6b00 Options.max_subcompactions: 1
2021/12/07-06:33:06.539101 7fa74d2f6b00 Options.avoid_flush_during_shutdown: 0
2021/12/07-06:33:06.539102 7fa74d2f6b00 Options.writable_file_max_buffer_size: 1048576
2021/12/07-06:33:06.539102 7fa74d2f6b00 Options.delayed_write_rate : 16777216
2021/12/07-06:33:06.539103 7fa74d2f6b00 Options.max_total_wal_size: 0
2021/12/07-06:33:06.539103 7fa74d2f6b00 Options.delete_obsolete_files_period_micros: 21600000000
2021/12/07-06:33:06.539104 7fa74d2f6b00 Options.stats_dump_period_sec: 600
2021/12/07-06:33:06.539104 7fa74d2f6b00 Options.stats_persist_period_sec: 600
2021/12/07-06:33:06.539105 7fa74d2f6b00 Options.stats_history_buffer_size: 1048576
2021/12/07-06:33:06.539105 7fa74d2f6b00 Options.max_open_files: -1
2021/12/07-06:33:06.539106 7fa74d2f6b00 Options.bytes_per_sync: 0
2021/12/07-06:33:06.539106 7fa74d2f6b00 Options.wal_bytes_per_sync: 0
2021/12/07-06:33:06.539107 7fa74d2f6b00 Options.strict_bytes_per_sync: 0
2021/12/07-06:33:06.539111 7fa74d2f6b00 Options.compaction_readahead_size: 0
2021/12/07-06:33:06.539111 7fa74d2f6b00 Options.max_background_flushes: -1
2021/12/07-06:33:06.539112 7fa74d2f6b00 Compression algorithms supported:
2021/12/07-06:33:06.539127 7fa74d2f6b00 kZSTDNotFinalCompression supported: 1
2021/12/07-06:33:06.539143 7fa74d2f6b00 kZSTD supported: 1
2021/12/07-06:33:06.539145 7fa74d2f6b00 kXpressCompression supported: 0
2021/12/07-06:33:06.539146 7fa74d2f6b00 kLZ4HCCompression supported: 1
2021/12/07-06:33:06.539146 7fa74d2f6b00 kLZ4Compression supported: 1
2021/12/07-06:33:06.539147 7fa74d2f6b00 kBZip2Compression supported: 0
2021/12/07-06:33:06.539147 7fa74d2f6b00 kZlibCompression supported: 1
2021/12/07-06:33:06.539148 7fa74d2f6b00 kSnappyCompression supported: 1
2021/12/07-06:33:06.539152 7fa74d2f6b00 Fast CRC32 supported: Supported on x86
2021/12/07-06:33:06.539227 7fa74d2f6b00 [/version_set.cc:4847] Recovering from manifest file: ../resources/tmp.db/MANIFEST-000004
2021/12/07-06:33:06.539383 7fa74d2f6b00 [/column_family.cc:609] --------------- Options for column family [default]:
2021/12/07-06:33:06.539386 7fa74d2f6b00 Options.comparator: leveldb.BytewiseComparator
2021/12/07-06:33:06.539386 7fa74d2f6b00 Options.merge_operator: None
2021/12/07-06:33:06.539387 7fa74d2f6b00 Options.compaction_filter: None
2021/12/07-06:33:06.539387 7fa74d2f6b00 Options.compaction_filter_factory: None
2021/12/07-06:33:06.539388 7fa74d2f6b00 Options.sst_partitioner_factory: None
2021/12/07-06:33:06.539388 7fa74d2f6b00 Options.memtable_factory: SkipListFactory
2021/12/07-06:33:06.539389 7fa74d2f6b00 Options.table_factory: BlockBasedTable
2021/12/07-06:33:06.539402 7fa74d2f6b00 table_factory options: flush_block_policy_factory: FlushBlockBySizePolicyFactory (0x1680910)
cache_index_and_filter_blocks: 0
cache_index_and_filter_blocks_with_high_priority: 1
pin_l0_filter_and_index_blocks_in_cache: 0
pin_top_level_index_and_filter: 1
index_type: 0
data_block_index_type: 0
index_shortening: 1
data_block_hash_table_util_ratio: 0.750000
hash_index_allow_collision: 1
checksum: 1
no_block_cache: 0
block_cache: 0x1680bb0
block_cache_name: LRUCache
block_cache_options:
capacity : 8388608
num_shard_bits : 4
strict_capacity_limit : 0
memory_allocator : None
high_pri_pool_ratio: 0.000
block_cache_compressed: (nil)
persistent_cache: (nil)
block_size: 4096
block_size_deviation: 10
block_restart_interval: 16
index_block_restart_interval: 1
metadata_block_size: 4096
partition_filters: 0
use_delta_encoding: 1
filter_policy: nullptr
whole_key_filtering: 1
verify_compression: 0
read_amp_bytes_per_bit: 0
format_version: 5
enable_index_compression: 1
block_align: 0
max_auto_readahead_size: 262144
prepopulate_block_cache: 0
2021/12/07-06:33:06.539403 7fa74d2f6b00 Options.write_buffer_size: 67108864
2021/12/07-06:33:06.539404 7fa74d2f6b00 Options.max_write_buffer_number: 2
2021/12/07-06:33:06.539405 7fa74d2f6b00 Options.compression: Snappy
2021/12/07-06:33:06.539406 7fa74d2f6b00 Options.bottommost_compression: Disabled
2021/12/07-06:33:06.539406 7fa74d2f6b00 Options.prefix_extractor: nullptr
2021/12/07-06:33:06.539407 7fa74d2f6b00 Options.memtable_insert_with_hint_prefix_extractor: nullptr
2021/12/07-06:33:06.539408 7fa74d2f6b00 Options.num_levels: 7
2021/12/07-06:33:06.539408 7fa74d2f6b00 Options.min_write_buffer_number_to_merge: 1
2021/12/07-06:33:06.539409 7fa74d2f6b00 Options.max_write_buffer_number_to_maintain: 0
2021/12/07-06:33:06.539409 7fa74d2f6b00 Options.max_write_buffer_size_to_maintain: 0
2021/12/07-06:33:06.539410 7fa74d2f6b00 Options.bottommost_compression_opts.window_bits: -14
2021/12/07-06:33:06.539410 7fa74d2f6b00 Options.bottommost_compression_opts.level: 32767
2021/12/07-06:33:06.539411 7fa74d2f6b00 Options.bottommost_compression_opts.strategy: 0
2021/12/07-06:33:06.539417 7fa74d2f6b00 Options.bottommost_compression_opts.max_dict_bytes: 0
2021/12/07-06:33:06.539418 7fa74d2f6b00 Options.bottommost_compression_opts.zstd_max_train_bytes: 0
2021/12/07-06:33:06.539418 7fa74d2f6b00 Options.bottommost_compression_opts.parallel_threads: 1
2021/12/07-06:33:06.539419 7fa74d2f6b00 Options.bottommost_compression_opts.enabled: false
2021/12/07-06:33:06.539419 7fa74d2f6b00 Options.bottommost_compression_opts.max_dict_buffer_bytes: 0
2021/12/07-06:33:06.539420 7fa74d2f6b00 Options.compression_opts.window_bits: -14
2021/12/07-06:33:06.539420 7fa74d2f6b00 Options.compression_opts.level: 32767
2021/12/07-06:33:06.539421 7fa74d2f6b00 Options.compression_opts.strategy: 0
2021/12/07-06:33:06.539421 7fa74d2f6b00 Options.compression_opts.max_dict_bytes: 0
2021/12/07-06:33:06.539422 7fa74d2f6b00 Options.compression_opts.zstd_max_train_bytes: 0
2021/12/07-06:33:06.539423 7fa74d2f6b00 Options.compression_opts.parallel_threads: 1
2021/12/07-06:33:06.539423 7fa74d2f6b00 Options.compression_opts.enabled: false
2021/12/07-06:33:06.539424 7fa74d2f6b00 Options.compression_opts.max_dict_buffer_bytes: 0
2021/12/07-06:33:06.539424 7fa74d2f6b00 Options.level0_file_num_compaction_trigger: 4
2021/12/07-06:33:06.539425 7fa74d2f6b00 Options.level0_slowdown_writes_trigger: 20
2021/12/07-06:33:06.539425 7fa74d2f6b00 Options.level0_stop_writes_trigger: 36
2021/12/07-06:33:06.539426 7fa74d2f6b00 Options.target_file_size_base: 67108864
2021/12/07-06:33:06.539426 7fa74d2f6b00 Options.target_file_size_multiplier: 1
2021/12/07-06:33:06.539427 7fa74d2f6b00 Options.max_bytes_for_level_base: 268435456
2021/12/07-06:33:06.539427 7fa74d2f6b00 Options.level_compaction_dynamic_level_bytes: 0
2021/12/07-06:33:06.539428 7fa74d2f6b00 Options.max_bytes_for_level_multiplier: 10.000000
2021/12/07-06:33:06.539429 7fa74d2f6b00 Options.max_bytes_for_level_multiplier_addtl[0]: 1
2021/12/07-06:33:06.539430 7fa74d2f6b00 Options.max_bytes_for_level_multiplier_addtl[1]: 1
2021/12/07-06:33:06.539430 7fa74d2f6b00 Options.max_bytes_for_level_multiplier_addtl[2]: 1
2021/12/07-06:33:06.539431 7fa74d2f6b00 Options.max_bytes_for_level_multiplier_addtl[3]: 1
2021/12/07-06:33:06.539431 7fa74d2f6b00 Options.max_bytes_for_level_multiplier_addtl[4]: 1
2021/12/07-06:33:06.539432 7fa74d2f6b00 Options.max_bytes_for_level_multiplier_addtl[5]: 1
2021/12/07-06:33:06.539432 7fa74d2f6b00 Options.max_bytes_for_level_multiplier_addtl[6]: 1
2021/12/07-06:33:06.539433 7fa74d2f6b00 Options.max_sequential_skip_in_iterations: 8
2021/12/07-06:33:06.539434 7fa74d2f6b00 Options.max_compaction_bytes: 1677721600
2021/12/07-06:33:06.539434 7fa74d2f6b00 Options.arena_block_size: 1048576
2021/12/07-06:33:06.539435 7fa74d2f6b00 Options.soft_pending_compaction_bytes_limit: 68719476736
2021/12/07-06:33:06.539435 7fa74d2f6b00 Options.hard_pending_compaction_bytes_limit: 274877906944
2021/12/07-06:33:06.539436 7fa74d2f6b00 Options.rate_limit_delay_max_milliseconds: 100
2021/12/07-06:33:06.539436 7fa74d2f6b00 Options.disable_auto_compactions: 0
2021/12/07-06:33:06.539437 7fa74d2f6b00 Options.compaction_style: kCompactionStyleLevel
2021/12/07-06:33:06.539438 7fa74d2f6b00 Options.compaction_pri: kMinOverlappingRatio
2021/12/07-06:33:06.539439 7fa74d2f6b00 Options.compaction_options_universal.size_ratio: 1
2021/12/07-06:33:06.539439 7fa74d2f6b00 Options.compaction_options_universal.min_merge_width: 2
2021/12/07-06:33:06.539440 7fa74d2f6b00 Options.compaction_options_universal.max_merge_width: 4294967295
2021/12/07-06:33:06.539440 7fa74d2f6b00 Options.compaction_options_universal.max_size_amplification_percent: 200
2021/12/07-06:33:06.539441 7fa74d2f6b00 Options.compaction_options_universal.compression_size_percent: -1
2021/12/07-06:33:06.539442 7fa74d2f6b00 Options.compaction_options_universal.stop_style: kCompactionStopStyleTotalSize
2021/12/07-06:33:06.539445 7fa74d2f6b00 Options.compaction_options_fifo.max_table_files_size: 1073741824
2021/12/07-06:33:06.539446 7fa74d2f6b00 Options.compaction_options_fifo.allow_compaction: 0
2021/12/07-06:33:06.539448 7fa74d2f6b00 Options.table_properties_collectors:
2021/12/07-06:33:06.539448 7fa74d2f6b00 Options.inplace_update_support: 0
2021/12/07-06:33:06.539449 7fa74d2f6b00 Options.inplace_update_num_locks: 10000
2021/12/07-06:33:06.539449 7fa74d2f6b00 Options.memtable_prefix_bloom_size_ratio: 0.000000
2021/12/07-06:33:06.539450 7fa74d2f6b00 Options.memtable_whole_key_filtering: 0
2021/12/07-06:33:06.539451 7fa74d2f6b00 Options.memtable_huge_page_size: 0
2021/12/07-06:33:06.539451 7fa74d2f6b00 Options.bloom_locality: 0
2021/12/07-06:33:06.539452 7fa74d2f6b00 Options.max_successive_merges: 0
2021/12/07-06:33:06.539452 7fa74d2f6b00 Options.optimize_filters_for_hits: 0
2021/12/07-06:33:06.539453 7fa74d2f6b00 Options.paranoid_file_checks: 0
2021/12/07-06:33:06.539453 7fa74d2f6b00 Options.force_consistency_checks: 1
2021/12/07-06:33:06.539454 7fa74d2f6b00 Options.report_bg_io_stats: 0
2021/12/07-06:33:06.539454 7fa74d2f6b00 Options.ttl: 2592000
2021/12/07-06:33:06.539455 7fa74d2f6b00 Options.periodic_compaction_seconds: 0
2021/12/07-06:33:06.539455 7fa74d2f6b00 Options.enable_blob_files: false
2021/12/07-06:33:06.539456 7fa74d2f6b00 Options.min_blob_size: 0
2021/12/07-06:33:06.539456 7fa74d2f6b00 Options.blob_file_size: 268435456
2021/12/07-06:33:06.539457 7fa74d2f6b00 Options.blob_compression_type: NoCompression
2021/12/07-06:33:06.539458 7fa74d2f6b00 Options.enable_blob_garbage_collection: false
2021/12/07-06:33:06.539458 7fa74d2f6b00 Options.blob_garbage_collection_age_cutoff: 0.250000
2021/12/07-06:33:06.539459 7fa74d2f6b00 Options.blob_garbage_collection_force_threshold: 1.000000
2021/12/07-06:33:06.540327 7fa74d2f6b00 [/version_set.cc:4887] Recovered from manifest file:../resources/tmp.db/MANIFEST-000004 succeeded,manifest_file_number is 4, next_file_number is 6, last_sequence is 0, log_number is 0,prev_log_number is 0,max_column_family is 0,min_log_number_to_keep is 0
2021/12/07-06:33:06.540331 7fa74d2f6b00 [/version_set.cc:4902] Column family [default] (ID 0), log number is 0
2021/12/07-06:33:06.540403 7fa74d2f6b00 [/version_set.cc:4385] Creating manifest 8
2021/12/07-06:33:06.552457 7fa74d2f6b00 EVENT_LOG_v1 {"time_micros": 1638876786552424, "job": 1, "event": "recovery_started", "wal_files": [5]}
2021/12/07-06:33:06.552464 7fa74d2f6b00 [/db_impl/db_impl_open.cc:876] Recovering log #5 mode 2
2021/12/07-06:33:06.556439 7fa74d2f6b00 EVENT_LOG_v1 {"time_micros": 1638876786556386, "cf_name": "default", "job": 1, "event": "table_file_creation", "file_number": 9, "file_size": 1237, "file_checksum": "", "file_checksum_func_name": "Unknown", "table_properties": {"data_size": 303, "index_size": 29, "index_partitions": 0, "top_level_index_size": 0, "index_key_is_user_key": 1, "index_value_is_delta_encoded": 1, "filter_size": 0, "raw_key_size": 190, "raw_average_key_size": 19, "raw_value_size": 110, "raw_average_value_size": 11, "num_data_blocks": 1, "num_entries": 10, "num_filter_entries": 0, "num_deletions": 0, "num_merge_operands": 0, "num_range_deletions": 0, "format_version": 0, "fixed_key_len": 0, "filter_policy": "", "column_family_name": "default", "column_family_id": 0, "comparator": "leveldb.BytewiseComparator", "merge_operator": "nullptr", "prefix_extractor_name": "nullptr", "property_collectors": "[]", "compression": "Snappy", "compression_options": "window_bits=-14; level=32767; strategy=0; max_dict_bytes=0; zstd_max_train_bytes=0; enabled=0; max_dict_buffer_bytes=0; ", "creation_time": 1638876786, "oldest_key_time": 0, "file_creation_time": 0, "slow_compression_estimated_data_size": 0, "fast_compression_estimated_data_size": 0, "db_id": "b6f61266-9f2d-4712-a981-584bd5d6e0b3", "db_session_id": "N6J7EYOHEJZJCZ6TLCTO", "orig_file_number": 9}}
2021/12/07-06:33:06.556512 7fa74d2f6b00 [/version_set.cc:4385] Creating manifest 10
2021/12/07-06:33:06.560685 7fa74d2f6b00 EVENT_LOG_v1 {"time_micros": 1638876786560682, "job": 1, "event": "recovery_finished"}
2021/12/07-06:33:06.560873 7fa74d2f6b00 [le/delete_scheduler.cc:73] Deleted file ../resources/tmp.db/000005.log immediately, rate_bytes_per_sec 0, total_trash_size 0 max_trash_db_ratio 0.250000
2021/12/07-06:33:06.564805 7fa74d2f6b00 [/db_impl/db_impl_open.cc:1786] SstFileManager instance 0x1682790
2021/12/07-06:33:06.564855 7fa74d2f6b00 DB pointer 0x1684b90
2021/12/07-06:33:06.565226 7fa6fa7f4700 [/db_impl/db_impl.cc:1004] ------- DUMPING STATS -------
2021/12/07-06:33:06.565239 7fa6fa7f4700 [/db_impl/db_impl.cc:1006]
** DB Stats **
Uptime(secs): 0.0 total, 0.0 interval
Cumulative writes: 0 writes, 0 keys, 0 commit groups, 0.0 writes per commit group, ingest: 0.00 GB, 0.00 MB/s
Cumulative WAL: 0 writes, 0 syncs, 0.00 writes per sync, written: 0.00 GB, 0.00 MB/s
Cumulative stall: 00:00:0.000 H:M:S, 0.0 percent
Interval writes: 0 writes, 0 keys, 0 commit groups, 0.0 writes per commit group, ingest: 0.00 MB, 0.00 MB/s
Interval WAL: 0 writes, 0 syncs, 0.00 writes per sync, written: 0.00 GB, 0.00 MB/s
Interval stall: 00:00:0.000 H:M:S, 0.0 percent
** Compaction Stats [default] **
Level Files Size Score Read(GB) Rn(GB) Rnp1(GB) Write(GB) Wnew(GB) Moved(GB) W-Amp Rd(MB/s) Wr(MB/s) Comp(sec) CompMergeCPU(sec) Comp(cnt) Avg(sec) KeyIn KeyDrop Rblob(GB) Wblob(GB)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
L0 1/0 1.21 KB 0.2 0.0 0.0 0.0 0.0 0.0 0.0 1.0 0.0 0.3 0.00 0.00 1 0.004 0 0 0.0 0.0
Sum 1/0 1.21 KB 0.0 0.0 0.0 0.0 0.0 0.0 0.0 1.0 0.0 0.3 0.00 0.00 1 0.004 0 0 0.0 0.0
Int 0/0 0.00 KB 0.0 0.0 0.0 0.0 0.0 0.0 0.0 1.0 0.0 0.3 0.00 0.00 1 0.004 0 0 0.0 0.0
** Compaction Stats [default] **
Priority Files Size Score Read(GB) Rn(GB) Rnp1(GB) Write(GB) Wnew(GB) Moved(GB) W-Amp Rd(MB/s) Wr(MB/s) Comp(sec) CompMergeCPU(sec) Comp(cnt) Avg(sec) KeyIn KeyDrop Rblob(GB) Wblob(GB)
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
User 0/0 0.00 KB 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.3 0.00 0.00 1 0.004 0 0 0.0 0.0
Blob file count: 0, total size: 0.0 GB
Uptime(secs): 0.0 total, 0.0 interval
Flush(GB): cumulative 0.000, interval 0.000
AddFile(GB): cumulative 0.000, interval 0.000
AddFile(Total Files): cumulative 0, interval 0
AddFile(L0 Files): cumulative 0, interval 0
AddFile(Keys): cumulative 0, interval 0
Cumulative compaction: 0.00 GB write, 0.05 MB/s write, 0.00 GB read, 0.00 MB/s read, 0.0 seconds
Interval compaction: 0.00 GB write, 0.05 MB/s write, 0.00 GB read, 0.00 MB/s read, 0.0 seconds
Stalls(count): 0 level0_slowdown, 0 level0_slowdown_with_compaction, 0 level0_numfiles, 0 level0_numfiles_with_compaction, 0 stop for pending_compaction_bytes, 0 slowdown for pending_compaction_bytes, 0 memtable_compaction, 0 memtable_slowdown, interval 0 total count
Block cache LRUCache@0x1680bb0#505944 capacity: 8.00 MB collections: 1 last_copies: 0 last_secs: 2.8e-05 secs_since: 0
Block cache entry stats(count,size,portion): Misc(1,0.00 KB,0%)
** File Read Latency Histogram By Level [default] **

View file

@ -0,0 +1,234 @@
2021/12/07-06:29:58.316113 7fc325a08b00 RocksDB version: 6.26.1
2021/12/07-06:29:58.316204 7fc325a08b00 Git sha 4d57a393a8f1563c0dff1ff468756c23d89e3601
2021/12/07-06:29:58.316205 7fc325a08b00 Compile date 2021-11-18 14:47:16
2021/12/07-06:29:58.316206 7fc325a08b00 DB SUMMARY
2021/12/07-06:29:58.316207 7fc325a08b00 DB Session ID: YEXR8D6M3U7W3AT6CZQO
2021/12/07-06:29:58.316233 7fc325a08b00 SST files in ./tmp.db dir, Total Num: 0, files:
2021/12/07-06:29:58.316234 7fc325a08b00 Write Ahead Log file in ./tmp.db:
2021/12/07-06:29:58.316235 7fc325a08b00 Options.error_if_exists: 0
2021/12/07-06:29:58.316235 7fc325a08b00 Options.create_if_missing: 1
2021/12/07-06:29:58.316236 7fc325a08b00 Options.paranoid_checks: 1
2021/12/07-06:29:58.316236 7fc325a08b00 Options.flush_verify_memtable_count: 1
2021/12/07-06:29:58.316237 7fc325a08b00 Options.track_and_verify_wals_in_manifest: 0
2021/12/07-06:29:58.316237 7fc325a08b00 Options.env: 0x7fc3269340c0
2021/12/07-06:29:58.316238 7fc325a08b00 Options.fs: Posix File System
2021/12/07-06:29:58.316239 7fc325a08b00 Options.info_log: 0x1c17cc0
2021/12/07-06:29:58.316239 7fc325a08b00 Options.max_file_opening_threads: 16
2021/12/07-06:29:58.316240 7fc325a08b00 Options.statistics: (nil)
2021/12/07-06:29:58.316241 7fc325a08b00 Options.use_fsync: 0
2021/12/07-06:29:58.316241 7fc325a08b00 Options.max_log_file_size: 0
2021/12/07-06:29:58.316242 7fc325a08b00 Options.max_manifest_file_size: 1073741824
2021/12/07-06:29:58.316242 7fc325a08b00 Options.log_file_time_to_roll: 0
2021/12/07-06:29:58.316243 7fc325a08b00 Options.keep_log_file_num: 1000
2021/12/07-06:29:58.316243 7fc325a08b00 Options.recycle_log_file_num: 0
2021/12/07-06:29:58.316244 7fc325a08b00 Options.allow_fallocate: 1
2021/12/07-06:29:58.316244 7fc325a08b00 Options.allow_mmap_reads: 0
2021/12/07-06:29:58.316245 7fc325a08b00 Options.allow_mmap_writes: 0
2021/12/07-06:29:58.316245 7fc325a08b00 Options.use_direct_reads: 0
2021/12/07-06:29:58.316246 7fc325a08b00 Options.use_direct_io_for_flush_and_compaction: 0
2021/12/07-06:29:58.316246 7fc325a08b00 Options.create_missing_column_families: 0
2021/12/07-06:29:58.316247 7fc325a08b00 Options.db_log_dir:
2021/12/07-06:29:58.316247 7fc325a08b00 Options.wal_dir:
2021/12/07-06:29:58.316248 7fc325a08b00 Options.table_cache_numshardbits: 6
2021/12/07-06:29:58.316248 7fc325a08b00 Options.WAL_ttl_seconds: 0
2021/12/07-06:29:58.316249 7fc325a08b00 Options.WAL_size_limit_MB: 0
2021/12/07-06:29:58.316249 7fc325a08b00 Options.max_write_batch_group_size_bytes: 1048576
2021/12/07-06:29:58.316250 7fc325a08b00 Options.manifest_preallocation_size: 4194304
2021/12/07-06:29:58.316251 7fc325a08b00 Options.is_fd_close_on_exec: 1
2021/12/07-06:29:58.316251 7fc325a08b00 Options.advise_random_on_open: 1
2021/12/07-06:29:58.316252 7fc325a08b00 Options.experimental_mempurge_threshold: 0.000000
2021/12/07-06:29:58.316253 7fc325a08b00 Options.db_write_buffer_size: 0
2021/12/07-06:29:58.316253 7fc325a08b00 Options.write_buffer_manager: 0x1c5a830
2021/12/07-06:29:58.316254 7fc325a08b00 Options.access_hint_on_compaction_start: 1
2021/12/07-06:29:58.316254 7fc325a08b00 Options.new_table_reader_for_compaction_inputs: 0
2021/12/07-06:29:58.316255 7fc325a08b00 Options.random_access_max_buffer_size: 1048576
2021/12/07-06:29:58.316255 7fc325a08b00 Options.use_adaptive_mutex: 0
2021/12/07-06:29:58.316256 7fc325a08b00 Options.rate_limiter: (nil)
2021/12/07-06:29:58.316261 7fc325a08b00 Options.sst_file_manager.rate_bytes_per_sec: 0
2021/12/07-06:29:58.316262 7fc325a08b00 Options.wal_recovery_mode: 2
2021/12/07-06:29:58.316262 7fc325a08b00 Options.enable_thread_tracking: 0
2021/12/07-06:29:58.316263 7fc325a08b00 Options.enable_pipelined_write: 0
2021/12/07-06:29:58.316263 7fc325a08b00 Options.unordered_write: 0
2021/12/07-06:29:58.316264 7fc325a08b00 Options.allow_concurrent_memtable_write: 1
2021/12/07-06:29:58.316264 7fc325a08b00 Options.enable_write_thread_adaptive_yield: 1
2021/12/07-06:29:58.316265 7fc325a08b00 Options.write_thread_max_yield_usec: 100
2021/12/07-06:29:58.316265 7fc325a08b00 Options.write_thread_slow_yield_usec: 3
2021/12/07-06:29:58.316266 7fc325a08b00 Options.row_cache: None
2021/12/07-06:29:58.316266 7fc325a08b00 Options.wal_filter: None
2021/12/07-06:29:58.316267 7fc325a08b00 Options.avoid_flush_during_recovery: 0
2021/12/07-06:29:58.316267 7fc325a08b00 Options.allow_ingest_behind: 0
2021/12/07-06:29:58.316268 7fc325a08b00 Options.preserve_deletes: 0
2021/12/07-06:29:58.316268 7fc325a08b00 Options.two_write_queues: 0
2021/12/07-06:29:58.316269 7fc325a08b00 Options.manual_wal_flush: 0
2021/12/07-06:29:58.316269 7fc325a08b00 Options.atomic_flush: 0
2021/12/07-06:29:58.316270 7fc325a08b00 Options.avoid_unnecessary_blocking_io: 0
2021/12/07-06:29:58.316270 7fc325a08b00 Options.persist_stats_to_disk: 0
2021/12/07-06:29:58.316271 7fc325a08b00 Options.write_dbid_to_manifest: 0
2021/12/07-06:29:58.316271 7fc325a08b00 Options.log_readahead_size: 0
2021/12/07-06:29:58.316272 7fc325a08b00 Options.file_checksum_gen_factory: Unknown
2021/12/07-06:29:58.316273 7fc325a08b00 Options.best_efforts_recovery: 0
2021/12/07-06:29:58.316273 7fc325a08b00 Options.max_bgerror_resume_count: 2147483647
2021/12/07-06:29:58.316274 7fc325a08b00 Options.bgerror_resume_retry_interval: 1000000
2021/12/07-06:29:58.316274 7fc325a08b00 Options.allow_data_in_errors: 0
2021/12/07-06:29:58.316275 7fc325a08b00 Options.db_host_id: __hostname__
2021/12/07-06:29:58.316275 7fc325a08b00 Options.max_background_jobs: 2
2021/12/07-06:29:58.316276 7fc325a08b00 Options.max_background_compactions: -1
2021/12/07-06:29:58.316276 7fc325a08b00 Options.max_subcompactions: 1
2021/12/07-06:29:58.316277 7fc325a08b00 Options.avoid_flush_during_shutdown: 0
2021/12/07-06:29:58.316277 7fc325a08b00 Options.writable_file_max_buffer_size: 1048576
2021/12/07-06:29:58.316278 7fc325a08b00 Options.delayed_write_rate : 16777216
2021/12/07-06:29:58.316278 7fc325a08b00 Options.max_total_wal_size: 0
2021/12/07-06:29:58.316279 7fc325a08b00 Options.delete_obsolete_files_period_micros: 21600000000
2021/12/07-06:29:58.316279 7fc325a08b00 Options.stats_dump_period_sec: 600
2021/12/07-06:29:58.316280 7fc325a08b00 Options.stats_persist_period_sec: 600
2021/12/07-06:29:58.316280 7fc325a08b00 Options.stats_history_buffer_size: 1048576
2021/12/07-06:29:58.316281 7fc325a08b00 Options.max_open_files: -1
2021/12/07-06:29:58.316282 7fc325a08b00 Options.bytes_per_sync: 0
2021/12/07-06:29:58.316282 7fc325a08b00 Options.wal_bytes_per_sync: 0
2021/12/07-06:29:58.316283 7fc325a08b00 Options.strict_bytes_per_sync: 0
2021/12/07-06:29:58.316283 7fc325a08b00 Options.compaction_readahead_size: 0
2021/12/07-06:29:58.316284 7fc325a08b00 Options.max_background_flushes: -1
2021/12/07-06:29:58.316299 7fc325a08b00 Compression algorithms supported:
2021/12/07-06:29:58.316303 7fc325a08b00 kZSTDNotFinalCompression supported: 1
2021/12/07-06:29:58.316304 7fc325a08b00 kZSTD supported: 1
2021/12/07-06:29:58.316304 7fc325a08b00 kXpressCompression supported: 0
2021/12/07-06:29:58.316305 7fc325a08b00 kLZ4HCCompression supported: 1
2021/12/07-06:29:58.316305 7fc325a08b00 kLZ4Compression supported: 1
2021/12/07-06:29:58.316306 7fc325a08b00 kBZip2Compression supported: 0
2021/12/07-06:29:58.316307 7fc325a08b00 kZlibCompression supported: 1
2021/12/07-06:29:58.316307 7fc325a08b00 kSnappyCompression supported: 1
2021/12/07-06:29:58.316310 7fc325a08b00 Fast CRC32 supported: Supported on x86
2021/12/07-06:29:58.324834 7fc325a08b00 [/db_impl/db_impl_open.cc:300] Creating manifest 1
2021/12/07-06:29:58.329726 7fc325a08b00 [/version_set.cc:4847] Recovering from manifest file: ./tmp.db/MANIFEST-000001
2021/12/07-06:29:58.329806 7fc325a08b00 [/column_family.cc:609] --------------- Options for column family [default]:
2021/12/07-06:29:58.329807 7fc325a08b00 Options.comparator: leveldb.BytewiseComparator
2021/12/07-06:29:58.329808 7fc325a08b00 Options.merge_operator: None
2021/12/07-06:29:58.329809 7fc325a08b00 Options.compaction_filter: None
2021/12/07-06:29:58.329809 7fc325a08b00 Options.compaction_filter_factory: None
2021/12/07-06:29:58.329810 7fc325a08b00 Options.sst_partitioner_factory: None
2021/12/07-06:29:58.329810 7fc325a08b00 Options.memtable_factory: SkipListFactory
2021/12/07-06:29:58.329811 7fc325a08b00 Options.table_factory: BlockBasedTable
2021/12/07-06:29:58.329822 7fc325a08b00 table_factory options: flush_block_policy_factory: FlushBlockBySizePolicyFactory (0x1bb9910)
cache_index_and_filter_blocks: 0
cache_index_and_filter_blocks_with_high_priority: 1
pin_l0_filter_and_index_blocks_in_cache: 0
pin_top_level_index_and_filter: 1
index_type: 0
data_block_index_type: 0
index_shortening: 1
data_block_hash_table_util_ratio: 0.750000
hash_index_allow_collision: 1
checksum: 1
no_block_cache: 0
block_cache: 0x1bb9bb0
block_cache_name: LRUCache
block_cache_options:
capacity : 8388608
num_shard_bits : 4
strict_capacity_limit : 0
memory_allocator : None
high_pri_pool_ratio: 0.000
block_cache_compressed: (nil)
persistent_cache: (nil)
block_size: 4096
block_size_deviation: 10
block_restart_interval: 16
index_block_restart_interval: 1
metadata_block_size: 4096
partition_filters: 0
use_delta_encoding: 1
filter_policy: nullptr
whole_key_filtering: 1
verify_compression: 0
read_amp_bytes_per_bit: 0
format_version: 5
enable_index_compression: 1
block_align: 0
max_auto_readahead_size: 262144
prepopulate_block_cache: 0
2021/12/07-06:29:58.329823 7fc325a08b00 Options.write_buffer_size: 67108864
2021/12/07-06:29:58.329823 7fc325a08b00 Options.max_write_buffer_number: 2
2021/12/07-06:29:58.329824 7fc325a08b00 Options.compression: Snappy
2021/12/07-06:29:58.329825 7fc325a08b00 Options.bottommost_compression: Disabled
2021/12/07-06:29:58.329825 7fc325a08b00 Options.prefix_extractor: nullptr
2021/12/07-06:29:58.329826 7fc325a08b00 Options.memtable_insert_with_hint_prefix_extractor: nullptr
2021/12/07-06:29:58.329826 7fc325a08b00 Options.num_levels: 7
2021/12/07-06:29:58.329827 7fc325a08b00 Options.min_write_buffer_number_to_merge: 1
2021/12/07-06:29:58.329827 7fc325a08b00 Options.max_write_buffer_number_to_maintain: 0
2021/12/07-06:29:58.329828 7fc325a08b00 Options.max_write_buffer_size_to_maintain: 0
2021/12/07-06:29:58.329829 7fc325a08b00 Options.bottommost_compression_opts.window_bits: -14
2021/12/07-06:29:58.329829 7fc325a08b00 Options.bottommost_compression_opts.level: 32767
2021/12/07-06:29:58.329830 7fc325a08b00 Options.bottommost_compression_opts.strategy: 0
2021/12/07-06:29:58.329830 7fc325a08b00 Options.bottommost_compression_opts.max_dict_bytes: 0
2021/12/07-06:29:58.329831 7fc325a08b00 Options.bottommost_compression_opts.zstd_max_train_bytes: 0
2021/12/07-06:29:58.329840 7fc325a08b00 Options.bottommost_compression_opts.parallel_threads: 1
2021/12/07-06:29:58.329841 7fc325a08b00 Options.bottommost_compression_opts.enabled: false
2021/12/07-06:29:58.329841 7fc325a08b00 Options.bottommost_compression_opts.max_dict_buffer_bytes: 0
2021/12/07-06:29:58.329842 7fc325a08b00 Options.compression_opts.window_bits: -14
2021/12/07-06:29:58.329842 7fc325a08b00 Options.compression_opts.level: 32767
2021/12/07-06:29:58.329843 7fc325a08b00 Options.compression_opts.strategy: 0
2021/12/07-06:29:58.329843 7fc325a08b00 Options.compression_opts.max_dict_bytes: 0
2021/12/07-06:29:58.329844 7fc325a08b00 Options.compression_opts.zstd_max_train_bytes: 0
2021/12/07-06:29:58.329844 7fc325a08b00 Options.compression_opts.parallel_threads: 1
2021/12/07-06:29:58.329845 7fc325a08b00 Options.compression_opts.enabled: false
2021/12/07-06:29:58.329845 7fc325a08b00 Options.compression_opts.max_dict_buffer_bytes: 0
2021/12/07-06:29:58.329846 7fc325a08b00 Options.level0_file_num_compaction_trigger: 4
2021/12/07-06:29:58.329847 7fc325a08b00 Options.level0_slowdown_writes_trigger: 20
2021/12/07-06:29:58.329847 7fc325a08b00 Options.level0_stop_writes_trigger: 36
2021/12/07-06:29:58.329848 7fc325a08b00 Options.target_file_size_base: 67108864
2021/12/07-06:29:58.329848 7fc325a08b00 Options.target_file_size_multiplier: 1
2021/12/07-06:29:58.329849 7fc325a08b00 Options.max_bytes_for_level_base: 268435456
2021/12/07-06:29:58.329849 7fc325a08b00 Options.level_compaction_dynamic_level_bytes: 0
2021/12/07-06:29:58.329850 7fc325a08b00 Options.max_bytes_for_level_multiplier: 10.000000
2021/12/07-06:29:58.329851 7fc325a08b00 Options.max_bytes_for_level_multiplier_addtl[0]: 1
2021/12/07-06:29:58.329852 7fc325a08b00 Options.max_bytes_for_level_multiplier_addtl[1]: 1
2021/12/07-06:29:58.329852 7fc325a08b00 Options.max_bytes_for_level_multiplier_addtl[2]: 1
2021/12/07-06:29:58.329853 7fc325a08b00 Options.max_bytes_for_level_multiplier_addtl[3]: 1
2021/12/07-06:29:58.329853 7fc325a08b00 Options.max_bytes_for_level_multiplier_addtl[4]: 1
2021/12/07-06:29:58.329854 7fc325a08b00 Options.max_bytes_for_level_multiplier_addtl[5]: 1
2021/12/07-06:29:58.329854 7fc325a08b00 Options.max_bytes_for_level_multiplier_addtl[6]: 1
2021/12/07-06:29:58.329855 7fc325a08b00 Options.max_sequential_skip_in_iterations: 8
2021/12/07-06:29:58.329855 7fc325a08b00 Options.max_compaction_bytes: 1677721600
2021/12/07-06:29:58.329856 7fc325a08b00 Options.arena_block_size: 1048576
2021/12/07-06:29:58.329856 7fc325a08b00 Options.soft_pending_compaction_bytes_limit: 68719476736
2021/12/07-06:29:58.329857 7fc325a08b00 Options.hard_pending_compaction_bytes_limit: 274877906944
2021/12/07-06:29:58.329857 7fc325a08b00 Options.rate_limit_delay_max_milliseconds: 100
2021/12/07-06:29:58.329858 7fc325a08b00 Options.disable_auto_compactions: 0
2021/12/07-06:29:58.329859 7fc325a08b00 Options.compaction_style: kCompactionStyleLevel
2021/12/07-06:29:58.329860 7fc325a08b00 Options.compaction_pri: kMinOverlappingRatio
2021/12/07-06:29:58.329861 7fc325a08b00 Options.compaction_options_universal.size_ratio: 1
2021/12/07-06:29:58.329861 7fc325a08b00 Options.compaction_options_universal.min_merge_width: 2
2021/12/07-06:29:58.329862 7fc325a08b00 Options.compaction_options_universal.max_merge_width: 4294967295
2021/12/07-06:29:58.329862 7fc325a08b00 Options.compaction_options_universal.max_size_amplification_percent: 200
2021/12/07-06:29:58.329863 7fc325a08b00 Options.compaction_options_universal.compression_size_percent: -1
2021/12/07-06:29:58.329863 7fc325a08b00 Options.compaction_options_universal.stop_style: kCompactionStopStyleTotalSize
2021/12/07-06:29:58.329864 7fc325a08b00 Options.compaction_options_fifo.max_table_files_size: 1073741824
2021/12/07-06:29:58.329868 7fc325a08b00 Options.compaction_options_fifo.allow_compaction: 0
2021/12/07-06:29:58.329871 7fc325a08b00 Options.table_properties_collectors:
2021/12/07-06:29:58.329872 7fc325a08b00 Options.inplace_update_support: 0
2021/12/07-06:29:58.329872 7fc325a08b00 Options.inplace_update_num_locks: 10000
2021/12/07-06:29:58.329873 7fc325a08b00 Options.memtable_prefix_bloom_size_ratio: 0.000000
2021/12/07-06:29:58.329873 7fc325a08b00 Options.memtable_whole_key_filtering: 0
2021/12/07-06:29:58.329874 7fc325a08b00 Options.memtable_huge_page_size: 0
2021/12/07-06:29:58.329874 7fc325a08b00 Options.bloom_locality: 0
2021/12/07-06:29:58.329875 7fc325a08b00 Options.max_successive_merges: 0
2021/12/07-06:29:58.329875 7fc325a08b00 Options.optimize_filters_for_hits: 0
2021/12/07-06:29:58.329876 7fc325a08b00 Options.paranoid_file_checks: 0
2021/12/07-06:29:58.329877 7fc325a08b00 Options.force_consistency_checks: 1
2021/12/07-06:29:58.329877 7fc325a08b00 Options.report_bg_io_stats: 0
2021/12/07-06:29:58.329878 7fc325a08b00 Options.ttl: 2592000
2021/12/07-06:29:58.329878 7fc325a08b00 Options.periodic_compaction_seconds: 0
2021/12/07-06:29:58.329879 7fc325a08b00 Options.enable_blob_files: false
2021/12/07-06:29:58.329879 7fc325a08b00 Options.min_blob_size: 0
2021/12/07-06:29:58.329880 7fc325a08b00 Options.blob_file_size: 268435456
2021/12/07-06:29:58.329880 7fc325a08b00 Options.blob_compression_type: NoCompression
2021/12/07-06:29:58.329881 7fc325a08b00 Options.enable_blob_garbage_collection: false
2021/12/07-06:29:58.329881 7fc325a08b00 Options.blob_garbage_collection_age_cutoff: 0.250000
2021/12/07-06:29:58.329882 7fc325a08b00 Options.blob_garbage_collection_force_threshold: 1.000000
2021/12/07-06:29:58.331027 7fc325a08b00 [/version_set.cc:4887] Recovered from manifest file:./tmp.db/MANIFEST-000001 succeeded,manifest_file_number is 1, next_file_number is 3, last_sequence is 0, log_number is 0,prev_log_number is 0,max_column_family is 0,min_log_number_to_keep is 0
2021/12/07-06:29:58.331031 7fc325a08b00 [/version_set.cc:4902] Column family [default] (ID 0), log number is 0
2021/12/07-06:29:58.331064 7fc325a08b00 [/version_set.cc:4385] Creating manifest 4
2021/12/07-06:29:58.338218 7fc325a08b00 [/db_impl/db_impl_open.cc:1786] SstFileManager instance 0x1c60cc0
2021/12/07-06:29:58.338227 7fc325a08b00 DB pointer 0x1f2fa50
2021/12/07-06:29:58.341368 7fc325a08b00 [/db_impl/db_impl.cc:472] Shutdown: canceling all background work
2021/12/07-06:29:58.341653 7fc325a08b00 [/db_impl/db_impl.cc:685] Shutdown complete

Binary file not shown.

View file

@ -0,0 +1,187 @@
# This is a RocksDB option file.
#
# For detailed file format spec, please refer to the example file
# in examples/rocksdb_option_file_example.ini
#
[Version]
rocksdb_version=6.26.1
options_file_version=1.1
[DBOptions]
max_open_files=-1
stats_history_buffer_size=1048576
stats_persist_period_sec=600
max_background_flushes=-1
stats_dump_period_sec=600
compaction_readahead_size=0
bytes_per_sync=0
delete_obsolete_files_period_micros=21600000000
max_total_wal_size=0
delayed_write_rate=16777216
wal_bytes_per_sync=0
writable_file_max_buffer_size=1048576
avoid_flush_during_shutdown=false
max_subcompactions=1
strict_bytes_per_sync=false
max_background_compactions=-1
base_background_compactions=-1
max_background_jobs=2
file_checksum_gen_factory=nullptr
db_host_id=__hostname__
bgerror_resume_retry_interval=1000000
best_efforts_recovery=false
avoid_unnecessary_blocking_io=false
two_write_queues=false
atomic_flush=false
preserve_deletes=false
allow_ingest_behind=false
lowest_used_cache_tier=kNonVolatileBlockTier
avoid_flush_during_recovery=false
info_log_level=INFO_LEVEL
access_hint_on_compaction_start=NORMAL
max_bgerror_resume_count=2147483647
write_thread_slow_yield_usec=3
allow_concurrent_memtable_write=true
WAL_ttl_seconds=0
manual_wal_flush=false
dump_malloc_stats=false
wal_recovery_mode=kPointInTimeRecovery
log_file_time_to_roll=0
enable_write_thread_adaptive_yield=true
recycle_log_file_num=0
table_cache_numshardbits=6
max_file_opening_threads=16
allow_data_in_errors=false
use_fsync=false
unordered_write=false
fail_if_options_file_error=false
random_access_max_buffer_size=1048576
new_table_reader_for_compaction_inputs=false
skip_checking_sst_file_sizes_on_db_open=false
skip_stats_update_on_db_open=false
persist_stats_to_disk=false
track_and_verify_wals_in_manifest=false
enable_pipelined_write=false
flush_verify_memtable_count=true
log_readahead_size=0
is_fd_close_on_exec=true
WAL_size_limit_MB=0
experimental_mempurge_threshold=0.000000
write_dbid_to_manifest=false
use_adaptive_mutex=false
error_if_exists=false
write_thread_max_yield_usec=100
enable_thread_tracking=false
db_write_buffer_size=0
create_missing_column_families=false
paranoid_checks=true
create_if_missing=true
wal_filter=nullptr
max_manifest_file_size=1073741824
allow_2pc=false
use_direct_io_for_flush_and_compaction=false
manifest_preallocation_size=4194304
use_direct_reads=false
allow_fallocate=true
max_write_batch_group_size_bytes=1048576
keep_log_file_num=1000
allow_mmap_reads=false
max_log_file_size=0
allow_mmap_writes=false
advise_random_on_open=true
[CFOptions "default"]
bottommost_compression=kDisableCompressionOption
bottommost_compression_opts={max_dict_buffer_bytes=0;enabled=false;parallel_threads=1;zstd_max_train_bytes=0;strategy=0;max_dict_bytes=0;level=32767;window_bits=-14;}
sample_for_compression=0
blob_garbage_collection_force_threshold=1.000000
blob_file_size=268435456
compaction_options_universal={allow_trivial_move=false;incremental=false;stop_style=kCompactionStopStyleTotalSize;compression_size_percent=-1;max_size_amplification_percent=200;max_merge_width=4294967295;min_merge_width=2;size_ratio=1;}
compaction_options_fifo={allow_compaction=false;age_for_warm=0;max_table_files_size=1073741824;}
prefix_extractor=nullptr
max_bytes_for_level_multiplier_additional=1:1:1:1:1:1:1
max_bytes_for_level_base=268435456
memtable_whole_key_filtering=false
memtable_prefix_bloom_size_ratio=0.000000
enable_blob_files=false
target_file_size_base=67108864
memtable_huge_page_size=0
max_successive_merges=0
inplace_update_num_locks=10000
max_sequential_skip_in_iterations=8
arena_block_size=1048576
target_file_size_multiplier=1
max_write_buffer_number=2
write_buffer_size=67108864
blob_compression_type=kNoCompression
compression=kSnappyCompression
level0_stop_writes_trigger=36
level0_slowdown_writes_trigger=20
level0_file_num_compaction_trigger=4
ttl=2592000
max_compaction_bytes=1677721600
blob_garbage_collection_age_cutoff=0.250000
compression_opts={max_dict_buffer_bytes=0;enabled=false;parallel_threads=1;zstd_max_train_bytes=0;strategy=0;max_dict_bytes=0;level=32767;window_bits=-14;}
enable_blob_garbage_collection=false
soft_pending_compaction_bytes_limit=68719476736
paranoid_file_checks=false
periodic_compaction_seconds=0
check_flush_compaction_key_order=true
min_blob_size=0
hard_pending_compaction_bytes_limit=274877906944
disable_auto_compactions=false
max_bytes_for_level_multiplier=10.000000
report_bg_io_stats=false
compaction_pri=kMinOverlappingRatio
compaction_filter_factory=nullptr
comparator=leveldb.BytewiseComparator
sst_partitioner_factory=nullptr
bloom_locality=0
compaction_style=kCompactionStyleLevel
min_write_buffer_number_to_merge=1
max_write_buffer_size_to_maintain=0
max_write_buffer_number_to_maintain=0
merge_operator=nullptr
memtable_factory=SkipListFactory
memtable_insert_with_hint_prefix_extractor=nullptr
num_levels=7
force_consistency_checks=true
optimize_filters_for_hits=false
compaction_filter=nullptr
level_compaction_dynamic_level_bytes=false
inplace_update_support=false
table_factory=BlockBasedTable
[TableOptions/BlockBasedTable "default"]
pin_top_level_index_and_filter=true
block_align=false
read_amp_bytes_per_bit=0
verify_compression=false
enable_index_compression=true
whole_key_filtering=true
max_auto_readahead_size=262144
optimize_filters_for_memory=false
index_block_restart_interval=1
prepopulate_block_cache=kDisable
block_restart_interval=16
block_size=4096
format_version=5
partition_filters=false
block_size_deviation=10
no_block_cache=false
checksum=kCRC32c
data_block_hash_table_util_ratio=0.750000
index_shortening=kShortenSeparators
data_block_index_type=kDataBlockBinarySearch
hash_index_allow_collision=true
filter_policy=nullptr
metadata_block_size=4096
index_type=kBinarySearch
metadata_cache_options={unpartitioned_pinning=kFallback;partition_pinning=kFallback;top_level_index_pinning=kFallback;}
pin_l0_filter_and_index_blocks_in_cache=false
cache_index_and_filter_blocks_with_high_priority=true
cache_index_and_filter_blocks=false
flush_block_policy_factory=FlushBlockBySizePolicyFactory

View file

@ -0,0 +1,187 @@
# This is a RocksDB option file.
#
# For detailed file format spec, please refer to the example file
# in examples/rocksdb_option_file_example.ini
#
[Version]
rocksdb_version=6.26.1
options_file_version=1.1
[DBOptions]
max_open_files=-1
stats_history_buffer_size=1048576
stats_persist_period_sec=600
max_background_flushes=-1
stats_dump_period_sec=600
compaction_readahead_size=0
bytes_per_sync=0
delete_obsolete_files_period_micros=21600000000
max_total_wal_size=0
delayed_write_rate=16777216
wal_bytes_per_sync=0
writable_file_max_buffer_size=1048576
avoid_flush_during_shutdown=false
max_subcompactions=1
strict_bytes_per_sync=false
max_background_compactions=-1
base_background_compactions=-1
max_background_jobs=2
file_checksum_gen_factory=nullptr
db_host_id=__hostname__
bgerror_resume_retry_interval=1000000
best_efforts_recovery=false
avoid_unnecessary_blocking_io=false
two_write_queues=false
atomic_flush=false
preserve_deletes=false
allow_ingest_behind=false
lowest_used_cache_tier=kNonVolatileBlockTier
avoid_flush_during_recovery=false
info_log_level=INFO_LEVEL
access_hint_on_compaction_start=NORMAL
max_bgerror_resume_count=2147483647
write_thread_slow_yield_usec=3
allow_concurrent_memtable_write=true
WAL_ttl_seconds=0
manual_wal_flush=false
dump_malloc_stats=false
wal_recovery_mode=kPointInTimeRecovery
log_file_time_to_roll=0
enable_write_thread_adaptive_yield=true
recycle_log_file_num=0
table_cache_numshardbits=6
max_file_opening_threads=16
allow_data_in_errors=false
use_fsync=false
unordered_write=false
fail_if_options_file_error=false
random_access_max_buffer_size=1048576
new_table_reader_for_compaction_inputs=false
skip_checking_sst_file_sizes_on_db_open=false
skip_stats_update_on_db_open=false
persist_stats_to_disk=false
track_and_verify_wals_in_manifest=false
enable_pipelined_write=false
flush_verify_memtable_count=true
log_readahead_size=0
is_fd_close_on_exec=true
WAL_size_limit_MB=0
experimental_mempurge_threshold=0.000000
write_dbid_to_manifest=false
use_adaptive_mutex=false
error_if_exists=false
write_thread_max_yield_usec=100
enable_thread_tracking=false
db_write_buffer_size=0
create_missing_column_families=false
paranoid_checks=true
create_if_missing=false
wal_filter=nullptr
max_manifest_file_size=1073741824
allow_2pc=false
use_direct_io_for_flush_and_compaction=false
manifest_preallocation_size=4194304
use_direct_reads=false
allow_fallocate=true
max_write_batch_group_size_bytes=1048576
keep_log_file_num=1000
allow_mmap_reads=false
max_log_file_size=0
allow_mmap_writes=false
advise_random_on_open=true
[CFOptions "default"]
bottommost_compression=kDisableCompressionOption
bottommost_compression_opts={max_dict_buffer_bytes=0;enabled=false;parallel_threads=1;zstd_max_train_bytes=0;strategy=0;max_dict_bytes=0;level=32767;window_bits=-14;}
sample_for_compression=0
blob_garbage_collection_force_threshold=1.000000
blob_file_size=268435456
compaction_options_universal={allow_trivial_move=false;incremental=false;stop_style=kCompactionStopStyleTotalSize;compression_size_percent=-1;max_size_amplification_percent=200;max_merge_width=4294967295;min_merge_width=2;size_ratio=1;}
compaction_options_fifo={allow_compaction=false;age_for_warm=0;max_table_files_size=1073741824;}
prefix_extractor=nullptr
max_bytes_for_level_multiplier_additional=1:1:1:1:1:1:1
max_bytes_for_level_base=268435456
memtable_whole_key_filtering=false
memtable_prefix_bloom_size_ratio=0.000000
enable_blob_files=false
target_file_size_base=67108864
memtable_huge_page_size=0
max_successive_merges=0
inplace_update_num_locks=10000
max_sequential_skip_in_iterations=8
arena_block_size=1048576
target_file_size_multiplier=1
max_write_buffer_number=2
write_buffer_size=67108864
blob_compression_type=kNoCompression
compression=kSnappyCompression
level0_stop_writes_trigger=36
level0_slowdown_writes_trigger=20
level0_file_num_compaction_trigger=4
ttl=2592000
max_compaction_bytes=1677721600
blob_garbage_collection_age_cutoff=0.250000
compression_opts={max_dict_buffer_bytes=0;enabled=false;parallel_threads=1;zstd_max_train_bytes=0;strategy=0;max_dict_bytes=0;level=32767;window_bits=-14;}
enable_blob_garbage_collection=false
soft_pending_compaction_bytes_limit=68719476736
paranoid_file_checks=false
periodic_compaction_seconds=0
check_flush_compaction_key_order=true
min_blob_size=0
hard_pending_compaction_bytes_limit=274877906944
disable_auto_compactions=false
max_bytes_for_level_multiplier=10.000000
report_bg_io_stats=false
compaction_pri=kMinOverlappingRatio
compaction_filter_factory=nullptr
comparator=leveldb.BytewiseComparator
sst_partitioner_factory=nullptr
bloom_locality=0
compaction_style=kCompactionStyleLevel
min_write_buffer_number_to_merge=1
max_write_buffer_size_to_maintain=0
max_write_buffer_number_to_maintain=0
merge_operator=nullptr
memtable_factory=SkipListFactory
memtable_insert_with_hint_prefix_extractor=nullptr
num_levels=7
force_consistency_checks=true
optimize_filters_for_hits=false
compaction_filter=nullptr
level_compaction_dynamic_level_bytes=false
inplace_update_support=false
table_factory=BlockBasedTable
[TableOptions/BlockBasedTable "default"]
pin_top_level_index_and_filter=true
block_align=false
read_amp_bytes_per_bit=0
verify_compression=false
enable_index_compression=true
whole_key_filtering=true
max_auto_readahead_size=262144
optimize_filters_for_memory=false
index_block_restart_interval=1
prepopulate_block_cache=kDisable
block_restart_interval=16
block_size=4096
format_version=5
partition_filters=false
block_size_deviation=10
no_block_cache=false
checksum=kCRC32c
data_block_hash_table_util_ratio=0.750000
index_shortening=kShortenSeparators
data_block_index_type=kDataBlockBinarySearch
hash_index_allow_collision=true
filter_policy=nullptr
metadata_block_size=4096
index_type=kBinarySearch
metadata_cache_options={unpartitioned_pinning=kFallback;partition_pinning=kFallback;top_level_index_pinning=kFallback;}
pin_l0_filter_and_index_blocks_in_cache=false
cache_index_and_filter_blocks_with_high_priority=true
cache_index_and_filter_blocks=false
flush_block_policy_factory=FlushBlockBySizePolicyFactory

View file

@ -1,5 +1,3 @@
#!/bin/bash
export CGO_LDFLAGS="-L/usr/local/lib -lrocksdb -lstdc++ -lm -lz -lsnappy -llz4 -lzstd"
export CGO_CFLAGS="-I/usr/local/include/rocksdb"
go build .
lyoshenka commented 2022-04-15 16:12:22 +02:00 (Migrated from github.com)
Review

do you see these changing often? id be careful cause diff versions of protoc could introduce cosmetic changes with big diffs that dont do much. i suggest that building protobufs should be a separate optional build step just for when they change

but if they change often, then its fine to leave it here

do you see these changing often? id be careful cause diff versions of `protoc` could introduce cosmetic changes with big diffs that dont do much. i suggest that building protobufs should be a separate optional build step just for when they change but if they change often, then its fine to leave it here
go test -v -race ./...