Add some blockchain RPC handlers and DB fetching routines #55

Merged
moodyjon merged 15 commits from blockchain_rpc1 into master 2022-09-14 17:23:35 +02:00
9 changed files with 9725 additions and 52 deletions
Showing only changes of commit 789974227f - Show all commits

View file

@ -8,21 +8,57 @@ import (
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"github.com/lbryio/lbcd/chaincfg"
)
// Source: test_variety_of_transactions_and_longish_history (lbry-sdk/tests/integration/transactions)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
const regTestDBPath = "../testdata/test_variety_of_transactions/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
var regTestAddrs = [30]string{
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mtgiQkd35xpx3TaZ4RBNirf3uSMQ8tXQ7z",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mqMjBtzGTtRty7Y54RqeNLk9QE8rYUfpm3",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"n2q8ASDZmib4adu2eU4dPvVvjYeU97pks4",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mzxYWTJogAtduNaeyH9pSSmBSPkJj33HDJ",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mweCKeZkeUUi8RQdHry3Mziphb87vCwiiW",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mp7ZuiZgBNJHFX6DVmeZrCj8SuzVQNDLwb",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"n2zZoBocGCcxe6jFo1anbbAsUFMPXdYfnY",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"msps28KwRJF77DxhzqD98prdwCrZwdUxJc",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mjvkjuss63pq2mpsRn4Q5tsNKVMLG9qUt7",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"miF9cJn8HiX6vsorRDXtZEgcW7BeWowqkX",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mx87wRYFchYaLjXyNaboMuEMRLRboFSPDD",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mhvb94idtQvTSCQk9EB16wLLkSrbWizPRG",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mx3Fu8FDM4nKR9VYtHWPtSGKVt1D588Ay1",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mhqvhX7kLNQ2bUNWZxMhE1z6QEJKrqdV8T",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mgekw8L4xEezFtkYdSarL4sk5Sc8n9UtzG",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"myhFrTz99ZHwbGo7qV4D7fJKfji7YJ3vZ8",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mnf8UCVoo6DBq6Tg4QpnFFdV1mFVHi43TF",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mn7hKyh6EA8oLAPkvTd9vPEgzLRejLxkj2",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"msfarwFff7LX6DkXk295x3YMnJtR5Yw8uy",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mn8sUv6ryiLn4kzssBTqNaB1oL6qcKDzJ4",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mhwgeQFyi1z1RxNR1CphE8PcwG2xBWcxDp",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"n2jKpDXhVaQHiKqhdQYwwykhoYtKtbh8P1",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mhnt4btqpAuiNwjAfFxPEaA4ekCE8faRYN",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mmTFCt6Du1VsdxSKc7f21vYsT75KnRy7NM",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mm1nx1xSmgRponM5tmdq15KREa7f6M36La",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mxMXmMKUqoj19hxEA5r3hZJgirT6nCQh14",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mx2L4iqNGzpuNNsDmjvCpcomefDWLAjdv1",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mohJcUzQdCYL7nEySKNQC8PUzowNS5gGvo",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mjv1vErZiDXsh9TvBDGCBpzobZx7aVYuy7",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"mwDPTZzHsM6p1DfDnBeojDLRCDceTcejkT",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// const dbPath := "/Users/swdev1/hub/scribe_db.599529/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// const dbPath := "/mnt/d/data/snapshot_1072108/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
func TestServerGetHeight(t *testing.T) {
dbPath := "/Users/swdev1/hub/scribe_db.599529/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// dbPath := "/mnt/d/data/snapshot_1072108/lbry-rocksdb/"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
secondaryPath := "asdf"
db, toDefer, err := db.GetProdDB(dbPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
db, toDefer, err := db.GetProdDB(regTestDBPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
defer toDefer()
if err != nil {
t.Skip("DB not found")
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Error(err)
return
}
s := &BlockchainService{
DB: db,
Chain: &chaincfg.MainNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
Chain: &chaincfg.RegressionNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
req := BlockGetServerHeightReq{}
@ -36,23 +72,23 @@ func TestServerGetHeight(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("unmarshal err: %v", err)
}
t.Logf("resp: %v", string(marshalled))
if string(marshalled) != "500" {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("bad height: %v", string(marshalled))
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
func TestGetChunk(t *testing.T) {
dbPath := "/Users/swdev1/hub/scribe_db.599529/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// dbPath := "/mnt/d/data/snapshot_1072108/lbry-rocksdb/"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
secondaryPath := "asdf"
db, toDefer, err := db.GetProdDB(dbPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
db, toDefer, err := db.GetProdDB(regTestDBPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
defer toDefer()
if err != nil {
t.Skip("DB not found")
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Error(err)
return
}
s := &BlockchainService{
DB: db,
Chain: &chaincfg.MainNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
Chain: &chaincfg.RegressionNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
for index := 0; index < 10; index++ {
@ -67,34 +103,42 @@ func TestGetChunk(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("index: %v unmarshal err: %v", index, err)
}
t.Logf("index: %v resp: %v", index, string(marshalled))
if len(*resp) != (CHUNK_SIZE * HEADER_SIZE * 2) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("index: %v bad length: %v", index, len(*resp))
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
switch index {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
case 0, 1, 2, 3, 4:
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
if len(*resp) != (CHUNK_SIZE * HEADER_SIZE * 2) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("index: %v bad length: %v", index, len(*resp))
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
case 5:
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
if len(*resp) != 21*112*2 {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("index: %v bad length: %v", index, len(*resp))
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
default:
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
if len(*resp) != 0 {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("index: %v bad length: %v", index, len(*resp))
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
}
}
func TestGetHeader(t *testing.T) {
dbPath := "/Users/swdev1/hub/scribe_db.599529/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// dbPath := "/mnt/d/data/snapshot_1072108/lbry-rocksdb/"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
secondaryPath := "asdf"
db, toDefer, err := db.GetProdDB(dbPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
db, toDefer, err := db.GetProdDB(regTestDBPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
defer toDefer()
if err != nil {
t.Skip("DB not found")
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Error(err)
return
}
s := &BlockchainService{
DB: db,
Chain: &chaincfg.MainNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
Chain: &chaincfg.RegressionNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
for height := 1000; height < 1010; height++ {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
for height := 0; height < 700; height += 100 {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
req := BlockGetHeaderReq(height)
var resp *BlockGetHeaderResp
err := s.Get_header(nil, &req, &resp)
if err != nil {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
if err != nil && height <= 500 {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Errorf("height: %v handler err: %v", height, err)
}
marshalled, err := json.MarshalIndent(resp, "", " ")
@ -106,13 +150,10 @@ func TestGetHeader(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
func TestGetBalance(t *testing.T) {
dbPath := "/Users/swdev1/hub/scribe_db.599529/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// dbPath := "/mnt/d/data/snapshot_1072108/lbry-rocksdb/"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
secondaryPath := "asdf"
db, toDefer, err := db.GetProdDB(dbPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
db, toDefer, err := db.GetProdDB(regTestDBPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
defer toDefer()
if err != nil {
t.Skip("DB not found")
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Error(err)
return
}
@ -120,16 +161,11 @@ func TestGetBalance(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
s := &BlockchainAddressService{
BlockchainService{
DB: db,
Chain: &chaincfg.MainNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
Chain: &chaincfg.RegressionNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
},
}
addrs := []string{
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"bCoyqs8Pv4pss5EbNuyuokkdkCqEpDoHmG",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"bJr6cLth1UmR7wJ14BMc7ch73xBEEV77fV",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
for _, addr := range addrs {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
for _, addr := range regTestAddrs {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
req := AddressGetBalanceReq{addr}
var resp *AddressGetBalanceResp
err := s.Get_balance(nil, &req, &resp)
@ -145,13 +181,10 @@ func TestGetBalance(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
func TestGetHistory(t *testing.T) {
dbPath := "/Users/swdev1/hub/scribe_db.599529/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// dbPath := "/mnt/d/data/snapshot_1072108/lbry-rocksdb/"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
secondaryPath := "asdf"
db, toDefer, err := db.GetProdDB(dbPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
db, toDefer, err := db.GetProdDB(regTestDBPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
defer toDefer()
if err != nil {
t.Skip("DB not found")
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Error(err)
return
}
@ -159,16 +192,11 @@ func TestGetHistory(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
s := &BlockchainAddressService{
BlockchainService{
DB: db,
Chain: &chaincfg.MainNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
Chain: &chaincfg.RegressionNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
},
}
addrs := []string{
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"bCoyqs8Pv4pss5EbNuyuokkdkCqEpDoHmG",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"bJr6cLth1UmR7wJ14BMc7ch73xBEEV77fV",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
for _, addr := range addrs {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
for _, addr := range regTestAddrs {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
req := AddressGetHistoryReq{addr}
var resp *AddressGetHistoryResp
err := s.Get_history(nil, &req, &resp)
@ -184,13 +212,10 @@ func TestGetHistory(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
func TestListUnspent(t *testing.T) {
dbPath := "/Users/swdev1/hub/scribe_db.599529/lbry-rocksdb"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
// dbPath := "/mnt/d/data/snapshot_1072108/lbry-rocksdb/"
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
secondaryPath := "asdf"
db, toDefer, err := db.GetProdDB(dbPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
db, toDefer, err := db.GetProdDB(regTestDBPath, secondaryPath)
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
defer toDefer()
if err != nil {
t.Skip("DB not found")
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
t.Error(err)
return
}
@ -198,16 +223,11 @@ func TestListUnspent(t *testing.T) {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
s := &BlockchainAddressService{
BlockchainService{
DB: db,
Chain: &chaincfg.MainNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
Chain: &chaincfg.RegressionNetParams,
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
},
}
addrs := []string{
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"bCoyqs8Pv4pss5EbNuyuokkdkCqEpDoHmG",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
"bJr6cLth1UmR7wJ14BMc7ch73xBEEV77fV",
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
}
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
for _, addr := range addrs {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
for _, addr := range regTestAddrs {
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
req := AddressListUnspentReq{addr}
var resp *AddressListUnspentResp
err := s.Listunspent(nil, &req, &resp)

jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.
jeffreypicard commented 2022-09-09 10:05:19 +02:00 (Migrated from github.com)
Review

Are these tests not running in the ci? This isn't going to work when run in the ci.

Are these tests not running in the ci? This isn't going to work when run in the ci.
jeffreypicard commented 2022-09-11 12:30:05 +02:00 (Migrated from github.com)
Review

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there.

     jsonrpc_blockchain_test.go:18: DB not found
--- SKIP: TestServerGetHeight (0.00s)
=== RUN   TestGetChunk
    jsonrpc_blockchain_test.go:48: DB not found
--- SKIP: TestGetChunk (0.00s)
=== RUN   TestGetHeader
    jsonrpc_blockchain_test.go:83: DB not found
--- SKIP: TestGetHeader (0.00s)
=== RUN   TestGetBalance
    jsonrpc_blockchain_test.go:115: DB not found
--- SKIP: TestGetBalance (0.00s)
=== RUN   TestGetHistory
    jsonrpc_blockchain_test.go:154: DB not found
--- SKIP: TestGetHistory (0.00s)
=== RUN   TestListUnspent
    jsonrpc_blockchain_test.go:193: DB not found
--- SKIP: TestListUnspent (0.00s)

let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.

So I checked out your branch and ran the tests, it all passes, but it skips these tests because the DB isn't there. ``` jsonrpc_blockchain_test.go:18: DB not found --- SKIP: TestServerGetHeight (0.00s) === RUN TestGetChunk jsonrpc_blockchain_test.go:48: DB not found --- SKIP: TestGetChunk (0.00s) === RUN TestGetHeader jsonrpc_blockchain_test.go:83: DB not found --- SKIP: TestGetHeader (0.00s) === RUN TestGetBalance jsonrpc_blockchain_test.go:115: DB not found --- SKIP: TestGetBalance (0.00s) === RUN TestGetHistory jsonrpc_blockchain_test.go:154: DB not found --- SKIP: TestGetHistory (0.00s) === RUN TestListUnspent jsonrpc_blockchain_test.go:193: DB not found --- SKIP: TestListUnspent (0.00s) ``` let's get figure out a way to get some test data in there, or at least download it or something so we can run those tests, and then this looks good.
moodyjon commented 2022-09-12 23:14:23 +02:00 (Migrated from github.com)
Review

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history".

I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.

I have a technique to get test data from lbry-sdk test "test_variety_of_transactions_and_longish_history". I'm waiting for the EffectiveAmount & RepostedCount to be stabilized. Then I will regenerate from that version of scribe.
moodyjon commented 2022-09-13 22:08:13 +02:00 (Migrated from github.com)
Review

Added sample data from lbry-sdk integration test. Reworked tests to match.

Added sample data from lbry-sdk integration test. Reworked tests to match.

Binary file not shown.

View file

@ -0,0 +1 @@
MANIFEST-000004

View file

@ -0,0 +1 @@
2c7866e6-c325-4a0e-bfac-4cb01a746a45

File diff suppressed because it is too large Load diff

Binary file not shown.

File diff suppressed because it is too large Load diff

File diff suppressed because it is too large Load diff