integration testing scripts #64

Merged
jeffreypicard merged 8 commits from integration_testing into master 2022-10-04 19:25:44 +02:00
9 changed files with 341 additions and 14 deletions

View file

@ -8,6 +8,7 @@ import (
"encoding/hex"
"fmt"
"os"
"sync"
"time"
"github.com/lbryio/herald.go/db/prefixes"
@ -58,8 +59,11 @@ type ReadOnlyDBColumnFamily struct {
BlockedChannels map[string][]byte
FilteredStreams map[string][]byte
FilteredChannels map[string][]byte
OpenIterators map[string][]chan struct{}
ItMut sync.RWMutex
ShutdownChan chan struct{}
DoneChan chan struct{}
ShutdownCalled bool
Cleanup func()
}
@ -318,9 +322,38 @@ func intMin(a, b int) int {
return b
}
// FIXME: This was copied from the signal.go file, maybe move it to a more common place?
// interruptRequested returns true when the channel returned by
// interruptListener was closed. This simplifies early shutdown slightly since
// the caller can just use an if statement instead of a select.
func interruptRequested(interrupted <-chan struct{}) bool {
select {
case <-interrupted:
return true
default:
}
return false
}
func IterCF(db *grocksdb.DB, opts *IterOptions) <-chan *prefixes.PrefixRowKV {
ch := make(chan *prefixes.PrefixRowKV)
iterKey := fmt.Sprintf("%p", opts)
if opts.DB != nil {
opts.DB.ItMut.Lock()
// There is a tiny chance that we were wating on the above lock while shutdown was
// being called and by the time we get it the db has already notified all active
// iterators to shutdown. In this case we go to the else branch.
if !opts.DB.ShutdownCalled {
opts.DB.OpenIterators[iterKey] = []chan struct{}{opts.DoneChan, opts.ShutdownChan}
opts.DB.ItMut.Unlock()
} else {
opts.DB.ItMut.Unlock()
return ch
}
}
ro := grocksdb.NewDefaultReadOptions()
ro.SetFillCache(opts.FillCache)
it := db.NewIteratorCF(ro, opts.CfHandle)
@ -336,6 +369,12 @@ func IterCF(db *grocksdb.DB, opts *IterOptions) <-chan *prefixes.PrefixRowKV {
it.Close()
close(ch)
ro.Destroy()
if opts.DB != nil {
opts.DoneChan <- struct{}{}
opts.DB.ItMut.Lock()
delete(opts.DB.OpenIterators, iterKey)
opts.DB.ItMut.Unlock()
}
}()
var prevKey []byte
@ -355,6 +394,9 @@ func IterCF(db *grocksdb.DB, opts *IterOptions) <-chan *prefixes.PrefixRowKV {
if kv = opts.ReadRow(&prevKey); kv != nil {
ch <- kv
}
if interruptRequested(opts.ShutdownChan) {
return
}
}
}()
@ -412,7 +454,7 @@ func (db *ReadOnlyDBColumnFamily) selectFrom(prefix []byte, startKey, stopKey pr
return nil, err
}
// Prefix and handle
options := NewIterateOptions().WithPrefix(prefix).WithCfHandle(handle)
options := NewIterateOptions().WithDB(db).WithPrefix(prefix).WithCfHandle(handle)
// Start and stop bounds
options = options.WithStart(startKey.PackKey()).WithStop(stopKey.PackKey()).WithIncludeStop(true)
// Don't include the key
@ -514,6 +556,7 @@ func GetProdDB(name string, secondaryPath string) (*ReadOnlyDBColumnFamily, func
}
db, err := GetDBColumnFamilies(name, secondaryPath, cfNames)
db.OpenIterators = make(map[string][]chan struct{})
cleanupFiles := func() {
err = os.RemoveAll(secondaryPath)
@ -572,8 +615,11 @@ func GetDBColumnFamilies(name string, secondayPath string, cfNames []string) (*R
LastState: nil,
Height: 0,
Headers: nil,
ShutdownChan: make(chan struct{}),
DoneChan: make(chan struct{}),
OpenIterators: make(map[string][]chan struct{}),
ItMut: sync.RWMutex{},
ShutdownChan: make(chan struct{}, 1),
ShutdownCalled: false,
DoneChan: make(chan struct{}, 1),
}
err = myDB.ReadDBState() //TODO: Figure out right place for this
@ -643,6 +689,15 @@ func (db *ReadOnlyDBColumnFamily) Unwind() {
// Shutdown shuts down the db.
func (db *ReadOnlyDBColumnFamily) Shutdown() {
db.ShutdownChan <- struct{}{}
db.ItMut.Lock()
db.ShutdownCalled = true
for _, it := range db.OpenIterators {
it[1] <- struct{}{}
}
for _, it := range db.OpenIterators {
<-it[0]
}
db.ItMut.Unlock()
<-db.DoneChan
db.Cleanup()
}
@ -790,7 +845,7 @@ func (db *ReadOnlyDBColumnFamily) InitHeaders() error {
// endKey := prefixes.NewHeaderKey(db.LastState.Height)
startKeyRaw := startKey.PackKey()
// endKeyRaw := endKey.PackKey()
options := NewIterateOptions().WithPrefix([]byte{prefixes.Header}).WithCfHandle(handle)
options := NewIterateOptions().WithDB(db).WithPrefix([]byte{prefixes.Header}).WithCfHandle(handle)
options = options.WithIncludeKey(false).WithIncludeValue(true) //.WithIncludeStop(true)
options = options.WithStart(startKeyRaw) //.WithStop(endKeyRaw)
@ -813,7 +868,7 @@ func (db *ReadOnlyDBColumnFamily) InitTxCounts() error {
db.TxCounts = stack.NewSliceBacked[uint32](InitialTxCountSize)
options := NewIterateOptions().WithPrefix([]byte{prefixes.TxCount}).WithCfHandle(handle)
options := NewIterateOptions().WithDB(db).WithPrefix([]byte{prefixes.TxCount}).WithCfHandle(handle)
options = options.WithIncludeKey(false).WithIncludeValue(true).WithIncludeStop(true)
ch := IterCF(db.DB, options)

View file

@ -94,7 +94,7 @@ func (db *ReadOnlyDBColumnFamily) GetHeaders(height uint32, count uint32) ([][11
startKeyRaw := prefixes.NewHeaderKey(height).PackKey()
endKeyRaw := prefixes.NewHeaderKey(height + count).PackKey()
options := NewIterateOptions().WithPrefix([]byte{prefixes.Header}).WithCfHandle(handle)
options := NewIterateOptions().WithDB(db).WithPrefix([]byte{prefixes.Header}).WithCfHandle(handle)
options = options.WithIncludeKey(false).WithIncludeValue(true) //.WithIncludeStop(true)
options = options.WithStart(startKeyRaw).WithStop(endKeyRaw)
@ -130,7 +130,7 @@ func (db *ReadOnlyDBColumnFamily) GetBalance(hashX []byte) (uint64, uint64, erro
startKeyRaw := startKey.PackKey()
endKeyRaw := endKey.PackKey()
// Prefix and handle
options := NewIterateOptions().WithPrefix([]byte{prefixes.UTXO}).WithCfHandle(handle)
options := NewIterateOptions().WithDB(db).WithPrefix([]byte{prefixes.UTXO}).WithCfHandle(handle)
// Start and stop bounds
options = options.WithStart(startKeyRaw).WithStop(endKeyRaw).WithIncludeStop(true)
// Don't include the key
@ -346,7 +346,7 @@ func (db *ReadOnlyDBColumnFamily) GetStreamsAndChannelRepostedByChannelHashes(re
for _, reposterChannelHash := range reposterChannelHashes {
key := prefixes.NewChannelToClaimKeyWHash(reposterChannelHash)
rawKeyPrefix := key.PartialPack(1)
options := NewIterateOptions().WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options := NewIterateOptions().WithDB(db).WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options = options.WithIncludeKey(false).WithIncludeValue(true)
ch := IterCF(db.DB, options)
// for stream := range Iterate(db.DB, prefixes.ChannelToClaim, []byte{reposterChannelHash}, false) {
@ -420,7 +420,7 @@ func (db *ReadOnlyDBColumnFamily) GetShortClaimIdUrl(name string, normalizedName
log.Printf("partialKey: %#v\n", partialKey)
keyPrefix := partialKey.PartialPack(2)
// Prefix and handle
options := NewIterateOptions().WithPrefix(prefix).WithCfHandle(handle)
options := NewIterateOptions().WithDB(db).WithPrefix(prefix).WithCfHandle(handle)
// Start and stop bounds
options = options.WithStart(keyPrefix).WithStop(keyPrefix)
// Don't include the key
@ -518,7 +518,7 @@ func (db *ReadOnlyDBColumnFamily) GetActiveAmount(claimHash []byte, txoType uint
startKeyRaw := startKey.PartialPack(3)
endKeyRaw := endKey.PartialPack(3)
// Prefix and handle
options := NewIterateOptions().WithPrefix([]byte{prefixes.ActiveAmount}).WithCfHandle(handle)
options := NewIterateOptions().WithDB(db).WithPrefix([]byte{prefixes.ActiveAmount}).WithCfHandle(handle)
// Start and stop bounds
options = options.WithStart(startKeyRaw).WithStop(endKeyRaw)
// Don't include the key
@ -674,7 +674,7 @@ func (db *ReadOnlyDBColumnFamily) ControllingClaimIter() <-chan *prefixes.Prefix
key := prefixes.NewClaimTakeoverKey("")
var rawKeyPrefix []byte = nil
rawKeyPrefix = key.PartialPack(0)
options := NewIterateOptions().WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options := NewIterateOptions().WithDB(db).WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options = options.WithIncludeValue(true) //.WithIncludeStop(true)
ch := IterCF(db.DB, options)
return ch
@ -785,7 +785,7 @@ func (db *ReadOnlyDBColumnFamily) BidOrderNameIter(normalizedName string) <-chan
key := prefixes.NewBidOrderKey(normalizedName)
var rawKeyPrefix []byte = nil
rawKeyPrefix = key.PartialPack(1)
options := NewIterateOptions().WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options := NewIterateOptions().WithDB(db).WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options = options.WithIncludeValue(true) //.WithIncludeStop(true)
ch := IterCF(db.DB, options)
return ch
@ -803,7 +803,7 @@ func (db *ReadOnlyDBColumnFamily) ClaimShortIdIter(normalizedName string, claimI
} else {
rawKeyPrefix = key.PartialPack(1)
}
options := NewIterateOptions().WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options := NewIterateOptions().WithDB(db).WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options = options.WithIncludeValue(true) //.WithIncludeStop(true)
ch := IterCF(db.DB, options)
return ch

View file

@ -326,7 +326,7 @@ func (db *ReadOnlyDBColumnFamily) ResolveClaimInChannel(channelHash []byte, norm
key := prefixes.NewChannelToClaimKey(channelHash, normalizedName)
rawKeyPrefix := key.PartialPack(2)
options := NewIterateOptions().WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options := NewIterateOptions().WithDB(db).WithCfHandle(handle).WithPrefix(rawKeyPrefix)
options = options.WithIncludeValue(true) //.WithIncludeStop(true)
ch := IterCF(db.DB, options)
// TODO: what's a good default size for this?

View file

@ -7,6 +7,7 @@ import (
"log"
"os"
"strings"
"sync"
"testing"
dbpkg "github.com/lbryio/herald.go/db"
@ -93,6 +94,11 @@ func OpenAndFillTmpDBColumnFamlies(filePath string) (*dbpkg.ReadOnlyDBColumnFami
LastState: nil,
Height: 0,
Headers: nil,
OpenIterators: make(map[string][]chan struct{}),
ItMut: sync.RWMutex{},
ShutdownChan: make(chan struct{}, 1),
DoneChan: make(chan struct{}, 1),
ShutdownCalled: false,
}
// err = dbpkg.ReadDBState(myDB) //TODO: Figure out right place for this

View file

@ -22,6 +22,9 @@ type IterOptions struct {
IncludeValue bool
RawKey bool
RawValue bool
ShutdownChan chan struct{}
DoneChan chan struct{}
DB *ReadOnlyDBColumnFamily
CfHandle *grocksdb.ColumnFamilyHandle
It *grocksdb.Iterator
Serializer *prefixes.SerializationAPI
@ -40,6 +43,9 @@ func NewIterateOptions() *IterOptions {
IncludeValue: false,
RawKey: false,
RawValue: false,
ShutdownChan: make(chan struct{}),
DoneChan: make(chan struct{}),
DB: nil,
CfHandle: nil,
It: nil,
Serializer: prefixes.ProductionAPI,
@ -101,6 +107,11 @@ func (o *IterOptions) WithRawValue(rawValue bool) *IterOptions {
return o
}
func (o *IterOptions) WithDB(db *ReadOnlyDBColumnFamily) *IterOptions {
o.DB = db
return o
}
func (o *IterOptions) WithSerializer(serializer *prefixes.SerializationAPI) *IterOptions {
o.Serializer = serializer
return o

View file

@ -0,0 +1,13 @@
FROM jeffreypicard/hub-github-env:dev
COPY scripts/integration_tests.sh /integration_tests.sh
COPY scripts/cicd_integration_test_runner.sh /cicd_integration_test_runner.sh
COPY herald /herald
RUN apt install -y jq curl
ENV CGO_LDFLAGS "-L/usr/local/lib -lrocksdb -lstdc++ -lm -lz -lsnappy -llz4 -lzstd"
ENV CGO_CFLAGS "-I/usr/local/include/rocksdb"
ENV LD_LIBRARY_PATH /usr/local/lib
ENTRYPOINT ["/cicd_integration_test_runner.sh"]

View file

@ -0,0 +1,14 @@
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
#!/bin/bash
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
#
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
# cicd_integration_test_runner.sh
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
#
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
# simple script to kick off herald and call the integration testing
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
# script
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
#
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
# N.B. this currently just works locally until we figure a way to have
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
# the data in the cicd environment.
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
#
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
./herald serve --db-path /mnt/sdb1/wallet_server/_data/lbry-rocksdb &
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.
./integration_tests.sh
moodyjon commented 2022-09-21 19:56:16 +02:00 (Migrated from github.com)
Review

This is missing herald launch, and calling integration_tests.sh.

This is missing herald launch, and calling integration_tests.sh.

206
scripts/integration_tests.sh Executable file
View file

@ -0,0 +1,206 @@
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#!/bin/bash
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# integration_testing.sh
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# GitHub Action CI/CD based integration tests for herald.go
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# These are smoke / sanity tests for the server behaving correctly on a "live"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# system, and looks for reasonable response codes, not specific correct
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# behavior. Those are covered in unit tests.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# N.B.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# For the curl based json tests the `id` field existing is needed.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# global variables
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
RES=(0)
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
FINALRES=0
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# functions
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
function logical_or {
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
for res in ${RES[@]}; do
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
if [ $res -eq 1 -o $FINALRES -eq 1 ]; then
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
FINALRES=1
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
return
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
fi
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
done
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
}
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
function want_got {
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
if [ "${WANT}" != "${GOT}" ]; then
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
echo "WANT: ${WANT}"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
echo "GOT: ${GOT}"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
RES+=(1)
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
else
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
RES+=(0)
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
fi
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
}
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
function want_greater {
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
if [ ${WANT} -ge ${GOT} ]; then
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
echo "WANT: ${WANT}"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
echo "GOT: ${GOT}"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
RES+=(1)
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
else
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
RES+=(0)
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
fi
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
}
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
function test_command_with_want {
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
echo $CMD
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
GOT=`eval $CMD`
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
want_got
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
}
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# grpc endpoint testing
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
grpcurl -plaintext -d '{"value": ["@Styxhexenhammer666:2"]}' 127.0.0.1:50051 pb.Hub.Resolve
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .txos[0].txHash | sed 's/"//g'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT="VOFP8MQEwps9Oa5NJJQ18WfVzUzlpCjst0Wz3xyOPd4="
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# GOT=`eval $CMD`
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#want_got
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
##
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## N.B. This is a degenerate case that takes a long time to run.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## The runtime should be fixed, but in the meantime, we definitely should
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## ensure this behaves as expected.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
##
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## TODO: Test runtime doesn't exceed worst case.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
##
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#WANT=806389
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# grpcurl -plaintext -d '{"value": ["foo"]}' 127.0.0.1:50051 pb.Hub.Resolve | jq .txos[0].height
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
#EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# json rpc endpoint testing
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.block
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
### blockchain.block.get_chunk
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.block.get_chunk", "params": [0]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .result | sed 's/"//g' | head -c 100
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT="010000000000000000000000000000000000000000000000000000000000000000000000cc59e59ff97ac092b55e423aa549"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
### blockchain.block.get_header
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.block.get_header", "params": []}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .result.timestamp
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT=1446058291
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
### blockchain.block.headers
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.block.headers", "params": []}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .result.count
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT=0
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.claimtrie
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.claimtrie.resolve", "params":[{"Data": ["@Styxhexenhammer666:2"]}]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .result.txos[0].tx_hash | sed 's/"//g'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT="VOFP8MQEwps9Oa5NJJQ18WfVzUzlpCjst0Wz3xyOPd4="
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.address
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
### blockchain.address.get_balance
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.address.get_balance", "params":[{"Address": "bGqWuXRVm5bBqLvLPEQQpvsNxJ5ubc6bwN"}]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .result.confirmed
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT=44415602186
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.address.get_history
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.address.get_history", "params":[{"Address": "bGqWuXRVm5bBqLvLPEQQpvsNxJ5ubc6bwN"}]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq '.result.confirmed | length'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT=82
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.address.listunspent
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.address.listunspent", "params":[{"Address": "bGqWuXRVm5bBqLvLPEQQpvsNxJ5ubc6bwN"}]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq '.result | length'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT=32
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# blockchain.scripthash
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.scripthash.get_mempool
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.scripthash.get_mempool", "params":[{"scripthash": "bGqWuXRVm5bBqLvLPEQQpvsNxJ5ubc6bwN"}]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .error | sed 's/"//g'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT="encoding/hex: invalid byte: U+0047 'G'"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:41:45 +02:00 (Migrated from github.com)
Review

Yeah.... the scripthash ones are tricky. I don't have an example of constructing one. Lbry-sdk does not send them.

I haven't figured it out yet, but see:
https://github.com/btcsuite/btcd/search?p=1&q=AddressScriptHash&type=Code

Yeah.... the scripthash ones are tricky. I don't have an example of constructing one. Lbry-sdk does not send them. I haven't figured it out yet, but see: https://github.com/btcsuite/btcd/search?p=1&q=AddressScriptHash&type=Code
moodyjon commented 2022-09-22 19:02:40 +02:00 (Migrated from github.com)
Review

Just found this. Purports to convert addr to scripthash:
https://github.com/checksum0/go-electrum/blob/b862ac442cf9/electrum/address.go#L14

Just found this. Purports to convert addr to scripthash: https://github.com/checksum0/go-electrum/blob/b862ac442cf9/electrum/address.go#L14
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.scripthash.get_history
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.scripthash.get_history", "params":[{"scripthash": "bGqWuXRVm5bBqLvLPEQQpvsNxJ5ubc6bwN"}]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .error | sed 's/"//g'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT="encoding/hex: invalid byte: U+0047 'G'"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
## blockchain.scripthash.listunspent
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
read -r -d '' CMD <<- EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
curl http://127.0.0.1:50001/rpc -s -H "Content-Type: application/json"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
--data '{"id": 1, "method": "blockchain.scripthash.listunspent", "params":[{"scripthash": "bGqWuXRVm5bBqLvLPEQQpvsNxJ5ubc6bwN"}]}'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
| jq .error | sed 's/"//g'
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
EOM
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT="encoding/hex: invalid byte: U+0047 'G'"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
test_command_with_want
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# metrics endpoint testing
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
WANT=0
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
GOT=$(curl http://127.0.0.1:2112/metrics -s | grep requests | grep resolve | awk '{print $NF}')
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
want_greater
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
# caclulate return value
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
logical_or $RES
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
if [ $FINALRES -eq 1 ]; then
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
echo "Failed!"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
exit 1
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
else
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
echo "Passed!"
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
exit 0
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.
fi
moodyjon commented 2022-09-21 19:48:48 +02:00 (Migrated from github.com)
Review

Suggest substituting the value here, and eliminating CHUNK_TEST_RES as it's not reused by other tests.

Suggest substituting the value here, and eliminating `CHUNK_TEST_RES` as it's not reused by other tests.
moodyjon commented 2022-09-21 20:02:27 +02:00 (Migrated from github.com)
Review

Greater than or equal to (-ge). At least for the one test using this, you wouldn't want GOT=0 to pass.

Greater than or equal to (`-ge`). At least for the one test using this, you wouldn't want GOT=0 to pass.
jeffreypicard commented 2022-09-24 08:04:16 +02:00 (Migrated from github.com)
Review

I think I've just transposed the WANT and GOT, but the -gt is correct. I want a number greater than 0.

I think I've just transposed the WANT and GOT, but the `-gt` is correct. I want a number greater than 0.
jeffreypicard commented 2022-09-24 08:28:09 +02:00 (Migrated from github.com)
Review

Actually, nvm, you are right.

Actually, nvm, you are right.

View file

@ -18,6 +18,8 @@ import (
"github.com/lbryio/lbcd/wire"
"github.com/lbryio/lbcutil"
"golang.org/x/exp/constraints"
log "github.com/sirupsen/logrus"
)
// BlockchainBlockService methods handle "blockchain.block.*" RPCs
@ -120,6 +122,7 @@ func (s *BlockchainBlockService) Get_chunk(req *BlockGetChunkReq, resp **BlockGe
index := uint32(*req)
db_headers, err := s.DB.GetHeaders(index*CHUNK_SIZE, CHUNK_SIZE)
if err != nil {
log.Warn(err)
return err
}
raw := make([]byte, 0, HEADER_SIZE*len(db_headers))
@ -141,6 +144,7 @@ func (s *BlockchainBlockService) Get_header(req *BlockGetHeaderReq, resp **Block
height := uint32(*req)
headers, err := s.DB.GetHeaders(height, 1)
if err != nil {
log.Warn(err)
return err
}
if len(headers) < 1 {
@ -171,6 +175,7 @@ func (s *BlockchainBlockService) Headers(req *BlockHeadersReq, resp **BlockHeade
count := min(req.Count, MAX_CHUNK_SIZE)
db_headers, err := s.DB.GetHeaders(req.StartHeight, count)
if err != nil {
log.Warn(err)
return err
}
count = uint32(len(db_headers))
@ -283,18 +288,22 @@ type AddressGetBalanceResp struct {
func (s *BlockchainAddressService) Get_balance(req *AddressGetBalanceReq, resp **AddressGetBalanceResp) error {
address, err := lbcutil.DecodeAddress(req.Address, s.Chain)
if err != nil {
log.Warn(err)
return err
}
script, err := txscript.PayToAddrScript(address)
if err != nil {
log.Warn(err)
return err
}
hashX := hashXScript(script, s.Chain)
confirmed, unconfirmed, err := s.DB.GetBalance(hashX)
if err != nil {
log.Warn(err)
return err
}
*resp = &AddressGetBalanceResp{confirmed, unconfirmed}
return err
}
@ -310,11 +319,13 @@ type ScripthashGetBalanceResp struct {
func (s *BlockchainScripthashService) Get_balance(req *scripthashGetBalanceReq, resp **ScripthashGetBalanceResp) error {
scripthash, err := decodeScriptHash(req.ScriptHash)
if err != nil {
log.Warn(err)
return err
}
hashX := hashX(scripthash)
confirmed, unconfirmed, err := s.DB.GetBalance(hashX)
if err != nil {
log.Warn(err)
return err
}
*resp = &ScripthashGetBalanceResp{confirmed, unconfirmed}
@ -341,15 +352,18 @@ type AddressGetHistoryResp struct {
func (s *BlockchainAddressService) Get_history(req *AddressGetHistoryReq, resp **AddressGetHistoryResp) error {
address, err := lbcutil.DecodeAddress(req.Address, s.Chain)
if err != nil {
log.Warn(err)
return err
}
script, err := txscript.PayToAddrScript(address)
if err != nil {
log.Warn(err)
return err
}
hashX := hashXScript(script, s.Chain)
dbTXs, err := s.DB.GetHistory(hashX)
if err != nil {
log.Warn(err)
return err
}
confirmed := make([]TxInfo, 0, len(dbTXs))
@ -380,11 +394,13 @@ type ScripthashGetHistoryResp struct {
func (s *BlockchainScripthashService) Get_history(req *ScripthashGetHistoryReq, resp **ScripthashGetHistoryResp) error {
scripthash, err := decodeScriptHash(req.ScriptHash)
if err != nil {
log.Warn(err)
return err
}
hashX := hashX(scripthash)
dbTXs, err := s.DB.GetHistory(hashX)
if err != nil {
log.Warn(err)
return err
}
confirmed := make([]TxInfo, 0, len(dbTXs))
@ -412,10 +428,12 @@ type AddressGetMempoolResp []TxInfoFee
func (s *BlockchainAddressService) Get_mempool(req *AddressGetMempoolReq, resp **AddressGetMempoolResp) error {
address, err := lbcutil.DecodeAddress(req.Address, s.Chain)
if err != nil {
log.Warn(err)
return err
}
script, err := txscript.PayToAddrScript(address)
if err != nil {
log.Warn(err)
return err
}
hashX := hashXScript(script, s.Chain)
@ -436,6 +454,7 @@ type ScripthashGetMempoolResp []TxInfoFee
func (s *BlockchainScripthashService) Get_mempool(req *ScripthashGetMempoolReq, resp **ScripthashGetMempoolResp) error {
scripthash, err := decodeScriptHash(req.ScriptHash)
if err != nil {
log.Warn(err)
return err
}
hashX := hashX(scripthash)
@ -462,10 +481,12 @@ type AddressListUnspentResp []TXOInfo
func (s *BlockchainAddressService) Listunspent(req *AddressListUnspentReq, resp **AddressListUnspentResp) error {
address, err := lbcutil.DecodeAddress(req.Address, s.Chain)
if err != nil {
log.Warn(err)
return err
}
script, err := txscript.PayToAddrScript(address)
if err != nil {
log.Warn(err)
return err
}
hashX := hashXScript(script, s.Chain)
@ -494,6 +515,7 @@ type ScripthashListUnspentResp []TXOInfo
func (s *BlockchainScripthashService) Listunspent(req *ScripthashListUnspentReq, resp **ScripthashListUnspentResp) error {
scripthash, err := decodeScriptHash(req.ScriptHash)
if err != nil {
log.Warn(err)
return err
}
hashX := hashX(scripthash)