LBRYCommunity/herald.go
1
0
Fork 0
Code Issues 16 Pull requests Projects Releases 14 Packages Wiki Activity

JSON RPC compatibility workarounds to support lbry-sdk #75

Merged
moodyjon merged 3 commits from jsonrpc_compat1 into master 2022-10-29 17:42:24 +02:00
Conversation 1 Commits 3 Files changed 3 -4
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 3bdad6ccf8 - Show all commits

4
signal.go
View file

@ -49,10 +49,6 @@ func interruptListener() <-chan struct{} {
case sig := <-interruptChannel:
log.Infof("Received signal (%s). Already "+
"shutting down...", sig)
case <-shutdownRequestChannel:
log.Info("Shutdown requested. Already " +
"shutting down...")
}
jeffreypicard commented 2022-10-29 15:45:15 +02:00 (Migrated from github.com)
Review
Copy link

I think this should actually stay. I identified the issue with the spamming when it's killed, which was using the stop.Ch() as the shutdownRequestChannel, keeping it as a second channel that could be used later on to possibly kill this from the outside still makes sense.

I think this should actually stay. I identified the issue with the spamming when it's killed, which was using the stop.Ch() as the shutdownRequestChannel, keeping it as a second channel that could be used later on to possibly kill this from the outside still makes sense.
}
}()